[INFO] updating cached repository Leonti/rust-socket-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Leonti/rust-socket-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Leonti/rust-socket-server" "work/ex/clippy-test-run/sources/stable/gh/Leonti/rust-socket-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Leonti/rust-socket-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Leonti/rust-socket-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Leonti/rust-socket-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Leonti/rust-socket-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a2775eec12282861d3e95e914af21c1becc6d3e3 [INFO] sha for GitHub repo Leonti/rust-socket-server: a2775eec12282861d3e95e914af21c1becc6d3e3 [INFO] validating manifest of Leonti/rust-socket-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Leonti/rust-socket-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Leonti/rust-socket-server [INFO] finished frobbing Leonti/rust-socket-server [INFO] frobbed toml for Leonti/rust-socket-server written to work/ex/clippy-test-run/sources/stable/gh/Leonti/rust-socket-server/Cargo.toml [INFO] started frobbing Leonti/rust-socket-server [INFO] finished frobbing Leonti/rust-socket-server [INFO] frobbed toml for Leonti/rust-socket-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Leonti/rust-socket-server/Cargo.toml [INFO] crate Leonti/rust-socket-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Leonti/rust-socket-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Leonti/rust-socket-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4608bfc15c53a7a0c4d44de57577eda66931ef89b3b3422497f4cfee813d788 [INFO] running `"docker" "start" "-a" "d4608bfc15c53a7a0c4d44de57577eda66931ef89b3b3422497f4cfee813d788"` [INFO] [stderr] Compiling same-file v1.0.4 [INFO] [stderr] Compiling serde_json v1.0.33 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking libudev-sys v0.1.4 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking nix v0.6.0 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Compiling walkdir v2.2.6 [INFO] [stderr] Checking tungstenite v0.6.1 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking serialport v3.1.0 [INFO] [stderr] Checking mio-serial v3.1.0 [INFO] [stderr] Checking spidev v0.3.0 [INFO] [stderr] Compiling cargo_metadata v0.5.8 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking mcp3008 v1.0.0 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Checking sysfs_gpio v0.5.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-serial v3.1.0 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling i2cdev v0.3.2 [INFO] [stderr] Checking tokio-dns-unofficial v0.3.1 [INFO] [stderr] Checking tokio-tungstenite v0.6.0 [INFO] [stderr] Checking rover_server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/pca9685.rs:27:37 [INFO] [stderr] | [INFO] [stderr] 27 | let mut pca9685 = PCA9685 { device: device }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: literal with an empty format string [INFO] [stderr] --> src/sensors/encoder.rs:53:65 [INFO] [stderr] | [INFO] [stderr] 53 | Err(e) => println!("Interrupt failed on pin {} {}", 23, e), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::print_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] error: literal with an empty format string [INFO] [stderr] --> src/sensors/encoder.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | Err(e) => println!("Interrupt failed on pin {} {}", 22, e), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/pca9685.rs:27:37 [INFO] [stderr] | [INFO] [stderr] 27 | let mut pca9685 = PCA9685 { device: device }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: literal with an empty format string [INFO] [stderr] --> src/sensors/encoder.rs:53:65 [INFO] [stderr] | [INFO] [stderr] 53 | Err(e) => println!("Interrupt failed on pin {} {}", 23, e), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::print_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] error: literal with an empty format string [INFO] [stderr] --> src/sensors/encoder.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | Err(e) => println!("Interrupt failed on pin {} {}", 22, e), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/pca9685.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | let mut prescalelevel = 25000000.0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `25_000_000.0` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unreadable_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/sensors/arduino.rs:176:30 [INFO] [stderr] | [INFO] [stderr] 176 | settings.baud_rate = 115200; [INFO] [stderr] | ^^^^^^ help: consider: `115_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: unneeded unit return type [INFO] [stderr] --> src/sensors/encoder.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn run(self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unused_unit)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/sensors/encoder.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit return type [INFO] [stderr] --> src/motor.rs:84:57 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn set_speed(&mut self, side: Side, speed: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/motor.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/motor.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/motor_handler.rs:202:25 [INFO] [stderr] | [INFO] [stderr] 202 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/motor_handler.rs:208:25 [INFO] [stderr] | [INFO] [stderr] 208 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/main.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/pca9685.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | let mut prescalelevel = 25000000.0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `25_000_000.0` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unreadable_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/sensors/arduino.rs:176:30 [INFO] [stderr] | [INFO] [stderr] 176 | settings.baud_rate = 115200; [INFO] [stderr] | ^^^^^^ help: consider: `115_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: unneeded unit return type [INFO] [stderr] --> src/sensors/encoder.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn run(self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unused_unit)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/sensors/encoder.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit return type [INFO] [stderr] --> src/motor.rs:84:57 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn set_speed(&mut self, side: Side, speed: f32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/motor.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/motor.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/motor_handler.rs:202:25 [INFO] [stderr] | [INFO] [stderr] 202 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/motor_handler.rs:208:25 [INFO] [stderr] | [INFO] [stderr] 208 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/main.rs:365:21 [INFO] [stderr] | [INFO] [stderr] 365 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rover_server`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rover_server`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d4608bfc15c53a7a0c4d44de57577eda66931ef89b3b3422497f4cfee813d788"` [INFO] running `"docker" "rm" "-f" "d4608bfc15c53a7a0c4d44de57577eda66931ef89b3b3422497f4cfee813d788"` [INFO] [stdout] d4608bfc15c53a7a0c4d44de57577eda66931ef89b3b3422497f4cfee813d788