[INFO] updating cached repository LeoTindall/rloris [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LeoTindall/rloris [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LeoTindall/rloris" "work/ex/clippy-test-run/sources/stable/gh/LeoTindall/rloris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LeoTindall/rloris'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LeoTindall/rloris" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LeoTindall/rloris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LeoTindall/rloris'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dd9c3f4751f3fa6884b79aea42140d00615b1294 [INFO] sha for GitHub repo LeoTindall/rloris: dd9c3f4751f3fa6884b79aea42140d00615b1294 [INFO] validating manifest of LeoTindall/rloris on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LeoTindall/rloris on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LeoTindall/rloris [INFO] finished frobbing LeoTindall/rloris [INFO] frobbed toml for LeoTindall/rloris written to work/ex/clippy-test-run/sources/stable/gh/LeoTindall/rloris/Cargo.toml [INFO] started frobbing LeoTindall/rloris [INFO] finished frobbing LeoTindall/rloris [INFO] frobbed toml for LeoTindall/rloris written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LeoTindall/rloris/Cargo.toml [INFO] crate LeoTindall/rloris has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LeoTindall/rloris against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LeoTindall/rloris:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d7911e8e9b98b5cdc3ca63d5c83f0fc77f347f804abeea628bb1f503c62766b [INFO] running `"docker" "start" "-a" "0d7911e8e9b98b5cdc3ca63d5c83f0fc77f347f804abeea628bb1f503c62766b"` [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking openssl v0.9.7 [INFO] [stderr] Checking env_logger v0.4.0 [INFO] [stderr] Checking rloris v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 131 | | if cmd_get { [INFO] [stderr] 132 | | slowloris_attack(&mut tcp_stream, timeout, cycles, finalize, false, threadn); [INFO] [stderr] 133 | | } else if cmd_post { [INFO] [stderr] 134 | | slowloris_attack(&mut tcp_stream, timeout, cycles, finalize, true, threadn); [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if cmd_get { [INFO] [stderr] 131 | slowloris_attack(&mut tcp_stream, timeout, cycles, finalize, false, threadn); [INFO] [stderr] 132 | } else if cmd_post { [INFO] [stderr] 133 | slowloris_attack(&mut tcp_stream, timeout, cycles, finalize, true, threadn); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:151:63 [INFO] [stderr] | [INFO] [stderr] 151 | handles.pop().unwrap().join().unwrap_or_else(|_| {()} ); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 131 | | if cmd_get { [INFO] [stderr] 132 | | slowloris_attack(&mut tcp_stream, timeout, cycles, finalize, false, threadn); [INFO] [stderr] 133 | | } else if cmd_post { [INFO] [stderr] 134 | | slowloris_attack(&mut tcp_stream, timeout, cycles, finalize, true, threadn); [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if cmd_get { [INFO] [stderr] 131 | slowloris_attack(&mut tcp_stream, timeout, cycles, finalize, false, threadn); [INFO] [stderr] 132 | } else if cmd_post { [INFO] [stderr] 133 | slowloris_attack(&mut tcp_stream, timeout, cycles, finalize, true, threadn); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:151:63 [INFO] [stderr] | [INFO] [stderr] 151 | handles.pop().unwrap().join().unwrap_or_else(|_| {()} ); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | domain: format!("{}", target), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `target.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:91:37 [INFO] [stderr] | [INFO] [stderr] 91 | let threads = args.flag_threads.unwrap_or(num_cpus::get()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(num_cpus::get)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | domain: format!("{}", target), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `target.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:91:37 [INFO] [stderr] | [INFO] [stderr] 91 | let threads = args.flag_threads.unwrap_or(num_cpus::get()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(num_cpus::get)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.99s [INFO] running `"docker" "inspect" "0d7911e8e9b98b5cdc3ca63d5c83f0fc77f347f804abeea628bb1f503c62766b"` [INFO] running `"docker" "rm" "-f" "0d7911e8e9b98b5cdc3ca63d5c83f0fc77f347f804abeea628bb1f503c62766b"` [INFO] [stdout] 0d7911e8e9b98b5cdc3ca63d5c83f0fc77f347f804abeea628bb1f503c62766b