[INFO] updating cached repository LeoTindall/piston-flying-square [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LeoTindall/piston-flying-square [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LeoTindall/piston-flying-square" "work/ex/clippy-test-run/sources/stable/gh/LeoTindall/piston-flying-square"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LeoTindall/piston-flying-square'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LeoTindall/piston-flying-square" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LeoTindall/piston-flying-square"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LeoTindall/piston-flying-square'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4d3d8a7980811adfdd7e5bcb30d8139deb016cda [INFO] sha for GitHub repo LeoTindall/piston-flying-square: 4d3d8a7980811adfdd7e5bcb30d8139deb016cda [INFO] validating manifest of LeoTindall/piston-flying-square on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LeoTindall/piston-flying-square on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LeoTindall/piston-flying-square [INFO] finished frobbing LeoTindall/piston-flying-square [INFO] frobbed toml for LeoTindall/piston-flying-square written to work/ex/clippy-test-run/sources/stable/gh/LeoTindall/piston-flying-square/Cargo.toml [INFO] started frobbing LeoTindall/piston-flying-square [INFO] finished frobbing LeoTindall/piston-flying-square [INFO] frobbed toml for LeoTindall/piston-flying-square written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LeoTindall/piston-flying-square/Cargo.toml [INFO] crate LeoTindall/piston-flying-square has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LeoTindall/piston-flying-square against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LeoTindall/piston-flying-square:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32232f6e54f89a47f4ac9e02b28a93ab33bc8e688e1bd7826ed6b4627263fc0e [INFO] running `"docker" "start" "-a" "32232f6e54f89a47f4ac9e02b28a93ab33bc8e688e1bd7826ed6b4627263fc0e"` [INFO] [stderr] Checking update_rate v2.0.0 [INFO] [stderr] Checking deflate v0.7.5 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num_cpus v1.3.0 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking x11-dl v2.18.3 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking wayland-sys v0.21.7 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking wayland-commons v0.21.7 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking wayland-client v0.21.7 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking wayland-protocols v0.21.7 [INFO] [stderr] Checking smithay-client-toolkit v0.4.2 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.54.0 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking piston_window v0.85.0 [INFO] [stderr] Checking piston-flying-square v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Glyphs::new(font, factory, TextureSettings::new()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Glyphs::new(font, factory, TextureSettings::new()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return Glyphs::new(font, factory, TextureSettings::new()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Glyphs::new(font, factory, TextureSettings::new()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let ref font = assets.join("Anonymous.ttf"); [INFO] [stderr] | ----^^^^^^^^-------------------------------- help: try: `let font = &assets.join("Anonymous.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let ref font = assets.join("Anonymous.ttf"); [INFO] [stderr] | ----^^^^^^^^-------------------------------- help: try: `let font = &assets.join("Anonymous.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 51.49s [INFO] running `"docker" "inspect" "32232f6e54f89a47f4ac9e02b28a93ab33bc8e688e1bd7826ed6b4627263fc0e"` [INFO] running `"docker" "rm" "-f" "32232f6e54f89a47f4ac9e02b28a93ab33bc8e688e1bd7826ed6b4627263fc0e"` [INFO] [stdout] 32232f6e54f89a47f4ac9e02b28a93ab33bc8e688e1bd7826ed6b4627263fc0e