[INFO] updating cached repository LeoTindall/evolve-sbrain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LeoTindall/evolve-sbrain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LeoTindall/evolve-sbrain" "work/ex/clippy-test-run/sources/stable/gh/LeoTindall/evolve-sbrain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LeoTindall/evolve-sbrain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LeoTindall/evolve-sbrain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LeoTindall/evolve-sbrain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LeoTindall/evolve-sbrain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7bda179d477a6210c201772481fc2ee3132970ba [INFO] sha for GitHub repo LeoTindall/evolve-sbrain: 7bda179d477a6210c201772481fc2ee3132970ba [INFO] validating manifest of LeoTindall/evolve-sbrain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LeoTindall/evolve-sbrain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LeoTindall/evolve-sbrain [INFO] finished frobbing LeoTindall/evolve-sbrain [INFO] frobbed toml for LeoTindall/evolve-sbrain written to work/ex/clippy-test-run/sources/stable/gh/LeoTindall/evolve-sbrain/Cargo.toml [INFO] started frobbing LeoTindall/evolve-sbrain [INFO] finished frobbing LeoTindall/evolve-sbrain [INFO] frobbed toml for LeoTindall/evolve-sbrain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LeoTindall/evolve-sbrain/Cargo.toml [INFO] crate LeoTindall/evolve-sbrain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LeoTindall/evolve-sbrain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LeoTindall/evolve-sbrain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a63d5d185b4c4c46d01e54e7ceb754b15eb8818f5e7c99ffbc20de43411aceb [INFO] running `"docker" "start" "-a" "1a63d5d185b4c4c46d01e54e7ceb754b15eb8818f5e7c99ffbc20de43411aceb"` [INFO] [stderr] Checking sbrain v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.2 [INFO] [stderr] Checking evolve-sbrain v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | ProgramWithCost {cost: cost, program: program} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cost` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:14:38 [INFO] [stderr] | [INFO] [stderr] 14 | ProgramWithCost {cost: cost, program: program} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | ProgramWithCost {cost: cost, program: program} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cost` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:14:38 [INFO] [stderr] | [INFO] [stderr] 14 | ProgramWithCost {cost: cost, program: program} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cost.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | fn cost_program(program: &Program, cfg: &Configuration) -> u64 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cost.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | fn cost_single_target(program: &Program, input: &[u32], target: &[u32]) -> u64 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/cost.rs:30:53 [INFO] [stderr] | [INFO] [stderr] 30 | for (a, b) in res.output.into_iter().zip(target.into_iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cost.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let max_value = max(a, *b) as Cost; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(max(a, *b))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cost.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | let min_value = min(a, *b) as Cost; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(min(a, *b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cost.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | fn cost_program(program: &Program, cfg: &Configuration) -> u64 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cost.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | fn cost_single_target(program: &Program, input: &[u32], target: &[u32]) -> u64 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/cost.rs:30:53 [INFO] [stderr] | [INFO] [stderr] 30 | for (a, b) in res.output.into_iter().zip(target.into_iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cost.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let max_value = max(a, *b) as Cost; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(max(a, *b))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cost.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | let min_value = min(a, *b) as Cost; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(min(a, *b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.82s [INFO] running `"docker" "inspect" "1a63d5d185b4c4c46d01e54e7ceb754b15eb8818f5e7c99ffbc20de43411aceb"` [INFO] running `"docker" "rm" "-f" "1a63d5d185b4c4c46d01e54e7ceb754b15eb8818f5e7c99ffbc20de43411aceb"` [INFO] [stdout] 1a63d5d185b4c4c46d01e54e7ceb754b15eb8818f5e7c99ffbc20de43411aceb