[INFO] updating cached repository LazyShpee/bf-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LazyShpee/bf-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LazyShpee/bf-rust" "work/ex/clippy-test-run/sources/stable/gh/LazyShpee/bf-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LazyShpee/bf-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LazyShpee/bf-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LazyShpee/bf-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LazyShpee/bf-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f878799d76b8ff6f2786ffcd904847d244a125a [INFO] sha for GitHub repo LazyShpee/bf-rust: 7f878799d76b8ff6f2786ffcd904847d244a125a [INFO] validating manifest of LazyShpee/bf-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LazyShpee/bf-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LazyShpee/bf-rust [INFO] finished frobbing LazyShpee/bf-rust [INFO] frobbed toml for LazyShpee/bf-rust written to work/ex/clippy-test-run/sources/stable/gh/LazyShpee/bf-rust/Cargo.toml [INFO] started frobbing LazyShpee/bf-rust [INFO] finished frobbing LazyShpee/bf-rust [INFO] frobbed toml for LazyShpee/bf-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LazyShpee/bf-rust/Cargo.toml [INFO] crate LazyShpee/bf-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LazyShpee/bf-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LazyShpee/bf-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3d9d010e29a2d5e9f960502df258e2b0fe07aa33ef180b959badf7cc9842a81c [INFO] running `"docker" "start" "-a" "3d9d010e29a2d5e9f960502df258e2b0fe07aa33ef180b959badf7cc9842a81c"` [INFO] [stderr] Checking bf-interpreter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/interpreter.rs:113:107 [INFO] [stderr] | [INFO] [stderr] 113 | '.' => { stdout().write(&[self.tape[self.data_ptr]]).expect("Could not write to stdout"); () }, [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/interpreter.rs:69:155 [INFO] [stderr] | [INFO] [stderr] 69 | if options.verbose { println!("Created VM type {} with code {}", vm.extend, String::from_utf8(vm.tape[vm.code_start..vm.data_start - 1].to_vec()).unwrap_or("INVALID CODE".to_string())) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "INVALID CODE".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/interpreter.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | '.' => { stdout().write(&[self.tape[self.data_ptr]]).expect("Could not write to stdout"); () }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/interpreter.rs:117:21 [INFO] [stderr] | [INFO] [stderr] 117 | stdin().read(&mut buffer[..]).expect("Could not read from stdin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bf-interpreter`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/interpreter.rs:113:107 [INFO] [stderr] | [INFO] [stderr] 113 | '.' => { stdout().write(&[self.tape[self.data_ptr]]).expect("Could not write to stdout"); () }, [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/interpreter.rs:69:155 [INFO] [stderr] | [INFO] [stderr] 69 | if options.verbose { println!("Created VM type {} with code {}", vm.extend, String::from_utf8(vm.tape[vm.code_start..vm.data_start - 1].to_vec()).unwrap_or("INVALID CODE".to_string())) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "INVALID CODE".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/interpreter.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | '.' => { stdout().write(&[self.tape[self.data_ptr]]).expect("Could not write to stdout"); () }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/interpreter.rs:117:21 [INFO] [stderr] | [INFO] [stderr] 117 | stdin().read(&mut buffer[..]).expect("Could not read from stdin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bf-interpreter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3d9d010e29a2d5e9f960502df258e2b0fe07aa33ef180b959badf7cc9842a81c"` [INFO] running `"docker" "rm" "-f" "3d9d010e29a2d5e9f960502df258e2b0fe07aa33ef180b959badf7cc9842a81c"` [INFO] [stdout] 3d9d010e29a2d5e9f960502df258e2b0fe07aa33ef180b959badf7cc9842a81c