[INFO] updating cached repository Larusso/github-rate-limit-monitor.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Larusso/github-rate-limit-monitor.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Larusso/github-rate-limit-monitor.rs" "work/ex/clippy-test-run/sources/stable/gh/Larusso/github-rate-limit-monitor.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Larusso/github-rate-limit-monitor.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Larusso/github-rate-limit-monitor.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Larusso/github-rate-limit-monitor.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Larusso/github-rate-limit-monitor.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 933320d79bbfdacd47e614c3ea3586bcf97c095a [INFO] sha for GitHub repo Larusso/github-rate-limit-monitor.rs: 933320d79bbfdacd47e614c3ea3586bcf97c095a [INFO] validating manifest of Larusso/github-rate-limit-monitor.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Larusso/github-rate-limit-monitor.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Larusso/github-rate-limit-monitor.rs [INFO] finished frobbing Larusso/github-rate-limit-monitor.rs [INFO] frobbed toml for Larusso/github-rate-limit-monitor.rs written to work/ex/clippy-test-run/sources/stable/gh/Larusso/github-rate-limit-monitor.rs/Cargo.toml [INFO] started frobbing Larusso/github-rate-limit-monitor.rs [INFO] finished frobbing Larusso/github-rate-limit-monitor.rs [INFO] frobbed toml for Larusso/github-rate-limit-monitor.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Larusso/github-rate-limit-monitor.rs/Cargo.toml [INFO] crate Larusso/github-rate-limit-monitor.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Larusso/github-rate-limit-monitor.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Larusso/github-rate-limit-monitor.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b24a4e3093d7c984c0d255a55cb3a6a96a3435b7518a7b6b0313c7faafe9c46b [INFO] running `"docker" "start" "-a" "b24a4e3093d7c984c0d255a55cb3a6a96a3435b7518a7b6b0313c7faafe9c46b"` [INFO] [stderr] Checking rustc-demangle v0.1.6 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Compiling openssl-sys v0.9.25 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking parking_lot_core v0.2.11 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking hyper v0.11.18 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking parking_lot v0.5.3 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking grlm v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | login: login, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `login` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | password: password [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:57:11 [INFO] [stderr] | [INFO] [stderr] 57 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grlm.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | bar: bar, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grlm.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grlm.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | resource: resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | login: login, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `login` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | password: password [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:57:11 [INFO] [stderr] | [INFO] [stderr] 57 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grlm.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | bar: bar, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grlm.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grlm.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | resource: resource, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cli.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | tty [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cli.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | let tty = unsafe { libc::isatty(libc::STDOUT_FILENO as i32) } != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cli.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | tty [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cli.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | let tty = unsafe { libc::isatty(libc::STDOUT_FILENO as i32) } != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/github.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / if let &AuthType::Token(ref token) = auth { [INFO] [stderr] 70 | | req.headers_mut().set(Authorization(Bearer {token: token.to_owned()})); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | if let AuthType::Token(ref token) = *auth { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/github.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / if let &AuthType::Login {ref login, ref password} = auth { [INFO] [stderr] 74 | | req.headers_mut().set(Authorization(Basic { username: login.to_owned(), password: Some(password.to_owned())})); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 73 | if let AuthType::Login {ref login, ref password} = *auth { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &Resource::Core => write!(f, "core"), [INFO] [stderr] 25 | | &Resource::Search => write!(f, "search"), [INFO] [stderr] 26 | | &Resource::Graphql => write!(f, "graphql"), [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | Resource::Core => write!(f, "core"), [INFO] [stderr] 25 | Resource::Search => write!(f, "search"), [INFO] [stderr] 26 | Resource::Graphql => write!(f, "graphql"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/grlm.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let bar = ProgressBar::new(initial_length); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/grlm.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | let ref bar = self.state.read().bar; [INFO] [stderr] | ----^^^^^^^------------------------- help: try: `let bar = &self.state.read().bar;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/grlm.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | let ref bar = self.state.read().bar; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/github.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / if let &AuthType::Token(ref token) = auth { [INFO] [stderr] 70 | | req.headers_mut().set(Authorization(Bearer {token: token.to_owned()})); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | if let AuthType::Token(ref token) = *auth { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/github.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / if let &AuthType::Login {ref login, ref password} = auth { [INFO] [stderr] 74 | | req.headers_mut().set(Authorization(Basic { username: login.to_owned(), password: Some(password.to_owned())})); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 73 | if let AuthType::Login {ref login, ref password} = *auth { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &Resource::Core => write!(f, "core"), [INFO] [stderr] 25 | | &Resource::Search => write!(f, "search"), [INFO] [stderr] 26 | | &Resource::Graphql => write!(f, "graphql"), [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | Resource::Core => write!(f, "core"), [INFO] [stderr] 25 | Resource::Search => write!(f, "search"), [INFO] [stderr] 26 | Resource::Graphql => write!(f, "graphql"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/grlm.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let bar = ProgressBar::new(initial_length); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/grlm.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | let ref bar = self.state.read().bar; [INFO] [stderr] | ----^^^^^^^------------------------- help: try: `let bar = &self.state.read().bar;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/grlm.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | let ref bar = self.state.read().bar; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/main.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/main.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.43s [INFO] running `"docker" "inspect" "b24a4e3093d7c984c0d255a55cb3a6a96a3435b7518a7b6b0313c7faafe9c46b"` [INFO] running `"docker" "rm" "-f" "b24a4e3093d7c984c0d255a55cb3a6a96a3435b7518a7b6b0313c7faafe9c46b"` [INFO] [stdout] b24a4e3093d7c984c0d255a55cb3a6a96a3435b7518a7b6b0313c7faafe9c46b