[INFO] updating cached repository LarryLo/spark_submit_helper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LarryLo/spark_submit_helper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LarryLo/spark_submit_helper" "work/ex/clippy-test-run/sources/stable/gh/LarryLo/spark_submit_helper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LarryLo/spark_submit_helper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LarryLo/spark_submit_helper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LarryLo/spark_submit_helper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LarryLo/spark_submit_helper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c26d51ba4bd01bfe393c3c222309c69d26a11bb9 [INFO] sha for GitHub repo LarryLo/spark_submit_helper: c26d51ba4bd01bfe393c3c222309c69d26a11bb9 [INFO] validating manifest of LarryLo/spark_submit_helper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LarryLo/spark_submit_helper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LarryLo/spark_submit_helper [INFO] finished frobbing LarryLo/spark_submit_helper [INFO] frobbed toml for LarryLo/spark_submit_helper written to work/ex/clippy-test-run/sources/stable/gh/LarryLo/spark_submit_helper/Cargo.toml [INFO] started frobbing LarryLo/spark_submit_helper [INFO] finished frobbing LarryLo/spark_submit_helper [INFO] frobbed toml for LarryLo/spark_submit_helper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LarryLo/spark_submit_helper/Cargo.toml [INFO] crate LarryLo/spark_submit_helper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LarryLo/spark_submit_helper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LarryLo/spark_submit_helper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 27b51bd375966b45aff9877651ced5edd8055e8e1405c37206cac8a7184a88fb [INFO] running `"docker" "start" "-a" "27b51bd375966b45aff9877651ced5edd8055e8e1405c37206cac8a7184a88fb"` [INFO] [stderr] Checking hyper v0.10.12 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking spark_submit_helper v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/lang.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | Python { user: user, subject: subject} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/lang.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | Python { user: user, subject: subject} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/lang.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | Scala { user: user, subject: subject} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/lang.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | Scala { user: user, subject: subject} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | ResponseMetrics { total: total, error: error, success: total - error } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | ResponseMetrics { total: total, error: error, success: total - error } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | ResponseMetrics { total: total, error: 0, success: total} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:49:31 [INFO] [stderr] | [INFO] [stderr] 49 | ResponseMetrics { total: total, error: fail + error, success: success } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:49:66 [INFO] [stderr] | [INFO] [stderr] 49 | ResponseMetrics { total: total, error: fail + error, success: success } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `success` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/lang.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | Python { user: user, subject: subject} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/lang.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | Python { user: user, subject: subject} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/lang.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | Scala { user: user, subject: subject} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `user` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/lang.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | Scala { user: user, subject: subject} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | ResponseMetrics { total: total, error: error, success: total - error } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | ResponseMetrics { total: total, error: error, success: total - error } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | ResponseMetrics { total: total, error: 0, success: total} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:49:31 [INFO] [stderr] | [INFO] [stderr] 49 | ResponseMetrics { total: total, error: fail + error, success: success } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lang_test/parser.rs:49:66 [INFO] [stderr] | [INFO] [stderr] 49 | ResponseMetrics { total: total, error: fail + error, success: success } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `success` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/lang_test/lang.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/user/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mkdir` [INFO] [stderr] --> src/user/mod.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let mkdir = [INFO] [stderr] | ^^^^^ help: consider using `_mkdir` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `version` [INFO] [stderr] --> src/lang_test/lang.rs:64:40 [INFO] [stderr] | [INFO] [stderr] 64 | fn run_test(&self, solution: &str, version: i8) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_version` instead [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/lang_test/lang.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/user/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lang_test/lang.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | echo(solution, &Path::new(&format!("{}/solution.py", &to))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lang_test/lang.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / Command::new(&cmd) [INFO] [stderr] 49 | | .arg(&to) [INFO] [stderr] 50 | | .output() [INFO] [stderr] 51 | | .ok() [INFO] [stderr] 52 | | .expect("cat error to start"); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lang_test/lang.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | echo(solution, &Path::new(&format!("{}/src/main/scala/org/sparktw/codefight/Solution.scala", &to))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lang_test/lang.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | / Command::new("sbt") [INFO] [stderr] 76 | | .current_dir(&path) [INFO] [stderr] 77 | | .arg("test") [INFO] [stderr] 78 | | .output() [INFO] [stderr] 79 | | .ok() [INFO] [stderr] 80 | | .expect("cat error to start"); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/user/mod.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / Command::new("mkdir") [INFO] [stderr] 10 | | .arg("-p") [INFO] [stderr] 11 | | .arg(©_to) [INFO] [stderr] 12 | | .output() [INFO] [stderr] 13 | | .ok() [INFO] [stderr] 14 | | .expect("cat error to start"); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/user/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / Command::new("cp") [INFO] [stderr] 18 | | .arg("-r") [INFO] [stderr] 19 | | .arg("-f") [INFO] [stderr] 20 | | .arg(©_from) [INFO] [stderr] ... | [INFO] [stderr] 23 | | .ok() [INFO] [stderr] 24 | | .expect("cat error to start"); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:72:109 [INFO] [stderr] | [INFO] [stderr] 72 | 0 => SubjectTestResponsePayload { response_code: 0, response_message: "pass".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.user.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:72:145 [INFO] [stderr] | [INFO] [stderr] 72 | 0 => SubjectTestResponsePayload { response_code: 0, response_message: "pass".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.subject.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:72:185 [INFO] [stderr] | [INFO] [stderr] 72 | 0 => SubjectTestResponsePayload { response_code: 0, response_message: "pass".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.language.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:74:119 [INFO] [stderr] | [INFO] [stderr] 74 | 127 => SubjectTestResponsePayload { response_code: 1, response_message: "syntax error".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.user.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:74:155 [INFO] [stderr] | [INFO] [stderr] 74 | 127 => SubjectTestResponsePayload { response_code: 1, response_message: "syntax error".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.subject.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:74:195 [INFO] [stderr] | [INFO] [stderr] 74 | 127 => SubjectTestResponsePayload { response_code: 1, response_message: "syntax error".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.language.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:76:109 [INFO] [stderr] | [INFO] [stderr] 76 | _ => SubjectTestResponsePayload { response_code: 2, response_message: "fail".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.user.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:76:145 [INFO] [stderr] | [INFO] [stderr] 76 | _ => SubjectTestResponsePayload { response_code: 2, response_message: "fail".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.subject.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:76:185 [INFO] [stderr] | [INFO] [stderr] 76 | _ => SubjectTestResponsePayload { response_code: 2, response_message: "fail".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.language.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mkdir` [INFO] [stderr] --> src/user/mod.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let mkdir = [INFO] [stderr] | ^^^^^ help: consider using `_mkdir` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `version` [INFO] [stderr] --> src/lang_test/lang.rs:64:40 [INFO] [stderr] | [INFO] [stderr] 64 | fn run_test(&self, solution: &str, version: i8) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_version` instead [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lang_test/lang.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | echo(solution, &Path::new(&format!("{}/solution.py", &to))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lang_test/lang.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / Command::new(&cmd) [INFO] [stderr] 49 | | .arg(&to) [INFO] [stderr] 50 | | .output() [INFO] [stderr] 51 | | .ok() [INFO] [stderr] 52 | | .expect("cat error to start"); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lang_test/lang.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | echo(solution, &Path::new(&format!("{}/src/main/scala/org/sparktw/codefight/Solution.scala", &to))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lang_test/lang.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | / Command::new("sbt") [INFO] [stderr] 76 | | .current_dir(&path) [INFO] [stderr] 77 | | .arg("test") [INFO] [stderr] 78 | | .output() [INFO] [stderr] 79 | | .ok() [INFO] [stderr] 80 | | .expect("cat error to start"); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/user/mod.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / Command::new("mkdir") [INFO] [stderr] 10 | | .arg("-p") [INFO] [stderr] 11 | | .arg(©_to) [INFO] [stderr] 12 | | .output() [INFO] [stderr] 13 | | .ok() [INFO] [stderr] 14 | | .expect("cat error to start"); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/user/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / Command::new("cp") [INFO] [stderr] 18 | | .arg("-r") [INFO] [stderr] 19 | | .arg("-f") [INFO] [stderr] 20 | | .arg(©_from) [INFO] [stderr] ... | [INFO] [stderr] 23 | | .ok() [INFO] [stderr] 24 | | .expect("cat error to start"); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:72:109 [INFO] [stderr] | [INFO] [stderr] 72 | 0 => SubjectTestResponsePayload { response_code: 0, response_message: "pass".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.user.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:72:145 [INFO] [stderr] | [INFO] [stderr] 72 | 0 => SubjectTestResponsePayload { response_code: 0, response_message: "pass".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.subject.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:72:185 [INFO] [stderr] | [INFO] [stderr] 72 | 0 => SubjectTestResponsePayload { response_code: 0, response_message: "pass".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.language.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:74:119 [INFO] [stderr] | [INFO] [stderr] 74 | 127 => SubjectTestResponsePayload { response_code: 1, response_message: "syntax error".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.user.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:74:155 [INFO] [stderr] | [INFO] [stderr] 74 | 127 => SubjectTestResponsePayload { response_code: 1, response_message: "syntax error".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.subject.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:74:195 [INFO] [stderr] | [INFO] [stderr] 74 | 127 => SubjectTestResponsePayload { response_code: 1, response_message: "syntax error".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.language.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:76:109 [INFO] [stderr] | [INFO] [stderr] 76 | _ => SubjectTestResponsePayload { response_code: 2, response_message: "fail".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.user.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:76:145 [INFO] [stderr] | [INFO] [stderr] 76 | _ => SubjectTestResponsePayload { response_code: 2, response_message: "fail".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.subject.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:76:185 [INFO] [stderr] | [INFO] [stderr] 76 | _ => SubjectTestResponsePayload { response_code: 2, response_message: "fail".to_string(), user: format!("{}", &body.user), subject: format!("{}", &body.subject), language: format!("{}", &body.language), metrics: Some(response_msg), timestamp: now_utc } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&body.language.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.23s [INFO] running `"docker" "inspect" "27b51bd375966b45aff9877651ced5edd8055e8e1405c37206cac8a7184a88fb"` [INFO] running `"docker" "rm" "-f" "27b51bd375966b45aff9877651ced5edd8055e8e1405c37206cac8a7184a88fb"` [INFO] [stdout] 27b51bd375966b45aff9877651ced5edd8055e8e1405c37206cac8a7184a88fb