[INFO] updating cached repository LachlanHogan/rust-opengl-illustrator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LachlanHogan/rust-opengl-illustrator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LachlanHogan/rust-opengl-illustrator" "work/ex/clippy-test-run/sources/stable/gh/LachlanHogan/rust-opengl-illustrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LachlanHogan/rust-opengl-illustrator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LachlanHogan/rust-opengl-illustrator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LachlanHogan/rust-opengl-illustrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LachlanHogan/rust-opengl-illustrator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cf56601177971c7ff065eeb80df81fc533cc077a [INFO] sha for GitHub repo LachlanHogan/rust-opengl-illustrator: cf56601177971c7ff065eeb80df81fc533cc077a [INFO] validating manifest of LachlanHogan/rust-opengl-illustrator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LachlanHogan/rust-opengl-illustrator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LachlanHogan/rust-opengl-illustrator [INFO] finished frobbing LachlanHogan/rust-opengl-illustrator [INFO] frobbed toml for LachlanHogan/rust-opengl-illustrator written to work/ex/clippy-test-run/sources/stable/gh/LachlanHogan/rust-opengl-illustrator/Cargo.toml [INFO] started frobbing LachlanHogan/rust-opengl-illustrator [INFO] finished frobbing LachlanHogan/rust-opengl-illustrator [INFO] frobbed toml for LachlanHogan/rust-opengl-illustrator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LachlanHogan/rust-opengl-illustrator/Cargo.toml [INFO] crate LachlanHogan/rust-opengl-illustrator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LachlanHogan/rust-opengl-illustrator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LachlanHogan/rust-opengl-illustrator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0724fcfaeb44fc16938fd3b5e1fff1ce810af3283d8d0e73b64dec9a47b3faaa [INFO] running `"docker" "start" "-a" "0724fcfaeb44fc16938fd3b5e1fff1ce810af3283d8d0e73b64dec9a47b3faaa"` [INFO] [stderr] Compiling x11-dl v2.18.1 [INFO] [stderr] Compiling wayland-scanner v0.20.11 [INFO] [stderr] Checking smallvec v0.6.3 [INFO] [stderr] Checking tempfile v3.0.3 [INFO] [stderr] Checking wayland-sys v0.20.11 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking wayland-commons v0.20.11 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Compiling wayland-client v0.20.11 [INFO] [stderr] Compiling wayland-protocols v0.20.11 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Checking glium v0.22.0 [INFO] [stderr] Checking rust-opengl-illustrator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:46 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:62 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `top_left_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:100 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:114 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hover_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:140 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `quad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:152 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_image.rs:52:44 [INFO] [stderr] | [INFO] [stderr] 52 | GlImage { file: file_name.clone(), opengl_texture: opengl_texture, vertex_buffer: vertex_buffer, index_buffer: index_buffer, program: program } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `opengl_texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_image.rs:52:76 [INFO] [stderr] | [INFO] [stderr] 52 | GlImage { file: file_name.clone(), opengl_texture: opengl_texture, vertex_buffer: vertex_buffer, index_buffer: index_buffer, program: program } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_image.rs:52:106 [INFO] [stderr] | [INFO] [stderr] 52 | GlImage { file: file_name.clone(), opengl_texture: opengl_texture, vertex_buffer: vertex_buffer, index_buffer: index_buffer, program: program } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_image.rs:52:134 [INFO] [stderr] | [INFO] [stderr] 52 | GlImage { file: file_name.clone(), opengl_texture: opengl_texture, vertex_buffer: vertex_buffer, index_buffer: index_buffer, program: program } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:46 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:62 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `top_left_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:100 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:114 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hover_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:140 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `quad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/button.rs:42:152 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Button { width: width, height: height, top_left_position: top_left_position, color: color, hover_color: hover_color, quad: quad, image: image }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_image.rs:52:44 [INFO] [stderr] | [INFO] [stderr] 52 | GlImage { file: file_name.clone(), opengl_texture: opengl_texture, vertex_buffer: vertex_buffer, index_buffer: index_buffer, program: program } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `opengl_texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_image.rs:52:76 [INFO] [stderr] | [INFO] [stderr] 52 | GlImage { file: file_name.clone(), opengl_texture: opengl_texture, vertex_buffer: vertex_buffer, index_buffer: index_buffer, program: program } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_image.rs:52:106 [INFO] [stderr] | [INFO] [stderr] 52 | GlImage { file: file_name.clone(), opengl_texture: opengl_texture, vertex_buffer: vertex_buffer, index_buffer: index_buffer, program: program } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gl_image.rs:52:134 [INFO] [stderr] | [INFO] [stderr] 52 | GlImage { file: file_name.clone(), opengl_texture: opengl_texture, vertex_buffer: vertex_buffer, index_buffer: index_buffer, program: program } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:75:55 [INFO] [stderr] | [INFO] [stderr] 75 | glutin::WindowEvent::MouseInput { device_id: _, state, button, .. } => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `MouseInput { state, button, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:97:56 [INFO] [stderr] | [INFO] [stderr] 97 | glutin::WindowEvent::CursorMoved { device_id: _, position, .. } => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CursorMoved { position, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | since_the_epoch.as_secs() * 1000 + since_the_epoch.subsec_nanos() as u64 / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/button.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / let mut uniforms = uniform! { [INFO] [stderr] 59 | | color: self.color [INFO] [stderr] 60 | | }; [INFO] [stderr] 61 | | if latest_mouse_pos.position[0] > self.quad.x0 && latest_mouse_pos.position[0] < self.quad.x1 && latest_mouse_pos.position[1] < self.quad.y0 && latest_mouse_pos.position[1] > self.quad.y1 { [INFO] [stderr] ... | [INFO] [stderr] 64 | | }; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 58 | let uniforms = if latest_mouse_pos.position[0] > self.quad.x0 && latest_mouse_pos.position[0] < self.quad.x1 && latest_mouse_pos.position[1] < self.quad.y0 && latest_mouse_pos.position[1] > self.quad.y1 { $ crate :: uniforms :: UniformsStorage :: new ( [INFO] [stderr] 59 | stringify ! ( $ field ) , $ value ) } else { $ crate :: uniforms :: UniformsStorage :: new ( [INFO] [stderr] 60 | stringify ! ( $ field ) , $ value ) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / match event { [INFO] [stderr] 71 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 72 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 73 | | closed = true [INFO] [stderr] ... | [INFO] [stderr] 102 | | _ => (), [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 71 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 72 | closed = true [INFO] [stderr] 73 | }, [INFO] [stderr] 74 | glutin::WindowEvent::MouseInput { device_id: _, state, button, .. } => { [INFO] [stderr] 75 | if button == glutin::MouseButton::Left { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | / match draw_state { [INFO] [stderr] 88 | | DrawState::StartNode => { [INFO] [stderr] 89 | | shape = vec![latest_mouse_pos]; [INFO] [stderr] 90 | | draw_state = DrawState::PreviewNode; [INFO] [stderr] 91 | | }, [INFO] [stderr] 92 | | _ => () [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let DrawState::StartNode = draw_state { [INFO] [stderr] 88 | shape = vec![latest_mouse_pos]; [INFO] [stderr] 89 | draw_state = DrawState::PreviewNode; [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / match draw_state { [INFO] [stderr] 109 | | DrawState::PreviewNode => { [INFO] [stderr] 110 | | if shape.iter().count() == 1 { [INFO] [stderr] 111 | | shape.push(latest_mouse_pos); [INFO] [stderr] ... | [INFO] [stderr] 117 | | _ => () [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | if let DrawState::PreviewNode = draw_state { [INFO] [stderr] 109 | if shape.iter().count() == 1 { [INFO] [stderr] 110 | shape.push(latest_mouse_pos); [INFO] [stderr] 111 | } else if shape.iter().count() == 2 { [INFO] [stderr] 112 | shape[1] = latest_mouse_pos; [INFO] [stderr] 113 | lines_list.push(Line { start: shape[0], end: shape[1] }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:75:55 [INFO] [stderr] | [INFO] [stderr] 75 | glutin::WindowEvent::MouseInput { device_id: _, state, button, .. } => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `MouseInput { state, button, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/main.rs:97:56 [INFO] [stderr] | [INFO] [stderr] 97 | glutin::WindowEvent::CursorMoved { device_id: _, position, .. } => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CursorMoved { position, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | since_the_epoch.as_secs() * 1000 + since_the_epoch.subsec_nanos() as u64 / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/button.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / let mut uniforms = uniform! { [INFO] [stderr] 59 | | color: self.color [INFO] [stderr] 60 | | }; [INFO] [stderr] 61 | | if latest_mouse_pos.position[0] > self.quad.x0 && latest_mouse_pos.position[0] < self.quad.x1 && latest_mouse_pos.position[1] < self.quad.y0 && latest_mouse_pos.position[1] > self.quad.y1 { [INFO] [stderr] ... | [INFO] [stderr] 64 | | }; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 58 | let uniforms = if latest_mouse_pos.position[0] > self.quad.x0 && latest_mouse_pos.position[0] < self.quad.x1 && latest_mouse_pos.position[1] < self.quad.y0 && latest_mouse_pos.position[1] > self.quad.y1 { $ crate :: uniforms :: UniformsStorage :: new ( [INFO] [stderr] 59 | stringify ! ( $ field ) , $ value ) } else { $ crate :: uniforms :: UniformsStorage :: new ( [INFO] [stderr] 60 | stringify ! ( $ field ) , $ value ) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / match event { [INFO] [stderr] 71 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 72 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 73 | | closed = true [INFO] [stderr] ... | [INFO] [stderr] 102 | | _ => (), [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 71 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 72 | closed = true [INFO] [stderr] 73 | }, [INFO] [stderr] 74 | glutin::WindowEvent::MouseInput { device_id: _, state, button, .. } => { [INFO] [stderr] 75 | if button == glutin::MouseButton::Left { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | / match draw_state { [INFO] [stderr] 88 | | DrawState::StartNode => { [INFO] [stderr] 89 | | shape = vec![latest_mouse_pos]; [INFO] [stderr] 90 | | draw_state = DrawState::PreviewNode; [INFO] [stderr] 91 | | }, [INFO] [stderr] 92 | | _ => () [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let DrawState::StartNode = draw_state { [INFO] [stderr] 88 | shape = vec![latest_mouse_pos]; [INFO] [stderr] 89 | draw_state = DrawState::PreviewNode; [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / match draw_state { [INFO] [stderr] 109 | | DrawState::PreviewNode => { [INFO] [stderr] 110 | | if shape.iter().count() == 1 { [INFO] [stderr] 111 | | shape.push(latest_mouse_pos); [INFO] [stderr] ... | [INFO] [stderr] 117 | | _ => () [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | if let DrawState::PreviewNode = draw_state { [INFO] [stderr] 109 | if shape.iter().count() == 1 { [INFO] [stderr] 110 | shape.push(latest_mouse_pos); [INFO] [stderr] 111 | } else if shape.iter().count() == 2 { [INFO] [stderr] 112 | shape[1] = latest_mouse_pos; [INFO] [stderr] 113 | lines_list.push(Line { start: shape[0], end: shape[1] }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.44s [INFO] running `"docker" "inspect" "0724fcfaeb44fc16938fd3b5e1fff1ce810af3283d8d0e73b64dec9a47b3faaa"` [INFO] running `"docker" "rm" "-f" "0724fcfaeb44fc16938fd3b5e1fff1ce810af3283d8d0e73b64dec9a47b3faaa"` [INFO] [stdout] 0724fcfaeb44fc16938fd3b5e1fff1ce810af3283d8d0e73b64dec9a47b3faaa