[INFO] updating cached repository LachlanHogan/chat-app-management [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LachlanHogan/chat-app-management [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LachlanHogan/chat-app-management" "work/ex/clippy-test-run/sources/stable/gh/LachlanHogan/chat-app-management"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LachlanHogan/chat-app-management'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LachlanHogan/chat-app-management" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LachlanHogan/chat-app-management"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LachlanHogan/chat-app-management'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e3f25f8ab9d2d1d22d5d871f84a5649461ec6611 [INFO] sha for GitHub repo LachlanHogan/chat-app-management: e3f25f8ab9d2d1d22d5d871f84a5649461ec6611 [INFO] validating manifest of LachlanHogan/chat-app-management on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LachlanHogan/chat-app-management on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LachlanHogan/chat-app-management [INFO] finished frobbing LachlanHogan/chat-app-management [INFO] frobbed toml for LachlanHogan/chat-app-management written to work/ex/clippy-test-run/sources/stable/gh/LachlanHogan/chat-app-management/Cargo.toml [INFO] started frobbing LachlanHogan/chat-app-management [INFO] finished frobbing LachlanHogan/chat-app-management [INFO] frobbed toml for LachlanHogan/chat-app-management written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LachlanHogan/chat-app-management/Cargo.toml [INFO] crate LachlanHogan/chat-app-management has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LachlanHogan/chat-app-management against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LachlanHogan/chat-app-management:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f44a208e0475cd618e319a2d33d5e6f468394e924e5a7b767808717b366f0c3 [INFO] running `"docker" "start" "-a" "1f44a208e0475cd618e319a2d33d5e6f468394e924e5a7b767808717b366f0c3"` [INFO] [stderr] Checking uuid v0.6.3 [INFO] [stderr] Checking mustache v0.8.2 [INFO] [stderr] Compiling syn v0.12.15 [INFO] [stderr] Checking dotenv v0.9.0 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking nickel v0.10.1 [INFO] [stderr] Compiling diesel_derives v1.2.0 [INFO] [stderr] Checking diesel v1.2.2 [INFO] [stderr] Checking chat-app-management v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `id` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `user_id` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `username` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `User` in this scope [INFO] [stderr] --> src/models.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Queryable, Serialize, Deserialize)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `users` in this scope [INFO] [stderr] --> src/models.rs:10:10 [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Insertable)] [INFO] [stderr] | ^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NewUser` in this scope [INFO] [stderr] --> src/models.rs:10:10 [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Insertable)] [INFO] [stderr] | ^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/user_management.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | .expect(&format!("Error connecting to {}", database_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", database_url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `id` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `user_id` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `username` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `User` in this scope [INFO] [stderr] --> src/models.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Queryable, Serialize, Deserialize)] [INFO] [stderr] | ^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `users` in this scope [INFO] [stderr] --> src/models.rs:10:10 [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Insertable)] [INFO] [stderr] | ^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `NewUser` in this scope [INFO] [stderr] --> src/models.rs:10:10 [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Insertable)] [INFO] [stderr] | ^^^^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let ref connection = get_database_connection(); [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------- help: try: `let connection = &get_database_connection();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | let ref connection = get_database_connection(); [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------- help: try: `let connection = &get_database_connection();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/user_management.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn add_user(username_string: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let ref connection = get_database_connection(); [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------- help: try: `let connection = &get_database_connection();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let ref uuid = Uuid::new_v4().simple().to_string(); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let uuid = &Uuid::new_v4().simple().to_string();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let ref connection = get_database_connection(); [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------- help: try: `let connection = &get_database_connection();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | format!("{}", user_management::get_other_users(id_string).to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `user_management::get_other_users(id_string).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | let mut res = format!(""); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/user_management.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | .expect(&format!("Error connecting to {}", database_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", database_url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let ref connection = get_database_connection(); [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------- help: try: `let connection = &get_database_connection();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | let ref connection = get_database_connection(); [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------- help: try: `let connection = &get_database_connection();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/user_management.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn add_user(username_string: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let ref connection = get_database_connection(); [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------- help: try: `let connection = &get_database_connection();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let ref uuid = Uuid::new_v4().simple().to_string(); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let uuid = &Uuid::new_v4().simple().to_string();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/user_management.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let ref connection = get_database_connection(); [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------------- help: try: `let connection = &get_database_connection();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | format!("{}", user_management::get_other_users(id_string).to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `user_management::get_other_users(id_string).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | let mut res = format!(""); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.99s [INFO] running `"docker" "inspect" "1f44a208e0475cd618e319a2d33d5e6f468394e924e5a7b767808717b366f0c3"` [INFO] running `"docker" "rm" "-f" "1f44a208e0475cd618e319a2d33d5e6f468394e924e5a7b767808717b366f0c3"` [INFO] [stdout] 1f44a208e0475cd618e319a2d33d5e6f468394e924e5a7b767808717b366f0c3