[INFO] updating cached repository LaboratoryForPlayfulComputation/pxexec-orchestrator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LaboratoryForPlayfulComputation/pxexec-orchestrator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LaboratoryForPlayfulComputation/pxexec-orchestrator" "work/ex/clippy-test-run/sources/stable/gh/LaboratoryForPlayfulComputation/pxexec-orchestrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LaboratoryForPlayfulComputation/pxexec-orchestrator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LaboratoryForPlayfulComputation/pxexec-orchestrator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LaboratoryForPlayfulComputation/pxexec-orchestrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LaboratoryForPlayfulComputation/pxexec-orchestrator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 46cc4fe519e46b70b12b6d980a86fbbb0478b2fd [INFO] sha for GitHub repo LaboratoryForPlayfulComputation/pxexec-orchestrator: 46cc4fe519e46b70b12b6d980a86fbbb0478b2fd [INFO] validating manifest of LaboratoryForPlayfulComputation/pxexec-orchestrator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LaboratoryForPlayfulComputation/pxexec-orchestrator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LaboratoryForPlayfulComputation/pxexec-orchestrator [INFO] finished frobbing LaboratoryForPlayfulComputation/pxexec-orchestrator [INFO] frobbed toml for LaboratoryForPlayfulComputation/pxexec-orchestrator written to work/ex/clippy-test-run/sources/stable/gh/LaboratoryForPlayfulComputation/pxexec-orchestrator/Cargo.toml [INFO] started frobbing LaboratoryForPlayfulComputation/pxexec-orchestrator [INFO] finished frobbing LaboratoryForPlayfulComputation/pxexec-orchestrator [INFO] frobbed toml for LaboratoryForPlayfulComputation/pxexec-orchestrator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LaboratoryForPlayfulComputation/pxexec-orchestrator/Cargo.toml [INFO] crate LaboratoryForPlayfulComputation/pxexec-orchestrator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LaboratoryForPlayfulComputation/pxexec-orchestrator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LaboratoryForPlayfulComputation/pxexec-orchestrator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cbca3472231891116e6874a1e5cba41d25452914a8883c666c0695137e917751 [INFO] running `"docker" "start" "-a" "cbca3472231891116e6874a1e5cba41d25452914a8883c666c0695137e917751"` [INFO] [stderr] Checking memchr v2.0.2 [INFO] [stderr] Checking backtrace-sys v0.1.24 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking regex v1.0.4 [INFO] [stderr] Checking mount v0.4.0 [INFO] [stderr] Checking router v0.6.0 [INFO] [stderr] Checking staticfile v0.5.0 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking pxexec-orchestrator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tsc.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | const _PXEXEC_PREFIX: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tsc.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | const _PXEXEC_SUFFIX: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tsc.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | const _PXEXEC_TSC_FMT_STRING: &'static str = "tsc --out {out_dir}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tsc.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | const _PXEXEC_PREFIX: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tsc.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | const _PXEXEC_SUFFIX: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tsc.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | const _PXEXEC_TSC_FMT_STRING: &'static str = "tsc --out {out_dir}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tsc.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / match prev { [INFO] [stderr] 89 | | Some(mut child) => { [INFO] [stderr] 90 | | child.kill().unwrap(); [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | None => {} [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | if let Some(mut child) = prev { [INFO] [stderr] 89 | child.kill().unwrap(); [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:144:57 [INFO] [stderr] | [INFO] [stderr] 144 | env::var("PXEXEC_OVERRIDE_EDITOR_PATH").unwrap_or(String::from("./editor/")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("./editor/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:153:39 [INFO] [stderr] | [INFO] [stderr] 153 | .http(env::var("PXEXEC_HOST").unwrap_or(String::from("0.0.0.0:80"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("0.0.0.0:80"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tsc.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / match prev { [INFO] [stderr] 89 | | Some(mut child) => { [INFO] [stderr] 90 | | child.kill().unwrap(); [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | None => {} [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | if let Some(mut child) = prev { [INFO] [stderr] 89 | child.kill().unwrap(); [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:144:57 [INFO] [stderr] | [INFO] [stderr] 144 | env::var("PXEXEC_OVERRIDE_EDITOR_PATH").unwrap_or(String::from("./editor/")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("./editor/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:153:39 [INFO] [stderr] | [INFO] [stderr] 153 | .http(env::var("PXEXEC_HOST").unwrap_or(String::from("0.0.0.0:80"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("0.0.0.0:80"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.20s [INFO] running `"docker" "inspect" "cbca3472231891116e6874a1e5cba41d25452914a8883c666c0695137e917751"` [INFO] running `"docker" "rm" "-f" "cbca3472231891116e6874a1e5cba41d25452914a8883c666c0695137e917751"` [INFO] [stdout] cbca3472231891116e6874a1e5cba41d25452914a8883c666c0695137e917751