[INFO] updating cached repository LPGhatguy/mab [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LPGhatguy/mab [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LPGhatguy/mab" "work/ex/clippy-test-run/sources/stable/gh/LPGhatguy/mab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LPGhatguy/mab'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LPGhatguy/mab" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LPGhatguy/mab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LPGhatguy/mab'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3dd98517b068bf6be3c5144cf2cf9dfd712d0fb6 [INFO] sha for GitHub repo LPGhatguy/mab: 3dd98517b068bf6be3c5144cf2cf9dfd712d0fb6 [INFO] validating manifest of LPGhatguy/mab on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LPGhatguy/mab on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LPGhatguy/mab [INFO] finished frobbing LPGhatguy/mab [INFO] frobbed toml for LPGhatguy/mab written to work/ex/clippy-test-run/sources/stable/gh/LPGhatguy/mab/Cargo.toml [INFO] started frobbing LPGhatguy/mab [INFO] finished frobbing LPGhatguy/mab [INFO] frobbed toml for LPGhatguy/mab written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LPGhatguy/mab/Cargo.toml [INFO] crate LPGhatguy/mab has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LPGhatguy/mab against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LPGhatguy/mab:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75a23bad6c743065e856e790dcd68ea872f0caf76f69c436b6978da4d1146883 [INFO] running `"docker" "start" "-a" "75a23bad6c743065e856e790dcd68ea872f0caf76f69c436b6978da4d1146883"` [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking mab v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser_core.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / loop { [INFO] [stderr] 125 | | match self.1.parse(state) { [INFO] [stderr] 126 | | Ok((next_state, _)) => { [INFO] [stderr] 127 | | state = next_state; [INFO] [stderr] ... | [INFO] [stderr] 135 | | values.push(value); [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok((next_state, _)) = self.1.parse(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser_core.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / loop { [INFO] [stderr] 163 | | match self.1.parse(state) { [INFO] [stderr] 164 | | Ok((next_state, _)) => { [INFO] [stderr] 165 | | state = next_state; [INFO] [stderr] ... | [INFO] [stderr] 185 | | values.push(value); [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok((next_state, _)) = self.1.parse(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ast.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn precedence(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ast.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn is_right_associative(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/emitter.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match statement { [INFO] [stderr] 15 | | &Statement::Assignment(ref value) => emit_assignment(w, value)?, [INFO] [stderr] 16 | | &Statement::LocalAssignment(ref value) => emit_local_assignment(w, value)?, [INFO] [stderr] 17 | | &Statement::FunctionCall(ref value) => emit_function_call(w, value)?, [INFO] [stderr] ... | [INFO] [stderr] 23 | | &Statement::FunctionDeclaration(ref value) => emit_function_declaration(w, value)?, [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *statement { [INFO] [stderr] 15 | Statement::Assignment(ref value) => emit_assignment(w, value)?, [INFO] [stderr] 16 | Statement::LocalAssignment(ref value) => emit_local_assignment(w, value)?, [INFO] [stderr] 17 | Statement::FunctionCall(ref value) => emit_function_call(w, value)?, [INFO] [stderr] 18 | Statement::NumericFor(ref value) => emit_numeric_for(w, value)?, [INFO] [stderr] 19 | Statement::GenericFor(ref value) => emit_generic_for(w, value)?, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tokenizer.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:113:47 [INFO] [stderr] | [INFO] [stderr] 113 | let lines_consumed = consumed.matches("\n").count(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser_core.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / loop { [INFO] [stderr] 125 | | match self.1.parse(state) { [INFO] [stderr] 126 | | Ok((next_state, _)) => { [INFO] [stderr] 127 | | state = next_state; [INFO] [stderr] ... | [INFO] [stderr] 135 | | values.push(value); [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok((next_state, _)) = self.1.parse(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser_core.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / loop { [INFO] [stderr] 163 | | match self.1.parse(state) { [INFO] [stderr] 164 | | Ok((next_state, _)) => { [INFO] [stderr] 165 | | state = next_state; [INFO] [stderr] ... | [INFO] [stderr] 185 | | values.push(value); [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok((next_state, _)) = self.1.parse(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ast.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn precedence(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ast.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn is_right_associative(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:347:50 [INFO] [stderr] | [INFO] [stderr] 347 | let quote_character = if current.starts_with("\"") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:349:35 [INFO] [stderr] | [INFO] [stderr] 349 | } else if current.starts_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tokenizer.rs:399:63 [INFO] [stderr] | [INFO] [stderr] 399 | new_position: current_position.next_position(¤t[..literal_end + 1]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `..=literal_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokenizer.rs:433:47 [INFO] [stderr] | [INFO] [stderr] 433 | let end_captures = end_reg.captures(rest).ok_or(MultiLineError::Unclosed(*current_position))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MultiLineError::Unclosed(*current_position))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:539:37 [INFO] [stderr] | [INFO] [stderr] 539 | start_position: current_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:540:35 [INFO] [stderr] | [INFO] [stderr] 540 | end_position: current_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:552:37 [INFO] [stderr] | [INFO] [stderr] 552 | start_position: current_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:553:35 [INFO] [stderr] | [INFO] [stderr] 553 | end_position: result.new_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `result.new_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / loop { [INFO] [stderr] 144 | | let (next_state, operator) = match ParseBinaryOp.parse(state) { [INFO] [stderr] 145 | | Ok(v) => v, [INFO] [stderr] 146 | | Err(_) => break, [INFO] [stderr] ... | [INFO] [stderr] 166 | | }); [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(v) = ParseBinaryOp.parse(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:338:5 [INFO] [stderr] | [INFO] [stderr] 338 | / loop { [INFO] [stderr] 339 | | let (next_state, _) = match ParseSymbol(Symbol::ElseIf).parse(state) { [INFO] [stderr] 340 | | Ok(v) => v, [INFO] [stderr] 341 | | Err(_) => break, [INFO] [stderr] ... | [INFO] [stderr] 349 | | else_if_branches.push((condition, body)); [INFO] [stderr] 350 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(v) = ParseSymbol(Symbol::ElseIf).parse(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:439:59 [INFO] [stderr] | [INFO] [stderr] 439 | Ok((state, identifier)) => (state, TableKey::Name(identifier.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `identifier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/emitter.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match statement { [INFO] [stderr] 15 | | &Statement::Assignment(ref value) => emit_assignment(w, value)?, [INFO] [stderr] 16 | | &Statement::LocalAssignment(ref value) => emit_local_assignment(w, value)?, [INFO] [stderr] 17 | | &Statement::FunctionCall(ref value) => emit_function_call(w, value)?, [INFO] [stderr] ... | [INFO] [stderr] 23 | | &Statement::FunctionDeclaration(ref value) => emit_function_declaration(w, value)?, [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *statement { [INFO] [stderr] 15 | Statement::Assignment(ref value) => emit_assignment(w, value)?, [INFO] [stderr] 16 | Statement::LocalAssignment(ref value) => emit_local_assignment(w, value)?, [INFO] [stderr] 17 | Statement::FunctionCall(ref value) => emit_function_call(w, value)?, [INFO] [stderr] 18 | Statement::NumericFor(ref value) => emit_numeric_for(w, value)?, [INFO] [stderr] 19 | Statement::GenericFor(ref value) => emit_generic_for(w, value)?, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tokenizer.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:113:47 [INFO] [stderr] | [INFO] [stderr] 113 | let lines_consumed = consumed.matches("\n").count(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:347:50 [INFO] [stderr] | [INFO] [stderr] 347 | let quote_character = if current.starts_with("\"") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:349:35 [INFO] [stderr] | [INFO] [stderr] 349 | } else if current.starts_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tokenizer.rs:399:63 [INFO] [stderr] | [INFO] [stderr] 399 | new_position: current_position.next_position(¤t[..literal_end + 1]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `..=literal_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokenizer.rs:433:47 [INFO] [stderr] | [INFO] [stderr] 433 | let end_captures = end_reg.captures(rest).ok_or(MultiLineError::Unclosed(*current_position))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MultiLineError::Unclosed(*current_position))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:539:37 [INFO] [stderr] | [INFO] [stderr] 539 | start_position: current_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:540:35 [INFO] [stderr] | [INFO] [stderr] 540 | end_position: current_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:552:37 [INFO] [stderr] | [INFO] [stderr] 552 | start_position: current_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:553:35 [INFO] [stderr] | [INFO] [stderr] 553 | end_position: result.new_position.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `result.new_position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / loop { [INFO] [stderr] 144 | | let (next_state, operator) = match ParseBinaryOp.parse(state) { [INFO] [stderr] 145 | | Ok(v) => v, [INFO] [stderr] 146 | | Err(_) => break, [INFO] [stderr] ... | [INFO] [stderr] 166 | | }); [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(v) = ParseBinaryOp.parse(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:338:5 [INFO] [stderr] | [INFO] [stderr] 338 | / loop { [INFO] [stderr] 339 | | let (next_state, _) = match ParseSymbol(Symbol::ElseIf).parse(state) { [INFO] [stderr] 340 | | Ok(v) => v, [INFO] [stderr] 341 | | Err(_) => break, [INFO] [stderr] ... | [INFO] [stderr] 349 | | else_if_branches.push((condition, body)); [INFO] [stderr] 350 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(v) = ParseSymbol(Symbol::ElseIf).parse(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:439:59 [INFO] [stderr] | [INFO] [stderr] 439 | Ok((state, identifier)) => (state, TableKey::Name(identifier.into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `identifier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.04s [INFO] running `"docker" "inspect" "75a23bad6c743065e856e790dcd68ea872f0caf76f69c436b6978da4d1146883"` [INFO] running `"docker" "rm" "-f" "75a23bad6c743065e856e790dcd68ea872f0caf76f69c436b6978da4d1146883"` [INFO] [stdout] 75a23bad6c743065e856e790dcd68ea872f0caf76f69c436b6978da4d1146883