[INFO] updating cached repository LFalch/chroma-lists [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LFalch/chroma-lists [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LFalch/chroma-lists" "work/ex/clippy-test-run/sources/stable/gh/LFalch/chroma-lists"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LFalch/chroma-lists'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LFalch/chroma-lists" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LFalch/chroma-lists"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LFalch/chroma-lists'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bcf703d3b43677fc79894b3b498a12c73b4442e5 [INFO] sha for GitHub repo LFalch/chroma-lists: bcf703d3b43677fc79894b3b498a12c73b4442e5 [INFO] validating manifest of LFalch/chroma-lists on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LFalch/chroma-lists on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LFalch/chroma-lists [INFO] finished frobbing LFalch/chroma-lists [INFO] frobbed toml for LFalch/chroma-lists written to work/ex/clippy-test-run/sources/stable/gh/LFalch/chroma-lists/Cargo.toml [INFO] started frobbing LFalch/chroma-lists [INFO] finished frobbing LFalch/chroma-lists [INFO] frobbed toml for LFalch/chroma-lists written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LFalch/chroma-lists/Cargo.toml [INFO] crate LFalch/chroma-lists has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LFalch/chroma-lists against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LFalch/chroma-lists:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fef1789e4ff9d4d763ce54c2ca5dce6e2f428de034dd3a40cb887dec08640f2c [INFO] running `"docker" "start" "-a" "fef1789e4ff9d4d763ce54c2ca5dce6e2f428de034dd3a40cb887dec08640f2c"` [INFO] [stderr] Checking chroma-lists v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: item `ChromaList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / impl ChromaList { [INFO] [stderr] 78 | | pub fn len(&self) -> usize { [INFO] [stderr] 79 | | self.0.iter().map(|l| l.len()).sum() [INFO] [stderr] 80 | | } [INFO] [stderr] ... | [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `ChromaList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / impl ChromaList { [INFO] [stderr] 78 | | pub fn len(&self) -> usize { [INFO] [stderr] 79 | | self.0.iter().map(|l| l.len()).sum() [INFO] [stderr] 80 | | } [INFO] [stderr] ... | [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let iters = list.into_iter().inspect(|s| if let Some(ref mut o) = output_file {write!(o, "{}", s).unwrap()}).count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let iters = list.into_iter().inspect(|s| if let Some(ref mut o) = output_file {write!(o, "{}", s).unwrap()}).count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.72s [INFO] running `"docker" "inspect" "fef1789e4ff9d4d763ce54c2ca5dce6e2f428de034dd3a40cb887dec08640f2c"` [INFO] running `"docker" "rm" "-f" "fef1789e4ff9d4d763ce54c2ca5dce6e2f428de034dd3a40cb887dec08640f2c"` [INFO] [stdout] fef1789e4ff9d4d763ce54c2ca5dce6e2f428de034dd3a40cb887dec08640f2c