[INFO] updating cached repository LFalch/arsehole [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LFalch/arsehole [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LFalch/arsehole" "work/ex/clippy-test-run/sources/stable/gh/LFalch/arsehole"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LFalch/arsehole'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LFalch/arsehole" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LFalch/arsehole"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LFalch/arsehole'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 073d188e8c89e9a6992eb16842fef2eb3761a981 [INFO] sha for GitHub repo LFalch/arsehole: 073d188e8c89e9a6992eb16842fef2eb3761a981 [INFO] validating manifest of LFalch/arsehole on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LFalch/arsehole on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LFalch/arsehole [INFO] finished frobbing LFalch/arsehole [INFO] frobbed toml for LFalch/arsehole written to work/ex/clippy-test-run/sources/stable/gh/LFalch/arsehole/Cargo.toml [INFO] started frobbing LFalch/arsehole [INFO] finished frobbing LFalch/arsehole [INFO] frobbed toml for LFalch/arsehole written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LFalch/arsehole/Cargo.toml [INFO] crate LFalch/arsehole has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LFalch/arsehole against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LFalch/arsehole:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] efae72844788bde29bffb156692fc71ea3fb8bdd865bf2b98f41c30a459f0c57 [INFO] running `"docker" "start" "-a" "efae72844788bde29bffb156692fc71ea3fb8bdd865bf2b98f41c30a459f0c57"` [INFO] [stderr] Compiling khronos_api v2.2.0 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling bitflags v1.0.4 [INFO] [stderr] Compiling cfg-if v0.1.5 [INFO] [stderr] Compiling proc-macro2 v0.4.20 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling cc v1.0.25 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling either v1.5.0 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking byteorder v1.2.6 [INFO] [stderr] Compiling matrixmultiply v0.1.14 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Compiling serde v1.0.79 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Checking xi-unicode v0.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.7 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking xdg v2.1.0 [INFO] [stderr] Checking podio v0.1.6 [INFO] [stderr] Checking claxon v0.3.2 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Compiling log v0.4.5 [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking inflate v0.4.3 [INFO] [stderr] Checking stb_truetype v0.2.4 [INFO] [stderr] Checking ogg v0.4.1 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Checking app_dirs2 v2.0.3 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking lewton v0.5.2 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking twox-hash v1.1.1 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking euclid v0.17.3 [INFO] [stderr] Checking sid v0.5.2 [INFO] [stderr] Checking ordered-float v0.5.2 [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Compiling smart-default v0.2.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking alga v0.5.4 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking toml v0.4.8 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Compiling syn v0.15.8 [INFO] [stderr] Checking lyon_geom v0.10.1 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rodio v0.7.0 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking lyon_path v0.10.1 [INFO] [stderr] Checking nalgebra v0.14.4 [INFO] [stderr] Checking zip v0.3.3 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking lyon_tessellation v0.10.2 [INFO] [stderr] Checking lyon v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking gfx_window_sdl v0.8.0 [INFO] [stderr] Checking gfx_glyph v0.10.2 [INFO] [stderr] Checking ggez v0.4.4 [INFO] [stderr] Checking arsehole v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: struct is never constructed: `Krig` [INFO] [stderr] --> src/lib.rs:132:1 [INFO] [stderr] | [INFO] [stderr] 132 | struct Krig; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Roevhul` [INFO] [stderr] --> src/lib.rs:136:1 [INFO] [stderr] | [INFO] [stderr] 136 | struct Roevhul; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | let deck = (0..52).map(|n| Card::from(n)).collect::>(); [INFO] [stderr] 15 | | Self { [INFO] [stderr] 16 | | deck, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/game.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | let deck = (0..52).map(|n| Card::from(n)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Card::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/game.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | let deck = (0..54).map(|n| Card::from(n)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Card::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Krig` [INFO] [stderr] --> src/lib.rs:132:1 [INFO] [stderr] | [INFO] [stderr] 132 | struct Krig; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Roevhul` [INFO] [stderr] --> src/lib.rs:136:1 [INFO] [stderr] | [INFO] [stderr] 136 | struct Roevhul; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::Game` [INFO] [stderr] --> src/game.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | let deck = (0..52).map(|n| Card::from(n)).collect::>(); [INFO] [stderr] 15 | | Self { [INFO] [stderr] 16 | | deck, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/game.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | let deck = (0..52).map(|n| Card::from(n)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Card::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/game.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | let deck = (0..54).map(|n| Card::from(n)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Card::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn is_red(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn is_black(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | fn beats(c1: &Card, c2: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:121:29 [INFO] [stderr] | [INFO] [stderr] 121 | fn beats(c1: &Card, c2: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn is_red(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn is_black(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | fn beats(c1: &Card, c2: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:121:29 [INFO] [stderr] | [INFO] [stderr] 121 | fn beats(c1: &Card, c2: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/server.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | let accept_more = Arc::new(Mutex::new(true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match bincode::deserialize_from(&peers.lock().unwrap()[0]) { [INFO] [stderr] 36 | | Ok(ClientPacket::BeginGame) => break, [INFO] [stderr] 37 | | _ => (), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(ClientPacket::BeginGame) = bincode::deserialize_from(&peers.lock().unwrap()[0]) { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/server.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | let accept_more = Arc::new(Mutex::new(true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match bincode::deserialize_from(&peers.lock().unwrap()[0]) { [INFO] [stderr] 36 | | Ok(ClientPacket::BeginGame) => break, [INFO] [stderr] 37 | | _ => (), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(ClientPacket::BeginGame) = bincode::deserialize_from(&peers.lock().unwrap()[0]) { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:71:30 [INFO] [stderr] | [INFO] [stderr] 71 | if deck_size == 0 && self.game.deck.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.game.deck.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | let src_x = cx as f32 / 14.; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(cx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | let src_y = cy as f32 / 4.; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(cy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:71:30 [INFO] [stderr] | [INFO] [stderr] 71 | if deck_size == 0 && self.game.deck.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.game.deck.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | let src_x = cx as f32 / 14.; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(cx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | let src_y = cy as f32 / 4.; [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(cy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 3m 53s [INFO] running `"docker" "inspect" "efae72844788bde29bffb156692fc71ea3fb8bdd865bf2b98f41c30a459f0c57"` [INFO] running `"docker" "rm" "-f" "efae72844788bde29bffb156692fc71ea3fb8bdd865bf2b98f41c30a459f0c57"` [INFO] [stdout] efae72844788bde29bffb156692fc71ea3fb8bdd865bf2b98f41c30a459f0c57