[INFO] updating cached repository LFalch/arkanoid [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LFalch/arkanoid [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LFalch/arkanoid" "work/ex/clippy-test-run/sources/stable/gh/LFalch/arkanoid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LFalch/arkanoid'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LFalch/arkanoid" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LFalch/arkanoid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LFalch/arkanoid'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 79a7bb6fa40e2bd70a366df00dd047ecef0e9301 [INFO] sha for GitHub repo LFalch/arkanoid: 79a7bb6fa40e2bd70a366df00dd047ecef0e9301 [INFO] validating manifest of LFalch/arkanoid on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LFalch/arkanoid on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LFalch/arkanoid [INFO] finished frobbing LFalch/arkanoid [INFO] frobbed toml for LFalch/arkanoid written to work/ex/clippy-test-run/sources/stable/gh/LFalch/arkanoid/Cargo.toml [INFO] started frobbing LFalch/arkanoid [INFO] finished frobbing LFalch/arkanoid [INFO] frobbed toml for LFalch/arkanoid written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LFalch/arkanoid/Cargo.toml [INFO] crate LFalch/arkanoid has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LFalch/arkanoid against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/LFalch/arkanoid:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da279704fbf7d12d216902d165c6bbb66b4623a584fe66ca0521ae436387d582 [INFO] running `"docker" "start" "-a" "da279704fbf7d12d216902d165c6bbb66b4623a584fe66ca0521ae436387d582"` [INFO] [stderr] Compiling libc v0.2.19 [INFO] [stderr] Compiling serde v0.8.22 [INFO] [stderr] Checking quick-error v1.1.0 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking collider v0.2.0 [INFO] [stderr] Compiling glium v0.16.0 [INFO] [stderr] Checking x11-dl v2.12.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.4 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking image v0.12.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Compiling phf_generator v0.7.20 [INFO] [stderr] Compiling phf_codegen v0.7.20 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling serde_json v0.8.4 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.6 [INFO] [stderr] Checking wayland-client v0.7.6 [INFO] [stderr] Checking wayland-window v0.4.3 [INFO] [stderr] Checking wayland-kbd v0.6.2 [INFO] [stderr] Checking winit v0.5.7 [INFO] [stderr] Checking glutin v0.7.2 [INFO] [stderr] Checking korome v0.14.1 [INFO] [stderr] Checking arkanoid v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/obj.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | const BALL_GRP: &'static [Group] = &[PADDLE, BRICK, BALL]; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[Group]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/obj.rs:155:28 [INFO] [stderr] | [INFO] [stderr] 155 | const NORMAL_GRP: &'static [Group] = &[BALL]; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[Group]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/obj.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | (ty as u32 as HitboxId..).filter(|i| !self.objs.contains(i)).next().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|i| !self.objs.contains(i)).next()` with `find(|i| !self.objs.contains(i))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | (ty as u32 as HitboxId..).filter(|i| !self.objs.contains(i)).next().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ty as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has the same condition as a previous if [INFO] [stderr] --> src/obj.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | } else if id >= BRICK as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::ifs_same_cond)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/obj.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | if id >= BRICK as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ifs_same_cond [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | if id >= BRICK as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(BRICK)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | } else if id >= BALL as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(BALL)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | } else if id >= BRICK as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(BRICK)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/obj.rs:130:22 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn is_paddle(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/obj.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn is_ball(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let wh = (w as f64, h as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | let wh = (w as f64, h as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:61 [INFO] [stderr] | [INFO] [stderr] 31 | let delta = if info.delta > 0.16666 {0.16666} else {info.delta as f64}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(info.delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arkanoid`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/obj.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | const BALL_GRP: &'static [Group] = &[PADDLE, BRICK, BALL]; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[Group]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/obj.rs:155:28 [INFO] [stderr] | [INFO] [stderr] 155 | const NORMAL_GRP: &'static [Group] = &[BALL]; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[Group]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/obj.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | (ty as u32 as HitboxId..).filter(|i| !self.objs.contains(i)).next().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|i| !self.objs.contains(i)).next()` with `find(|i| !self.objs.contains(i))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj.rs:30:10 [INFO] [stderr] | [INFO] [stderr] 30 | (ty as u32 as HitboxId..).filter(|i| !self.objs.contains(i)).next().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ty as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has the same condition as a previous if [INFO] [stderr] --> src/obj.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | } else if id >= BRICK as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::ifs_same_cond)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/obj.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | if id >= BRICK as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ifs_same_cond [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | if id >= BRICK as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(BRICK)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | } else if id >= BALL as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(BALL)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | } else if id >= BRICK as HitboxId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(BRICK)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/obj.rs:130:22 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn is_paddle(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/obj.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn is_ball(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let wh = (w as f64, h as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | let wh = (w as f64, h as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:61 [INFO] [stderr] | [INFO] [stderr] 31 | let delta = if info.delta > 0.16666 {0.16666} else {info.delta as f64}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(info.delta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arkanoid`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "da279704fbf7d12d216902d165c6bbb66b4623a584fe66ca0521ae436387d582"` [INFO] running `"docker" "rm" "-f" "da279704fbf7d12d216902d165c6bbb66b4623a584fe66ca0521ae436387d582"` [INFO] [stdout] da279704fbf7d12d216902d165c6bbb66b4623a584fe66ca0521ae436387d582