[INFO] updating cached repository L3nn0x/rust-snake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/L3nn0x/rust-snake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/L3nn0x/rust-snake" "work/ex/clippy-test-run/sources/stable/gh/L3nn0x/rust-snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/L3nn0x/rust-snake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/L3nn0x/rust-snake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/L3nn0x/rust-snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/L3nn0x/rust-snake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 362fe753a5bec81209e486374a0ff6e7dcffc135 [INFO] sha for GitHub repo L3nn0x/rust-snake: 362fe753a5bec81209e486374a0ff6e7dcffc135 [INFO] validating manifest of L3nn0x/rust-snake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of L3nn0x/rust-snake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing L3nn0x/rust-snake [INFO] finished frobbing L3nn0x/rust-snake [INFO] frobbed toml for L3nn0x/rust-snake written to work/ex/clippy-test-run/sources/stable/gh/L3nn0x/rust-snake/Cargo.toml [INFO] started frobbing L3nn0x/rust-snake [INFO] finished frobbing L3nn0x/rust-snake [INFO] frobbed toml for L3nn0x/rust-snake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/L3nn0x/rust-snake/Cargo.toml [INFO] crate L3nn0x/rust-snake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting L3nn0x/rust-snake against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/L3nn0x/rust-snake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1ef52a6ffa1ae28ddf042b0f2208f875f851053ffa233e6b1bfd9491e31ecbd [INFO] running `"docker" "start" "-a" "a1ef52a6ffa1ae28ddf042b0f2208f875f851053ffa233e6b1bfd9491e31ecbd"` [INFO] [stderr] Compiling bitflags v1.0.2 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Compiling num-derive v0.2.0 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.46.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.2 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.79.0 [INFO] [stderr] Checking snake-game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | let mut world = World { font: font}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | let mut world = World { font: font}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state_machine.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | fn update(&mut self, args: &UpdateArgs) -> Transition; [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state_machine.rs:65:33 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn update(&mut self, u: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | (self.apple.0 * 20) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.apple.0 * 20)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | (self.apple.1 * 20) as f64, 20_f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.apple.1 * 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (x * 20) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(x * 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | (y * 20) as f64, 20_f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(y * 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:147:28 [INFO] [stderr] | [INFO] [stderr] 147 | fn is_body(&self, pos: &(i32, i32)) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:151:29 [INFO] [stderr] | [INFO] [stderr] 151 | fn update(&mut self, u: &UpdateArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:157:28 [INFO] [stderr] | [INFO] [stderr] 157 | let mut new_head = (*self.body.front().expect("Snake has no body")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*self.body.front().expect("Snake has no body"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let ref font = assets.join("arial.ttf"); [INFO] [stderr] | ----^^^^^^^^---------------------------- help: try: `let font = &assets.join("arial.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state_machine.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | fn update(&mut self, args: &UpdateArgs) -> Transition; [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state_machine.rs:65:33 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn update(&mut self, u: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | (self.apple.0 * 20) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.apple.0 * 20)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | (self.apple.1 * 20) as f64, 20_f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.apple.1 * 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | (x * 20) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(x * 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | (y * 20) as f64, 20_f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(y * 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:147:28 [INFO] [stderr] | [INFO] [stderr] 147 | fn is_body(&self, pos: &(i32, i32)) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:151:29 [INFO] [stderr] | [INFO] [stderr] 151 | fn update(&mut self, u: &UpdateArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:157:28 [INFO] [stderr] | [INFO] [stderr] 157 | let mut new_head = (*self.body.front().expect("Snake has no body")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*self.body.front().expect("Snake has no body"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let ref font = assets.join("arial.ttf"); [INFO] [stderr] | ----^^^^^^^^---------------------------- help: try: `let font = &assets.join("arial.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 32s [INFO] running `"docker" "inspect" "a1ef52a6ffa1ae28ddf042b0f2208f875f851053ffa233e6b1bfd9491e31ecbd"` [INFO] running `"docker" "rm" "-f" "a1ef52a6ffa1ae28ddf042b0f2208f875f851053ffa233e6b1bfd9491e31ecbd"` [INFO] [stdout] a1ef52a6ffa1ae28ddf042b0f2208f875f851053ffa233e6b1bfd9491e31ecbd