[INFO] updating cached repository Kyefer/rcc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Kyefer/rcc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Kyefer/rcc" "work/ex/clippy-test-run/sources/stable/gh/Kyefer/rcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kyefer/rcc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Kyefer/rcc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kyefer/rcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kyefer/rcc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9df499ad3bb70c8700537d22de8a663efed0e927 [INFO] sha for GitHub repo Kyefer/rcc: 9df499ad3bb70c8700537d22de8a663efed0e927 [INFO] validating manifest of Kyefer/rcc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Kyefer/rcc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Kyefer/rcc [INFO] finished frobbing Kyefer/rcc [INFO] frobbed toml for Kyefer/rcc written to work/ex/clippy-test-run/sources/stable/gh/Kyefer/rcc/Cargo.toml [INFO] started frobbing Kyefer/rcc [INFO] finished frobbing Kyefer/rcc [INFO] frobbed toml for Kyefer/rcc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kyefer/rcc/Cargo.toml [INFO] crate Kyefer/rcc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Kyefer/rcc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kyefer/rcc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7745732d38383078c4247ca1cd7e24d8efb485dac820d4b0cb423ead171e797 [INFO] running `"docker" "start" "-a" "d7745732d38383078c4247ca1cd7e24d8efb485dac820d4b0cb423ead171e797"` [INFO] [stderr] Checking rcc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | ttype: ttype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ttype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | ttype: ttype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ttype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generator.rs:74:34 [INFO] [stderr] | [INFO] [stderr] 74 | Param::Const(int) => String::from(format!("${}", int)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("${}", int)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generator.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | Param::Register(reg) => String::from(format!("%{}", reg.to_asm())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("%{}", reg.to_asm())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:286:47 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn write(instructions: &Vec, file: &mut T) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:306:28 [INFO] [stderr] | [INFO] [stderr] 306 | pub fn print_asm(assembly: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn lex(code: &String) -> VecDeque { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 167 | pub fn lex(code: &str) -> VecDeque { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `code.as_str()` to [INFO] [stderr] | [INFO] [stderr] 168 | let mut source = code; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / loop { [INFO] [stderr] 123 | | match tokens.get(0) { [INFO] [stderr] 124 | | Some(Token { [INFO] [stderr] 125 | | ttype: TokenType::Operator { otype, .. }, [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | while let Some(Token { [INFO] [stderr] 123 | ttype: TokenType::Operator { otype, .. }, [INFO] [stderr] 124 | .. [INFO] [stderr] 125 | }) = tokens.get(0) { .. } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / loop { [INFO] [stderr] 152 | | match tokens.get(0) { [INFO] [stderr] 153 | | Some(Token { [INFO] [stderr] 154 | | ttype: TokenType::Operator { otype, .. }, [INFO] [stderr] ... | [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | while let Some(Token { [INFO] [stderr] 152 | ttype: TokenType::Operator { otype, .. }, [INFO] [stderr] 153 | .. [INFO] [stderr] 154 | }) = tokens.get(0) { .. } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generator.rs:74:34 [INFO] [stderr] | [INFO] [stderr] 74 | Param::Const(int) => String::from(format!("${}", int)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("${}", int)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generator.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | Param::Register(reg) => String::from(format!("%{}", reg.to_asm())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("%{}", reg.to_asm())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:286:47 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn write(instructions: &Vec, file: &mut T) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:306:28 [INFO] [stderr] | [INFO] [stderr] 306 | pub fn print_asm(assembly: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn lex(code: &String) -> VecDeque { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 167 | pub fn lex(code: &str) -> VecDeque { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `code.as_str()` to [INFO] [stderr] | [INFO] [stderr] 168 | let mut source = code; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / loop { [INFO] [stderr] 123 | | match tokens.get(0) { [INFO] [stderr] 124 | | Some(Token { [INFO] [stderr] 125 | | ttype: TokenType::Operator { otype, .. }, [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | while let Some(Token { [INFO] [stderr] 123 | ttype: TokenType::Operator { otype, .. }, [INFO] [stderr] 124 | .. [INFO] [stderr] 125 | }) = tokens.get(0) { .. } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / loop { [INFO] [stderr] 152 | | match tokens.get(0) { [INFO] [stderr] 153 | | Some(Token { [INFO] [stderr] 154 | | ttype: TokenType::Operator { otype, .. }, [INFO] [stderr] ... | [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | while let Some(Token { [INFO] [stderr] 152 | ttype: TokenType::Operator { otype, .. }, [INFO] [stderr] 153 | .. [INFO] [stderr] 154 | }) = tokens.get(0) { .. } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.93s [INFO] running `"docker" "inspect" "d7745732d38383078c4247ca1cd7e24d8efb485dac820d4b0cb423ead171e797"` [INFO] running `"docker" "rm" "-f" "d7745732d38383078c4247ca1cd7e24d8efb485dac820d4b0cb423ead171e797"` [INFO] [stdout] d7745732d38383078c4247ca1cd7e24d8efb485dac820d4b0cb423ead171e797