[INFO] updating cached repository Kuehle/bitmap-show-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Kuehle/bitmap-show-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Kuehle/bitmap-show-cli" "work/ex/clippy-test-run/sources/stable/gh/Kuehle/bitmap-show-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kuehle/bitmap-show-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Kuehle/bitmap-show-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kuehle/bitmap-show-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kuehle/bitmap-show-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f4d0bf3f491a25f73895e2b5ba8ed57e1fdd2bfb [INFO] sha for GitHub repo Kuehle/bitmap-show-cli: f4d0bf3f491a25f73895e2b5ba8ed57e1fdd2bfb [INFO] validating manifest of Kuehle/bitmap-show-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Kuehle/bitmap-show-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Kuehle/bitmap-show-cli [INFO] finished frobbing Kuehle/bitmap-show-cli [INFO] frobbed toml for Kuehle/bitmap-show-cli written to work/ex/clippy-test-run/sources/stable/gh/Kuehle/bitmap-show-cli/Cargo.toml [INFO] started frobbing Kuehle/bitmap-show-cli [INFO] finished frobbing Kuehle/bitmap-show-cli [INFO] frobbed toml for Kuehle/bitmap-show-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kuehle/bitmap-show-cli/Cargo.toml [INFO] crate Kuehle/bitmap-show-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Kuehle/bitmap-show-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kuehle/bitmap-show-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93f9a8ce76b181a4e6ded3adf576075ccb6d44a1418b1ae0aa50653e2efed27f [INFO] running `"docker" "start" "-a" "93f9a8ce76b181a4e6ded3adf576075ccb6d44a1418b1ae0aa50653e2efed27f"` [INFO] [stderr] Checking bmp v0.4.0 [INFO] [stderr] Checking bitmap-show-cli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Image` [INFO] [stderr] --> src/main.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | use bmp::{Image, Pixel}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Image` [INFO] [stderr] --> src/main.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | use bmp::{Image, Pixel}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/main.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | for (j, inner) in outer.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:47:43 [INFO] [stderr] | [INFO] [stderr] 47 | let x_mult = img.get_width() as f32 / ter_width as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(ter_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let y_mult = img.get_height() as f32 / ter_height as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(ter_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `render` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | render(& mut area); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | fn render(area: & Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | fn get_graphic(num: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: function `numberFromPixel` should have a snake case name such as `number_from_pixel` [INFO] [stderr] --> src/main.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / fn numberFromPixel(px: &Pixel) -> u32 { [INFO] [stderr] 92 | | (px.r as u32 + px.g as u32 + px.b as u32) / 154 [INFO] [stderr] 93 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | fn numberFromPixel(px: &Pixel) -> u32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:6 [INFO] [stderr] | [INFO] [stderr] 92 | (px.r as u32 + px.g as u32 + px.b as u32) / 154 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(px.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | (px.r as u32 + px.g as u32 + px.b as u32) / 154 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(px.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:34 [INFO] [stderr] | [INFO] [stderr] 92 | (px.r as u32 + px.g as u32 + px.b as u32) / 154 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(px.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/main.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | for (j, inner) in outer.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:47:43 [INFO] [stderr] | [INFO] [stderr] 47 | let x_mult = img.get_width() as f32 / ter_width as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(ter_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let y_mult = img.get_height() as f32 / ter_height as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(ter_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `render` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | render(& mut area); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | fn render(area: & Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | fn get_graphic(num: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: function `numberFromPixel` should have a snake case name such as `number_from_pixel` [INFO] [stderr] --> src/main.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / fn numberFromPixel(px: &Pixel) -> u32 { [INFO] [stderr] 92 | | (px.r as u32 + px.g as u32 + px.b as u32) / 154 [INFO] [stderr] 93 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | fn numberFromPixel(px: &Pixel) -> u32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:6 [INFO] [stderr] | [INFO] [stderr] 92 | (px.r as u32 + px.g as u32 + px.b as u32) / 154 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(px.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | (px.r as u32 + px.g as u32 + px.b as u32) / 154 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(px.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:34 [INFO] [stderr] | [INFO] [stderr] 92 | (px.r as u32 + px.g as u32 + px.b as u32) / 154 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(px.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.23s [INFO] running `"docker" "inspect" "93f9a8ce76b181a4e6ded3adf576075ccb6d44a1418b1ae0aa50653e2efed27f"` [INFO] running `"docker" "rm" "-f" "93f9a8ce76b181a4e6ded3adf576075ccb6d44a1418b1ae0aa50653e2efed27f"` [INFO] [stdout] 93f9a8ce76b181a4e6ded3adf576075ccb6d44a1418b1ae0aa50653e2efed27f