[INFO] updating cached repository Krystex/TinyBF [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Krystex/TinyBF [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Krystex/TinyBF" "work/ex/clippy-test-run/sources/stable/gh/Krystex/TinyBF"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Krystex/TinyBF'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Krystex/TinyBF" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Krystex/TinyBF"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Krystex/TinyBF'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a04ff283b024970c4a5cacf7fb39f1cfd3b7a4aa [INFO] sha for GitHub repo Krystex/TinyBF: a04ff283b024970c4a5cacf7fb39f1cfd3b7a4aa [INFO] validating manifest of Krystex/TinyBF on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Krystex/TinyBF on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Krystex/TinyBF [INFO] finished frobbing Krystex/TinyBF [INFO] frobbed toml for Krystex/TinyBF written to work/ex/clippy-test-run/sources/stable/gh/Krystex/TinyBF/Cargo.toml [INFO] started frobbing Krystex/TinyBF [INFO] finished frobbing Krystex/TinyBF [INFO] frobbed toml for Krystex/TinyBF written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Krystex/TinyBF/Cargo.toml [INFO] crate Krystex/TinyBF has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Krystex/TinyBF against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Krystex/TinyBF:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c15ce44f95da234a79d8d211b04736f008e4bded40beccfb2588dd0c83d10ff2 [INFO] running `"docker" "start" "-a" "c15ce44f95da234a79d8d211b04736f008e4bded40beccfb2588dd0c83d10ff2"` [INFO] [stderr] Checking TinyBF v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: crate `TinyBF` should have a snake case name such as `tiny_bf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `VM` [INFO] [stderr] --> src/main.rs:32:2 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new() -> VM { [INFO] [stderr] | _____^ [INFO] [stderr] 33 | | VM { [INFO] [stderr] 34 | | program: Vec::new(), [INFO] [stderr] 35 | | stack: Vec::with_capacity(16), [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let val = self.stack.get(self.sp).map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.stack.get(self.sp).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let val = self.stack.get(self.sp).map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.stack.get(self.sp).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: crate `TinyBF` should have a snake case name such as `tiny_bf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `VM` [INFO] [stderr] --> src/main.rs:32:2 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new() -> VM { [INFO] [stderr] | _____^ [INFO] [stderr] 33 | | VM { [INFO] [stderr] 34 | | program: Vec::new(), [INFO] [stderr] 35 | | stack: Vec::with_capacity(16), [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let val = self.stack.get(self.sp).map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.stack.get(self.sp).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let val = self.stack.get(self.sp).map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.stack.get(self.sp).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.77s [INFO] running `"docker" "inspect" "c15ce44f95da234a79d8d211b04736f008e4bded40beccfb2588dd0c83d10ff2"` [INFO] running `"docker" "rm" "-f" "c15ce44f95da234a79d8d211b04736f008e4bded40beccfb2588dd0c83d10ff2"` [INFO] [stdout] c15ce44f95da234a79d8d211b04736f008e4bded40beccfb2588dd0c83d10ff2