[INFO] updating cached repository KrishnaSannasi/game-snakes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KrishnaSannasi/game-snakes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KrishnaSannasi/game-snakes" "work/ex/clippy-test-run/sources/stable/gh/KrishnaSannasi/game-snakes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KrishnaSannasi/game-snakes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KrishnaSannasi/game-snakes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KrishnaSannasi/game-snakes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KrishnaSannasi/game-snakes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fa4594ad83e48f34e0e746df90290a0bb9e67084 [INFO] sha for GitHub repo KrishnaSannasi/game-snakes: fa4594ad83e48f34e0e746df90290a0bb9e67084 [INFO] validating manifest of KrishnaSannasi/game-snakes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KrishnaSannasi/game-snakes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KrishnaSannasi/game-snakes [INFO] finished frobbing KrishnaSannasi/game-snakes [INFO] frobbed toml for KrishnaSannasi/game-snakes written to work/ex/clippy-test-run/sources/stable/gh/KrishnaSannasi/game-snakes/Cargo.toml [INFO] started frobbing KrishnaSannasi/game-snakes [INFO] finished frobbing KrishnaSannasi/game-snakes [INFO] frobbed toml for KrishnaSannasi/game-snakes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KrishnaSannasi/game-snakes/Cargo.toml [INFO] crate KrishnaSannasi/game-snakes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting KrishnaSannasi/game-snakes against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/KrishnaSannasi/game-snakes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f7e51a17f0a162c799a00d56de0b6b63dfc226956b65a7190583bd4225fa209 [INFO] running `"docker" "start" "-a" "8f7e51a17f0a162c799a00d56de0b6b63dfc226956b65a7190583bd4225fa209"` [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling phf v0.7.22 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking piston-gfx_texture v0.30.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.47.0 [INFO] [stderr] Checking piston_window v0.74.0 [INFO] [stderr] Checking snake v0.1.5-1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | ((x as f64) * BLOCK_SIZE, (y as f64) * BLOCK_SIZE) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:31 [INFO] [stderr] | [INFO] [stderr] 7 | ((x as f64) * BLOCK_SIZE, (y as f64) * BLOCK_SIZE) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:11:7 [INFO] [stderr] | [INFO] [stderr] 11 | (((x as f64) * BLOCK_SIZE) as u32, ((y as f64) * BLOCK_SIZE) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | (((x as f64) * BLOCK_SIZE) as u32, ((y as f64) * BLOCK_SIZE) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | BLOCK_SIZE * (width as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | BLOCK_SIZE * (height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn opp(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match dir { [INFO] [stderr] 74 | | Some(d) => self.direction = d, [INFO] [stderr] 75 | | None => (), [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / match dir { [INFO] [stderr] 112 | | Some(d) => moving_dir = d, [INFO] [stderr] 113 | | None => {} [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:131:22 [INFO] [stderr] | [INFO] [stderr] 131 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/game.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if let None = self.food { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 75 | | self.add_food(); [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________- help: try this: `if self.food.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | ((x as f64) * BLOCK_SIZE, (y as f64) * BLOCK_SIZE) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:31 [INFO] [stderr] | [INFO] [stderr] 7 | ((x as f64) * BLOCK_SIZE, (y as f64) * BLOCK_SIZE) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:11:7 [INFO] [stderr] | [INFO] [stderr] 11 | (((x as f64) * BLOCK_SIZE) as u32, ((y as f64) * BLOCK_SIZE) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | (((x as f64) * BLOCK_SIZE) as u32, ((y as f64) * BLOCK_SIZE) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | BLOCK_SIZE * (width as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | BLOCK_SIZE * (height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn opp(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match dir { [INFO] [stderr] 74 | | Some(d) => self.direction = d, [INFO] [stderr] 75 | | None => (), [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / match dir { [INFO] [stderr] 112 | | Some(d) => moving_dir = d, [INFO] [stderr] 113 | | None => {} [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:131:22 [INFO] [stderr] | [INFO] [stderr] 131 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/game.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if let None = self.food { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 75 | | self.add_food(); [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________- help: try this: `if self.food.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 34s [INFO] running `"docker" "inspect" "8f7e51a17f0a162c799a00d56de0b6b63dfc226956b65a7190583bd4225fa209"` [INFO] running `"docker" "rm" "-f" "8f7e51a17f0a162c799a00d56de0b6b63dfc226956b65a7190583bd4225fa209"` [INFO] [stdout] 8f7e51a17f0a162c799a00d56de0b6b63dfc226956b65a7190583bd4225fa209