[INFO] updating cached repository Kriegslustig/ping-pong-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Kriegslustig/ping-pong-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Kriegslustig/ping-pong-rs" "work/ex/clippy-test-run/sources/stable/gh/Kriegslustig/ping-pong-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kriegslustig/ping-pong-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Kriegslustig/ping-pong-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kriegslustig/ping-pong-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kriegslustig/ping-pong-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5485b857face9016582831af832184b1d07608d5
[INFO] sha for GitHub repo Kriegslustig/ping-pong-rs: 5485b857face9016582831af832184b1d07608d5
[INFO] validating manifest of Kriegslustig/ping-pong-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Kriegslustig/ping-pong-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Kriegslustig/ping-pong-rs
[INFO] finished frobbing Kriegslustig/ping-pong-rs
[INFO] frobbed toml for Kriegslustig/ping-pong-rs written to work/ex/clippy-test-run/sources/stable/gh/Kriegslustig/ping-pong-rs/Cargo.toml
[INFO] started frobbing Kriegslustig/ping-pong-rs
[INFO] finished frobbing Kriegslustig/ping-pong-rs
[INFO] frobbed toml for Kriegslustig/ping-pong-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kriegslustig/ping-pong-rs/Cargo.toml
[INFO] crate Kriegslustig/ping-pong-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Kriegslustig/ping-pong-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kriegslustig/ping-pong-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 16d21028868ce56825e8768929b60ecd142683e623cb990ee5880fb2b12c31bd
[INFO] running `"docker" "start" "-a" "16d21028868ce56825e8768929b60ecd142683e623cb990ee5880fb2b12c31bd"`
[INFO] [stderr]     Checking ping-pong v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:58:21
[INFO] [stderr]    |
[INFO] [stderr] 58 | /                     match socket.recv(&mut res_buffer) {
[INFO] [stderr] 59 | |                         Ok(_) => {
[INFO] [stderr] 60 | |                             let res_str = str::from_utf8(&res_buffer)
[INFO] [stderr] 61 | |                                 .map_err(|_| "Unable to read packet".to_string())?;
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |                         Err(_) => {}
[INFO] [stderr] 67 | |                     };
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 58 |                     if let Ok(_) = socket.recv(&mut res_buffer) {
[INFO] [stderr] 59 |     let res_str = str::from_utf8(&res_buffer)
[INFO] [stderr] 60 |         .map_err(|_| "Unable to read packet".to_string())?;
[INFO] [stderr] 61 |     if res_str.eq(&"bye".to_string()) {
[INFO] [stderr] 62 |         break;
[INFO] [stderr] 63 |     }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/main.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |     random_file.read(&mut result_buffer).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:92:29
[INFO] [stderr]    |
[INFO] [stderr] 92 | fn printable_char_encode(n: &u8) -> u8 {
[INFO] [stderr]    |                             ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 | /     let result;
[INFO] [stderr] 95 | |     if lower_range > 9 {
[INFO] [stderr] 96 | |         result = lower_range + 7;
[INFO] [stderr] 97 | |     } else {
[INFO] [stderr] 98 | |         result = lower_range;
[INFO] [stderr] 99 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let result = if lower_range > 9 { lower_range + 7 } else { lower_range };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     let elapsed_ms;
[INFO] [stderr] 129 | |     if raw_elapsed_ms == 0 {
[INFO] [stderr] 130 | |         elapsed_ms = 1;
[INFO] [stderr] 131 | |     } else {
[INFO] [stderr] 132 | |         elapsed_ms = raw_elapsed_ms;
[INFO] [stderr] 133 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let elapsed_ms = if raw_elapsed_ms == 0 { 1 } else { raw_elapsed_ms };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:152:17
[INFO] [stderr]     |
[INFO] [stderr] 152 |                 socket.send(&bye);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:203:13
[INFO] [stderr]     |
[INFO] [stderr] 203 | /             match args.nth(0) {
[INFO] [stderr] 204 | |                 Some(ip) => remote_ip = ip.parse().unwrap(),
[INFO] [stderr] 205 | |                 None => {}
[INFO] [stderr] 206 | |             };
[INFO] [stderr]     | |_____________^ help: try this: `if let Some(ip) = args.nth(0) { remote_ip = ip.parse().unwrap() }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `ping-pong`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:58:21
[INFO] [stderr]    |
[INFO] [stderr] 58 | /                     match socket.recv(&mut res_buffer) {
[INFO] [stderr] 59 | |                         Ok(_) => {
[INFO] [stderr] 60 | |                             let res_str = str::from_utf8(&res_buffer)
[INFO] [stderr] 61 | |                                 .map_err(|_| "Unable to read packet".to_string())?;
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |                         Err(_) => {}
[INFO] [stderr] 67 | |                     };
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 58 |                     if let Ok(_) = socket.recv(&mut res_buffer) {
[INFO] [stderr] 59 |     let res_str = str::from_utf8(&res_buffer)
[INFO] [stderr] 60 |         .map_err(|_| "Unable to read packet".to_string())?;
[INFO] [stderr] 61 |     if res_str.eq(&"bye".to_string()) {
[INFO] [stderr] 62 |         break;
[INFO] [stderr] 63 |     }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/main.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |     random_file.read(&mut result_buffer).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:92:29
[INFO] [stderr]    |
[INFO] [stderr] 92 | fn printable_char_encode(n: &u8) -> u8 {
[INFO] [stderr]    |                             ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 | /     let result;
[INFO] [stderr] 95 | |     if lower_range > 9 {
[INFO] [stderr] 96 | |         result = lower_range + 7;
[INFO] [stderr] 97 | |     } else {
[INFO] [stderr] 98 | |         result = lower_range;
[INFO] [stderr] 99 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let result = if lower_range > 9 { lower_range + 7 } else { lower_range };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 | /     let elapsed_ms;
[INFO] [stderr] 129 | |     if raw_elapsed_ms == 0 {
[INFO] [stderr] 130 | |         elapsed_ms = 1;
[INFO] [stderr] 131 | |     } else {
[INFO] [stderr] 132 | |         elapsed_ms = raw_elapsed_ms;
[INFO] [stderr] 133 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let elapsed_ms = if raw_elapsed_ms == 0 { 1 } else { raw_elapsed_ms };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:152:17
[INFO] [stderr]     |
[INFO] [stderr] 152 |                 socket.send(&bye);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:203:13
[INFO] [stderr]     |
[INFO] [stderr] 203 | /             match args.nth(0) {
[INFO] [stderr] 204 | |                 Some(ip) => remote_ip = ip.parse().unwrap(),
[INFO] [stderr] 205 | |                 None => {}
[INFO] [stderr] 206 | |             };
[INFO] [stderr]     | |_____________^ help: try this: `if let Some(ip) = args.nth(0) { remote_ip = ip.parse().unwrap() }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `ping-pong`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "16d21028868ce56825e8768929b60ecd142683e623cb990ee5880fb2b12c31bd"`
[INFO] running `"docker" "rm" "-f" "16d21028868ce56825e8768929b60ecd142683e623cb990ee5880fb2b12c31bd"`
[INFO] [stdout] 16d21028868ce56825e8768929b60ecd142683e623cb990ee5880fb2b12c31bd