[INFO] updating cached repository Kranando/moving_square [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Kranando/moving_square [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Kranando/moving_square" "work/ex/clippy-test-run/sources/stable/gh/Kranando/moving_square"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kranando/moving_square'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Kranando/moving_square" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kranando/moving_square"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kranando/moving_square'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 387d3368acba9557cdd121c0b8546de7ee81b5a0 [INFO] sha for GitHub repo Kranando/moving_square: 387d3368acba9557cdd121c0b8546de7ee81b5a0 [INFO] validating manifest of Kranando/moving_square on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Kranando/moving_square on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Kranando/moving_square [INFO] finished frobbing Kranando/moving_square [INFO] frobbed toml for Kranando/moving_square written to work/ex/clippy-test-run/sources/stable/gh/Kranando/moving_square/Cargo.toml [INFO] started frobbing Kranando/moving_square [INFO] finished frobbing Kranando/moving_square [INFO] frobbed toml for Kranando/moving_square written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kranando/moving_square/Cargo.toml [INFO] crate Kranando/moving_square has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Kranando/moving_square against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kranando/moving_square:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69d08f3d4c30677c81f1b91b666cc9070a843a47b75d46c93328f198e341da5b [INFO] running `"docker" "start" "-a" "69d08f3d4c30677c81f1b91b666cc9070a843a47b75d46c93328f198e341da5b"` [INFO] [stderr] Checking cfor v1.1.0 [INFO] [stderr] Checking piston-viewport v0.4.0 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking piston-ai_behavior v0.24.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.48.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking piston2d-sprite v0.45.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.52.0 [INFO] [stderr] Checking piston_window v0.81.0 [INFO] [stderr] Checking moving_square v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `IdleArgs` [INFO] [stderr] --> src/main.rs:206:21 [INFO] [stderr] | [INFO] [stderr] 206 | if let Some(IdleArgs) = e.idle_args() { [INFO] [stderr] | ^^^^^^^^ help: consider using `_IdleArgs` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | let mut i = player_chunk_x - (self.chunk_amount_x - 1.0) / 2.0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut j = player_chunk_y - (self.chunk_amount_y - 1.0) / 2.0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tree.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | Tree {x: (i as f64) * rng.gen_range(-600.0, 600.0), y: (i as f64) * rng.gen_range(-300.0, 300.0), sprite: treeimg} [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tree.rs:20:64 [INFO] [stderr] | [INFO] [stderr] 20 | Tree {x: (i as f64) * rng.gen_range(-600.0, 600.0), y: (i as f64) * rng.gen_range(-300.0, 300.0), sprite: treeimg} [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | fn update(&mut self, upd: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:173:16 [INFO] [stderr] | [INFO] [stderr] 173 | width: width as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | height: height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:175:16 [INFO] [stderr] | [INFO] [stderr] 175 | viewx: width as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:176:16 [INFO] [stderr] | [INFO] [stderr] 176 | viewy: height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `IdleArgs` should have a snake case name such as `idle_args` [INFO] [stderr] --> src/main.rs:206:21 [INFO] [stderr] | [INFO] [stderr] 206 | if let Some(IdleArgs) = e.idle_args() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `IdleArgs` [INFO] [stderr] --> src/main.rs:206:21 [INFO] [stderr] | [INFO] [stderr] 206 | if let Some(IdleArgs) = e.idle_args() { [INFO] [stderr] | ^^^^^^^^ help: consider using `_IdleArgs` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | let mut i = player_chunk_x - (self.chunk_amount_x - 1.0) / 2.0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut j = player_chunk_y - (self.chunk_amount_y - 1.0) / 2.0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tree.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | Tree {x: (i as f64) * rng.gen_range(-600.0, 600.0), y: (i as f64) * rng.gen_range(-300.0, 300.0), sprite: treeimg} [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tree.rs:20:64 [INFO] [stderr] | [INFO] [stderr] 20 | Tree {x: (i as f64) * rng.gen_range(-600.0, 600.0), y: (i as f64) * rng.gen_range(-300.0, 300.0), sprite: treeimg} [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | fn update(&mut self, upd: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:173:16 [INFO] [stderr] | [INFO] [stderr] 173 | width: width as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | height: height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:175:16 [INFO] [stderr] | [INFO] [stderr] 175 | viewx: width as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:176:16 [INFO] [stderr] | [INFO] [stderr] 176 | viewy: height as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `IdleArgs` should have a snake case name such as `idle_args` [INFO] [stderr] --> src/main.rs:206:21 [INFO] [stderr] | [INFO] [stderr] 206 | if let Some(IdleArgs) = e.idle_args() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `"docker" "inspect" "69d08f3d4c30677c81f1b91b666cc9070a843a47b75d46c93328f198e341da5b"` [INFO] running `"docker" "rm" "-f" "69d08f3d4c30677c81f1b91b666cc9070a843a47b75d46c93328f198e341da5b"` [INFO] [stdout] 69d08f3d4c30677c81f1b91b666cc9070a843a47b75d46c93328f198e341da5b