[INFO] updating cached repository KonishchevDmitry/pyvsb-to-cloud [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KonishchevDmitry/pyvsb-to-cloud [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KonishchevDmitry/pyvsb-to-cloud" "work/ex/clippy-test-run/sources/stable/gh/KonishchevDmitry/pyvsb-to-cloud"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KonishchevDmitry/pyvsb-to-cloud'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KonishchevDmitry/pyvsb-to-cloud" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KonishchevDmitry/pyvsb-to-cloud"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KonishchevDmitry/pyvsb-to-cloud'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 707de2654c7715f4f9e9415114ad1b1b5dca810e [INFO] sha for GitHub repo KonishchevDmitry/pyvsb-to-cloud: 707de2654c7715f4f9e9415114ad1b1b5dca810e [INFO] validating manifest of KonishchevDmitry/pyvsb-to-cloud on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KonishchevDmitry/pyvsb-to-cloud on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KonishchevDmitry/pyvsb-to-cloud [INFO] finished frobbing KonishchevDmitry/pyvsb-to-cloud [INFO] frobbed toml for KonishchevDmitry/pyvsb-to-cloud written to work/ex/clippy-test-run/sources/stable/gh/KonishchevDmitry/pyvsb-to-cloud/Cargo.toml [INFO] started frobbing KonishchevDmitry/pyvsb-to-cloud [INFO] finished frobbing KonishchevDmitry/pyvsb-to-cloud [INFO] frobbed toml for KonishchevDmitry/pyvsb-to-cloud written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KonishchevDmitry/pyvsb-to-cloud/Cargo.toml [INFO] crate KonishchevDmitry/pyvsb-to-cloud has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting KonishchevDmitry/pyvsb-to-cloud against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/KonishchevDmitry/pyvsb-to-cloud:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca19e568b4dc3023b11675c33c33282725d23dfba58aac4aa8ae6d97e1cfffe8 [INFO] running `"docker" "start" "-a" "ca19e568b4dc3023b11675c33c33282725d23dfba58aac4aa8ae6d97e1cfffe8"` [INFO] [stderr] Checking fern v0.5.7 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking md-5 v0.8.0 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking tar v0.4.20 [INFO] [stderr] Checking easy-logging v0.1.0 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking pyvsb-to-cloud v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encryptor.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | available_size: available_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_client/request.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_client/request.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_client/mod.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_client/mod.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/dropbox.rs:124:21 [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encryptor.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hash.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | available_size: available_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_client/request.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_client/request.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_client/mod.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_client/mod.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/dropbox.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/dropbox.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/dropbox.rs:241:33 [INFO] [stderr] | [INFO] [stderr] 241 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/dropbox.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/google_drive/mod.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | mime_type: mime_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mime_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/google_drive/mod.rs:378:29 [INFO] [stderr] | [INFO] [stderr] 378 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:24:57 [INFO] [stderr] | [INFO] [stderr] 24 | provider: Box::new(ReadWriteProviderAdapter{provider: provider}), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:31:56 [INFO] [stderr] | [INFO] [stderr] 31 | provider: Box::new(ReadOnlyProviderAdapter{provider: provider}), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 124 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/dropbox.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/dropbox.rs:241:33 [INFO] [stderr] | [INFO] [stderr] 241 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/dropbox.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/google_drive/mod.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | mime_type: mime_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mime_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/providers/google_drive/mod.rs:378:29 [INFO] [stderr] | [INFO] [stderr] 378 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:24:57 [INFO] [stderr] | [INFO] [stderr] 24 | provider: Box::new(ReadWriteProviderAdapter{provider: provider}), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/storage.rs:31:56 [INFO] [stderr] | [INFO] [stderr] 31 | provider: Box::new(ReadOnlyProviderAdapter{provider: provider}), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `provider` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http_client/readers.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return response.status.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `response.status.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/dropbox.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const API_ENDPOINT: &'static str = "https://api.dropboxapi.com/2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/dropbox.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | const CONTENT_ENDPOINT: &'static str = "https://content.dropboxapi.com/2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/google_drive/oauth.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | const API_ENDPOINT: &'static str = "https://accounts.google.com/o/oauth2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/google_drive/mod.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | const API_ENDPOINT: &'static str = "https://www.googleapis.com/drive/v3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/google_drive/mod.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | const UPLOAD_ENDPOINT: &'static str = "https://www.googleapis.com/upload/drive/v3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/providers/google_drive/mod.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return Ok((parent.id, name, file_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((parent.id, name, file_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/google_drive/mod.rs:404:29 [INFO] [stderr] | [INFO] [stderr] 404 | const DIRECTORY_MIME_TYPE: &'static str = "application/vnd.google-apps.folder"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http_client/readers.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return response.status.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `response.status.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/dropbox.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const API_ENDPOINT: &'static str = "https://api.dropboxapi.com/2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/dropbox.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | const CONTENT_ENDPOINT: &'static str = "https://content.dropboxapi.com/2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/google_drive/oauth.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | const API_ENDPOINT: &'static str = "https://accounts.google.com/o/oauth2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/google_drive/mod.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | const API_ENDPOINT: &'static str = "https://www.googleapis.com/drive/v3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/google_drive/mod.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | const UPLOAD_ENDPOINT: &'static str = "https://www.googleapis.com/upload/drive/v3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/providers/google_drive/mod.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return Ok((parent.id, name, file_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((parent.id, name, file_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/providers/google_drive/mod.rs:404:29 [INFO] [stderr] | [INFO] [stderr] 404 | const DIRECTORY_MIME_TYPE: &'static str = "application/vnd.google-apps.folder"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:118:12 [INFO] [stderr] | [INFO] [stderr] 118 | if backup.encryption_passphrase.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `backup.encryption_passphrase.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:128:8 [INFO] [stderr] | [INFO] [stderr] 128 | if name.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:183:49 [INFO] [stderr] | [INFO] [stderr] 183 | let captures = DURATION_RE.captures(string).ok_or(format!( [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 184 | | "Invalid time duration specification: {:?}", string))?; [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 183 | let captures = DURATION_RE.captures(string).ok_or_else(|| format!( [INFO] [stderr] 184 | "Invalid time duration specification: {:?}", string))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/http_client/mod.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | if headers.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:118:12 [INFO] [stderr] | [INFO] [stderr] 118 | if backup.encryption_passphrase.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `backup.encryption_passphrase.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:128:8 [INFO] [stderr] | [INFO] [stderr] 128 | if name.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:183:49 [INFO] [stderr] | [INFO] [stderr] 183 | let captures = DURATION_RE.captures(string).ok_or(format!( [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 184 | | "Invalid time duration specification: {:?}", string))?; [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 183 | let captures = DURATION_RE.captures(string).ok_or_else(|| format!( [INFO] [stderr] 184 | "Invalid time duration specification: {:?}", string))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/http_client/mod.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | if headers.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/storage.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | if first_backup_name.split("-").next().unwrap() != group_name { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/storage.rs:153:22 [INFO] [stderr] | [INFO] [stderr] 153 | let prefix = match temporary { [INFO] [stderr] | ______________________^ [INFO] [stderr] 154 | | true => ".", [INFO] [stderr] 155 | | false => "", [INFO] [stderr] 156 | | }.to_owned(); [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if temporary { "." } else { "" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/storage.rs:298:40 [INFO] [stderr] | [INFO] [stderr] 298 | let mut parts = line.splitn(4, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/storage.rs:335:20 [INFO] [stderr] | [INFO] [stderr] 335 | return Err(archive.into_inner().unwrap().finish(Some(err.to_string())).unwrap_err().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `archive.into_inner().unwrap().finish(Some(err.to_string())).unwrap_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/storage.rs:339:20 [INFO] [stderr] | [INFO] [stderr] 339 | return Err(archive.into_inner().unwrap().finish(Some(err.to_string())).unwrap_err().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `archive.into_inner().unwrap().finish(Some(err.to_string())).unwrap_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/stream_splitter.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(splitter(data_stream, streams_tx, stream_max_size)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 39 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/stream_splitter.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if let Ok(_) = data_stream.recv() { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 115 | | return Err(StreamSplitterError("Got a message after a termination message")) [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____- help: try this: `if data_stream.recv().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/storage.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | if first_backup_name.split("-").next().unwrap() != group_name { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/storage.rs:153:22 [INFO] [stderr] | [INFO] [stderr] 153 | let prefix = match temporary { [INFO] [stderr] | ______________________^ [INFO] [stderr] 154 | | true => ".", [INFO] [stderr] 155 | | false => "", [INFO] [stderr] 156 | | }.to_owned(); [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if temporary { "." } else { "" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/storage.rs:298:40 [INFO] [stderr] | [INFO] [stderr] 298 | let mut parts = line.splitn(4, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/storage.rs:335:20 [INFO] [stderr] | [INFO] [stderr] 335 | return Err(archive.into_inner().unwrap().finish(Some(err.to_string())).unwrap_err().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `archive.into_inner().unwrap().finish(Some(err.to_string())).unwrap_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/storage.rs:339:20 [INFO] [stderr] | [INFO] [stderr] 339 | return Err(archive.into_inner().unwrap().finish(Some(err.to_string())).unwrap_err().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `archive.into_inner().unwrap().finish(Some(err.to_string())).unwrap_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/stream_splitter.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(splitter(data_stream, streams_tx, stream_max_size)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 39 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/stream_splitter.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if let Ok(_) = data_stream.recv() { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 115 | | return Err(StreamSplitterError("Got a message after a termination message")) [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____- help: try this: `if data_stream.recv().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.81s [INFO] running `"docker" "inspect" "ca19e568b4dc3023b11675c33c33282725d23dfba58aac4aa8ae6d97e1cfffe8"` [INFO] running `"docker" "rm" "-f" "ca19e568b4dc3023b11675c33c33282725d23dfba58aac4aa8ae6d97e1cfffe8"` [INFO] [stdout] ca19e568b4dc3023b11675c33c33282725d23dfba58aac4aa8ae6d97e1cfffe8