[INFO] updating cached repository Kollode/rustpass [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Kollode/rustpass [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Kollode/rustpass" "work/ex/clippy-test-run/sources/stable/gh/Kollode/rustpass"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kollode/rustpass'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Kollode/rustpass" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kollode/rustpass"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kollode/rustpass'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6192ce4e8003c8c86329c5963be3940577b97578 [INFO] sha for GitHub repo Kollode/rustpass: 6192ce4e8003c8c86329c5963be3940577b97578 [INFO] validating manifest of Kollode/rustpass on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Kollode/rustpass on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Kollode/rustpass [INFO] finished frobbing Kollode/rustpass [INFO] frobbed toml for Kollode/rustpass written to work/ex/clippy-test-run/sources/stable/gh/Kollode/rustpass/Cargo.toml [INFO] started frobbing Kollode/rustpass [INFO] finished frobbing Kollode/rustpass [INFO] frobbed toml for Kollode/rustpass written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kollode/rustpass/Cargo.toml [INFO] crate Kollode/rustpass has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Kollode/rustpass against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kollode/rustpass:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac652f2b37b775c7ef8cdca81acd0ab81fdb391a2f18651def4f25ae3b6d1e3a [INFO] running `"docker" "start" "-a" "ac652f2b37b775c7ef8cdca81acd0ab81fdb391a2f18651def4f25ae3b6d1e3a"` [INFO] [stderr] Checking rpassword v1.0.2 [INFO] [stderr] Checking rustpass v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `crypto::aes::ecb_encryptor` [INFO] [stderr] --> src/kdbx/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use crypto::aes::ecb_encryptor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `crypto::aes::KeySize` [INFO] [stderr] --> src/kdbx/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use crypto::aes::KeySize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crypto::blockmodes::NoPadding` [INFO] [stderr] --> src/kdbx/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use crypto::blockmodes::NoPadding; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `RefReadBuffer`, `RefWriteBuffer` [INFO] [stderr] --> src/kdbx/mod.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | use crypto::buffer::{RefReadBuffer, RefWriteBuffer}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdbx/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return transformed_key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `transformed_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `transformed_key` [INFO] [stderr] --> src/kdbx/mod.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | let transformed_key = header.transformed_key(composite_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_transformed_key` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `encrypted_payload` [INFO] [stderr] --> src/kdbx/mod.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | fn get_payload(encrypted_payload: &[u8], header: &Header, password: &str) -> Result, DatabaseError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_encrypted_payload` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/kdbx/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let mut transformed_key = composite_key; [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/kdbx/mod.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | _ => panic!("Type '{}' is unknown"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / let password: String; [INFO] [stderr] 46 | | [INFO] [stderr] 47 | | if matches.value_of("password").is_some() { [INFO] [stderr] 48 | | password = String::from(matches.value_of("password").unwrap()); [INFO] [stderr] 49 | | }else { [INFO] [stderr] 50 | | password = rpassword::prompt_password_stdout("Password: ").unwrap(); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let password = if matches.value_of("password").is_some() { String::from(matches.value_of("password").unwrap()) } else { rpassword::prompt_password_stdout("Password: ").unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused import: `crypto::aes::ecb_encryptor` [INFO] [stderr] --> src/kdbx/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use crypto::aes::ecb_encryptor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `crypto::aes::KeySize` [INFO] [stderr] --> src/kdbx/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use crypto::aes::KeySize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crypto::blockmodes::NoPadding` [INFO] [stderr] --> src/kdbx/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use crypto::blockmodes::NoPadding; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `RefReadBuffer`, `RefWriteBuffer` [INFO] [stderr] --> src/kdbx/mod.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | use crypto::buffer::{RefReadBuffer, RefWriteBuffer}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdbx/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return transformed_key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `transformed_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `transformed_key` [INFO] [stderr] --> src/kdbx/mod.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | let transformed_key = header.transformed_key(composite_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_transformed_key` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `encrypted_payload` [INFO] [stderr] --> src/kdbx/mod.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | fn get_payload(encrypted_payload: &[u8], header: &Header, password: &str) -> Result, DatabaseError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_encrypted_payload` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/kdbx/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let mut transformed_key = composite_key; [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/kdbx/mod.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | _ => panic!("Type '{}' is unknown"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / let password: String; [INFO] [stderr] 46 | | [INFO] [stderr] 47 | | if matches.value_of("password").is_some() { [INFO] [stderr] 48 | | password = String::from(matches.value_of("password").unwrap()); [INFO] [stderr] 49 | | }else { [INFO] [stderr] 50 | | password = rpassword::prompt_password_stdout("Password: ").unwrap(); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let password = if matches.value_of("password").is_some() { String::from(matches.value_of("password").unwrap()) } else { rpassword::prompt_password_stdout("Password: ").unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.31s [INFO] running `"docker" "inspect" "ac652f2b37b775c7ef8cdca81acd0ab81fdb391a2f18651def4f25ae3b6d1e3a"` [INFO] running `"docker" "rm" "-f" "ac652f2b37b775c7ef8cdca81acd0ab81fdb391a2f18651def4f25ae3b6d1e3a"` [INFO] [stdout] ac652f2b37b775c7ef8cdca81acd0ab81fdb391a2f18651def4f25ae3b6d1e3a