[INFO] updating cached repository KoharaKazuya/forest [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KoharaKazuya/forest [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KoharaKazuya/forest" "work/ex/clippy-test-run/sources/stable/gh/KoharaKazuya/forest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KoharaKazuya/forest'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KoharaKazuya/forest" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KoharaKazuya/forest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KoharaKazuya/forest'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0f2ae009c6092d49bed24efcf1a261fdd4e8a7fe [INFO] sha for GitHub repo KoharaKazuya/forest: 0f2ae009c6092d49bed24efcf1a261fdd4e8a7fe [INFO] validating manifest of KoharaKazuya/forest on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KoharaKazuya/forest on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KoharaKazuya/forest [INFO] finished frobbing KoharaKazuya/forest [INFO] frobbed toml for KoharaKazuya/forest written to work/ex/clippy-test-run/sources/stable/gh/KoharaKazuya/forest/Cargo.toml [INFO] started frobbing KoharaKazuya/forest [INFO] finished frobbing KoharaKazuya/forest [INFO] frobbed toml for KoharaKazuya/forest written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KoharaKazuya/forest/Cargo.toml [INFO] crate KoharaKazuya/forest has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting KoharaKazuya/forest against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/KoharaKazuya/forest:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47b70e3eb3504540daedafc79c0b7dd2d7782a4b0ba4ae6f9cf1bb7913d06c52 [INFO] running `"docker" "start" "-a" "47b70e3eb3504540daedafc79c0b7dd2d7782a4b0ba4ae6f9cf1bb7913d06c52"` [INFO] [stderr] Checking forest v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree_formatter.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tree_formatter.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | write!(self.writer, "{}{}\n", ng, entry.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree_formatter.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tree_formatter.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | write!(self.writer, "{}{}\n", ng, entry.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree_buider.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | while self.ancestors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ancestors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree_buider.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | while self.ancestors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ancestors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tree_formatter.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / write!(self.writer, "{}", match *shape { [INFO] [stderr] 29 | | Shape::Open => &self.ancestor_guide_open, [INFO] [stderr] 30 | | Shape::Close => &self.ancestor_guide_close, [INFO] [stderr] 31 | | _ => panic!("Unexpected Internal Value\nPerhaps, internal logic error...\nformatter can treat with only Open/Close Shape"), [INFO] [stderr] 32 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tree_formatter.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | write!(self.writer, "{}{}\n", ng, entry.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match r { [INFO] [stderr] 13 | | Ok(line) => builder.append(&line), [INFO] [stderr] 14 | | _ => () [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(line) = r { builder.append(&line) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tree_formatter.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / write!(self.writer, "{}", match *shape { [INFO] [stderr] 29 | | Shape::Open => &self.ancestor_guide_open, [INFO] [stderr] 30 | | Shape::Close => &self.ancestor_guide_close, [INFO] [stderr] 31 | | _ => panic!("Unexpected Internal Value\nPerhaps, internal logic error...\nformatter can treat with only Open/Close Shape"), [INFO] [stderr] 32 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tree_formatter.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | write!(self.writer, "{}{}\n", ng, entry.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match r { [INFO] [stderr] 13 | | Ok(line) => builder.append(&line), [INFO] [stderr] 14 | | _ => () [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(line) = r { builder.append(&line) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.09s [INFO] running `"docker" "inspect" "47b70e3eb3504540daedafc79c0b7dd2d7782a4b0ba4ae6f9cf1bb7913d06c52"` [INFO] running `"docker" "rm" "-f" "47b70e3eb3504540daedafc79c0b7dd2d7782a4b0ba4ae6f9cf1bb7913d06c52"` [INFO] [stdout] 47b70e3eb3504540daedafc79c0b7dd2d7782a4b0ba4ae6f9cf1bb7913d06c52