[INFO] updating cached repository Kixunil/multi_currency [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Kixunil/multi_currency [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Kixunil/multi_currency" "work/ex/clippy-test-run/sources/stable/gh/Kixunil/multi_currency"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kixunil/multi_currency'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Kixunil/multi_currency" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kixunil/multi_currency"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kixunil/multi_currency'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bcd9d1fd38f9e827681053bfae797434c19c9796 [INFO] sha for GitHub repo Kixunil/multi_currency: bcd9d1fd38f9e827681053bfae797434c19c9796 [INFO] validating manifest of Kixunil/multi_currency on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Kixunil/multi_currency on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Kixunil/multi_currency [INFO] finished frobbing Kixunil/multi_currency [INFO] frobbed toml for Kixunil/multi_currency written to work/ex/clippy-test-run/sources/stable/gh/Kixunil/multi_currency/Cargo.toml [INFO] started frobbing Kixunil/multi_currency [INFO] finished frobbing Kixunil/multi_currency [INFO] frobbed toml for Kixunil/multi_currency written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kixunil/multi_currency/Cargo.toml [INFO] crate Kixunil/multi_currency has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Kixunil/multi_currency against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kixunil/multi_currency:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08966084a283bb4cce5341c1786b4738f25df069322c49c886bc03a9adc5a0d1 [INFO] running `"docker" "start" "-a" "08966084a283bb4cce5341c1786b4738f25df069322c49c886bc03a9adc5a0d1"` [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking multi_currency v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | amount * self.map.get(&(currency, target)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&(currency, target)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:119:22 [INFO] [stderr] | [INFO] [stderr] 119 | amount / self.map.get(&(target, currency)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&(target, currency)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / price [INFO] [stderr] 183 | | .as_ref() [INFO] [stderr] 184 | | .map(|price| price_map.update(pair.accounting_currency.clone(), pair.price_of.clone(), price.new_price)); [INFO] [stderr] | |____________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 182 | if let Some(price) = price [INFO] [stderr] 183 | .as_ref() { price_map.update(pair.accounting_currency.clone(), pair.price_of.clone(), price.new_price) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | amount * self.map.get(&(currency, target)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&(currency, target)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:119:22 [INFO] [stderr] | [INFO] [stderr] 119 | amount / self.map.get(&(target, currency)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[&(target, currency)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / price [INFO] [stderr] 183 | | .as_ref() [INFO] [stderr] 184 | | .map(|price| price_map.update(pair.accounting_currency.clone(), pair.price_of.clone(), price.new_price)); [INFO] [stderr] | |____________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 182 | if let Some(price) = price [INFO] [stderr] 183 | .as_ref() { price_map.update(pair.accounting_currency.clone(), pair.price_of.clone(), price.new_price) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.15s [INFO] running `"docker" "inspect" "08966084a283bb4cce5341c1786b4738f25df069322c49c886bc03a9adc5a0d1"` [INFO] running `"docker" "rm" "-f" "08966084a283bb4cce5341c1786b4738f25df069322c49c886bc03a9adc5a0d1"` [INFO] [stdout] 08966084a283bb4cce5341c1786b4738f25df069322c49c886bc03a9adc5a0d1