[INFO] updating cached repository Kirszu/RustCipherMachine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Kirszu/RustCipherMachine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Kirszu/RustCipherMachine" "work/ex/clippy-test-run/sources/stable/gh/Kirszu/RustCipherMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kirszu/RustCipherMachine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Kirszu/RustCipherMachine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kirszu/RustCipherMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kirszu/RustCipherMachine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d786736dd1f9bc9874a04ccc86235553ac6a2b7 [INFO] sha for GitHub repo Kirszu/RustCipherMachine: 1d786736dd1f9bc9874a04ccc86235553ac6a2b7 [INFO] validating manifest of Kirszu/RustCipherMachine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Kirszu/RustCipherMachine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Kirszu/RustCipherMachine [INFO] finished frobbing Kirszu/RustCipherMachine [INFO] frobbed toml for Kirszu/RustCipherMachine written to work/ex/clippy-test-run/sources/stable/gh/Kirszu/RustCipherMachine/Cargo.toml [INFO] started frobbing Kirszu/RustCipherMachine [INFO] finished frobbing Kirszu/RustCipherMachine [INFO] frobbed toml for Kirszu/RustCipherMachine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kirszu/RustCipherMachine/Cargo.toml [INFO] crate Kirszu/RustCipherMachine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Kirszu/RustCipherMachine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kirszu/RustCipherMachine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a265dc18123e5b552dfe4fafc6272f594068e569f93138924590aaceca1f8fe4 [INFO] running `"docker" "start" "-a" "a265dc18123e5b552dfe4fafc6272f594068e569f93138924590aaceca1f8fe4"` [INFO] [stderr] Checking cypher_machine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:316:5 [INFO] [stderr] | [INFO] [stderr] 316 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | let mut x = byte as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | let mut x = byte as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:260:26 [INFO] [stderr] | [INFO] [stderr] 260 | let mut x: i32 = chars as i32 + chars_key_full[temp] as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(chars)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:260:41 [INFO] [stderr] | [INFO] [stderr] 260 | let mut x: i32 = chars as i32 + chars_key_full[temp] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(chars_key_full[temp])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:26 [INFO] [stderr] | [INFO] [stderr] 298 | let mut x: i32 = chars as i32 - chars_key_full[temp] as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(chars)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:41 [INFO] [stderr] | [INFO] [stderr] 298 | let mut x: i32 = chars as i32 - chars_key_full[temp] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(chars_key_full[temp])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:299:9 [INFO] [stderr] | [INFO] [stderr] 299 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:316:5 [INFO] [stderr] | [INFO] [stderr] 316 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | let mut x = byte as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | let mut x = byte as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:260:26 [INFO] [stderr] | [INFO] [stderr] 260 | let mut x: i32 = chars as i32 + chars_key_full[temp] as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(chars)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:260:41 [INFO] [stderr] | [INFO] [stderr] 260 | let mut x: i32 = chars as i32 + chars_key_full[temp] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(chars_key_full[temp])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:26 [INFO] [stderr] | [INFO] [stderr] 298 | let mut x: i32 = chars as i32 - chars_key_full[temp] as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(chars)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:298:41 [INFO] [stderr] | [INFO] [stderr] 298 | let mut x: i32 = chars as i32 - chars_key_full[temp] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(chars_key_full[temp])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:299:9 [INFO] [stderr] | [INFO] [stderr] 299 | temp = temp + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `temp += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "a265dc18123e5b552dfe4fafc6272f594068e569f93138924590aaceca1f8fe4"` [INFO] running `"docker" "rm" "-f" "a265dc18123e5b552dfe4fafc6272f594068e569f93138924590aaceca1f8fe4"` [INFO] [stdout] a265dc18123e5b552dfe4fafc6272f594068e569f93138924590aaceca1f8fe4