[INFO] updating cached repository KeyboardFire/xkcd1537-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KeyboardFire/xkcd1537-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KeyboardFire/xkcd1537-rust" "work/ex/clippy-test-run/sources/stable/gh/KeyboardFire/xkcd1537-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KeyboardFire/xkcd1537-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KeyboardFire/xkcd1537-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KeyboardFire/xkcd1537-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KeyboardFire/xkcd1537-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 54c82318d7c0ca798ced908cc6d76ce19d1f23e1 [INFO] sha for GitHub repo KeyboardFire/xkcd1537-rust: 54c82318d7c0ca798ced908cc6d76ce19d1f23e1 [INFO] validating manifest of KeyboardFire/xkcd1537-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KeyboardFire/xkcd1537-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KeyboardFire/xkcd1537-rust [INFO] finished frobbing KeyboardFire/xkcd1537-rust [INFO] frobbed toml for KeyboardFire/xkcd1537-rust written to work/ex/clippy-test-run/sources/stable/gh/KeyboardFire/xkcd1537-rust/Cargo.toml [INFO] started frobbing KeyboardFire/xkcd1537-rust [INFO] finished frobbing KeyboardFire/xkcd1537-rust [INFO] frobbed toml for KeyboardFire/xkcd1537-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KeyboardFire/xkcd1537-rust/Cargo.toml [INFO] crate KeyboardFire/xkcd1537-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting KeyboardFire/xkcd1537-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/KeyboardFire/xkcd1537-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1376573d1f14acaae34887202a61d60f93139d025a4efa7d6e27f680c68a91b8 [INFO] running `"docker" "start" "-a" "1376573d1f14acaae34887202a61d60f93139d025a4efa7d6e27f680c68a91b8"` [INFO] [stderr] Checking xkcd1537 v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/main.rs:239:45 [INFO] [stderr] | [INFO] [stderr] 239 | Token::XFunction(Function::Wrap(n)) => { }, [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `XArray` [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | XArray(Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `exec_rpn` [INFO] [stderr] --> src/main.rs:227:1 [INFO] [stderr] | [INFO] [stderr] 227 | fn exec_rpn(rpn: Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:176:34 [INFO] [stderr] | [INFO] [stderr] 176 | Some(&ref x) => Some(x), [INFO] [stderr] | ^^^^^^ help: try removing the `&ref` part and just keep: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:181:32 [INFO] [stderr] | [INFO] [stderr] 181 | if let Some(_) = match opstack.last() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if match opstack.last() { [INFO] [stderr] 182 | Some(&Token::XFunction(ref f)) => Some(f), [INFO] [stderr] 183 | _ => None [INFO] [stderr] 184 | }.is_some() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:195:34 [INFO] [stderr] | [INFO] [stderr] 195 | Some(&ref x) => Some(x), [INFO] [stderr] | ^^^^^^ help: try removing the `&ref` part and just keep: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/main.rs:239:45 [INFO] [stderr] | [INFO] [stderr] 239 | Token::XFunction(Function::Wrap(n)) => { }, [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `XArray` [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | XArray(Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `exec_rpn` [INFO] [stderr] --> src/main.rs:227:1 [INFO] [stderr] | [INFO] [stderr] 227 | fn exec_rpn(rpn: Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:176:34 [INFO] [stderr] | [INFO] [stderr] 176 | Some(&ref x) => Some(x), [INFO] [stderr] | ^^^^^^ help: try removing the `&ref` part and just keep: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:181:32 [INFO] [stderr] | [INFO] [stderr] 181 | if let Some(_) = match opstack.last() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if match opstack.last() { [INFO] [stderr] 182 | Some(&Token::XFunction(ref f)) => Some(f), [INFO] [stderr] 183 | _ => None [INFO] [stderr] 184 | }.is_some() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/main.rs:195:34 [INFO] [stderr] | [INFO] [stderr] 195 | Some(&ref x) => Some(x), [INFO] [stderr] | ^^^^^^ help: try removing the `&ref` part and just keep: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "1376573d1f14acaae34887202a61d60f93139d025a4efa7d6e27f680c68a91b8"` [INFO] running `"docker" "rm" "-f" "1376573d1f14acaae34887202a61d60f93139d025a4efa7d6e27f680c68a91b8"` [INFO] [stdout] 1376573d1f14acaae34887202a61d60f93139d025a4efa7d6e27f680c68a91b8