[INFO] updating cached repository Kerollmops/cargo-distant [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Kerollmops/cargo-distant [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Kerollmops/cargo-distant" "work/ex/clippy-test-run/sources/stable/gh/Kerollmops/cargo-distant"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kerollmops/cargo-distant'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Kerollmops/cargo-distant" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kerollmops/cargo-distant"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kerollmops/cargo-distant'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 56776e24fc543e5dfaad885152fe6ffc1e2544b8 [INFO] sha for GitHub repo Kerollmops/cargo-distant: 56776e24fc543e5dfaad885152fe6ffc1e2544b8 [INFO] validating manifest of Kerollmops/cargo-distant on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Kerollmops/cargo-distant on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Kerollmops/cargo-distant [INFO] finished frobbing Kerollmops/cargo-distant [INFO] frobbed toml for Kerollmops/cargo-distant written to work/ex/clippy-test-run/sources/stable/gh/Kerollmops/cargo-distant/Cargo.toml [INFO] started frobbing Kerollmops/cargo-distant [INFO] finished frobbing Kerollmops/cargo-distant [INFO] frobbed toml for Kerollmops/cargo-distant written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kerollmops/cargo-distant/Cargo.toml [INFO] crate Kerollmops/cargo-distant has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Kerollmops/cargo-distant against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kerollmops/cargo-distant:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d2cf96f453e70dd5445bfd8586c3f0ef97d527c2b812ab1e335e9822c54279a [INFO] running `"docker" "start" "-a" "7d2cf96f453e70dd5445bfd8586c3f0ef97d527c2b812ab1e335e9822c54279a"` [INFO] [stderr] Checking welder v0.3.0 [INFO] [stderr] Compiling structopt-derive v0.2.0 [INFO] [stderr] Checking structopt v0.2.0 [INFO] [stderr] Checking cargo-distant v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | Err(err) => panic!("Whoops no hostname found"), [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | Err(err) => format!("$HOME/.cargo/bin/rustup run {} cargo", self.toolchain).into(), [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | Err(err) => format!("$HOME/.cargo/bin/rustup run {} cargo", self.toolchain).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("$HOME/.cargo/bin/rustup run {} cargo", self.toolchain)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:177:28 [INFO] [stderr] | [INFO] [stderr] 177 | .unwrap_or("xxx".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "xxx".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | matches.execute(pwd, build_args); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | Err(err) => panic!("Whoops no hostname found"), [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/main.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | Err(err) => format!("$HOME/.cargo/bin/rustup run {} cargo", self.toolchain).into(), [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | Err(err) => format!("$HOME/.cargo/bin/rustup run {} cargo", self.toolchain).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("$HOME/.cargo/bin/rustup run {} cargo", self.toolchain)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:177:28 [INFO] [stderr] | [INFO] [stderr] 177 | .unwrap_or("xxx".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "xxx".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | matches.execute(pwd, build_args); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.33s [INFO] running `"docker" "inspect" "7d2cf96f453e70dd5445bfd8586c3f0ef97d527c2b812ab1e335e9822c54279a"` [INFO] running `"docker" "rm" "-f" "7d2cf96f453e70dd5445bfd8586c3f0ef97d527c2b812ab1e335e9822c54279a"` [INFO] [stdout] 7d2cf96f453e70dd5445bfd8586c3f0ef97d527c2b812ab1e335e9822c54279a