[INFO] updating cached repository KellanMebane/flappy
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/KellanMebane/flappy
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/KellanMebane/flappy" "work/ex/clippy-test-run/sources/stable/gh/KellanMebane/flappy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KellanMebane/flappy'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/KellanMebane/flappy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KellanMebane/flappy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KellanMebane/flappy'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2963233399d391ca4111f41c54a187b86466d504
[INFO] sha for GitHub repo KellanMebane/flappy: 2963233399d391ca4111f41c54a187b86466d504
[INFO] validating manifest of KellanMebane/flappy on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of KellanMebane/flappy on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing KellanMebane/flappy
[INFO] finished frobbing KellanMebane/flappy
[INFO] frobbed toml for KellanMebane/flappy written to work/ex/clippy-test-run/sources/stable/gh/KellanMebane/flappy/Cargo.toml
[INFO] started frobbing KellanMebane/flappy
[INFO] finished frobbing KellanMebane/flappy
[INFO] frobbed toml for KellanMebane/flappy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KellanMebane/flappy/Cargo.toml
[INFO] crate KellanMebane/flappy has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting KellanMebane/flappy against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/KellanMebane/flappy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] acb3563e268457e85d6224d3d8e41051861c935145cdff46be71ff4d2d5cd0a9
[INFO] running `"docker" "start" "-a" "acb3563e268457e85d6224d3d8e41051861c935145cdff46be71ff4d2d5cd0a9"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] [stderr]     Checking andrew v0.1.4
[INFO] [stderr]     Checking gfx v0.17.1
[INFO] [stderr]     Checking image v0.20.1
[INFO] [stderr]     Checking gfx_device_gl v0.15.3
[INFO] [stderr]     Checking pistoncore-event_loop v0.39.0
[INFO] [stderr]     Checking smithay-client-toolkit v0.4.2
[INFO] [stderr]     Checking piston v0.39.0
[INFO] [stderr]     Checking winit v0.18.0
[INFO] [stderr]     Checking piston-gfx_texture v0.34.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.57.0
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.54.0
[INFO] [stderr]     Checking glutin v0.19.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.51.1
[INFO] [stderr]     Checking piston_window v0.85.0
[INFO] [stderr]     Checking pacman v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:73:32
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 |         self.y = self.y - (self.velocity * args.dt);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y -= (self.velocity * args.dt)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/main.rs:109:16
[INFO] [stderr]     |
[INFO] [stderr] 109 |             if self.over == true {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.over`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/main.rs:124:16
[INFO] [stderr]     |
[INFO] [stderr] 124 |             if self.over == true {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.over`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]    --> src/main.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 | /     fn collision(
[INFO] [stderr] 153 | |         &self,
[INFO] [stderr] 154 | |         lx: f64,
[INFO] [stderr] 155 | |         lxu: f64,
[INFO] [stderr] ...   |
[INFO] [stderr] 167 | |         false
[INFO] [stderr] 168 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:73:32
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 |         self.y = self.y - (self.velocity * args.dt);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y -= (self.velocity * args.dt)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/main.rs:109:16
[INFO] [stderr]     |
[INFO] [stderr] 109 |             if self.over == true {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.over`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/main.rs:124:16
[INFO] [stderr]     |
[INFO] [stderr] 124 |             if self.over == true {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.over`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]    --> src/main.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 | /     fn collision(
[INFO] [stderr] 153 | |         &self,
[INFO] [stderr] 154 | |         lx: f64,
[INFO] [stderr] 155 | |         lxu: f64,
[INFO] [stderr] ...   |
[INFO] [stderr] 167 | |         false
[INFO] [stderr] 168 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 35.91s
[INFO] running `"docker" "inspect" "acb3563e268457e85d6224d3d8e41051861c935145cdff46be71ff4d2d5cd0a9"`
[INFO] running `"docker" "rm" "-f" "acb3563e268457e85d6224d3d8e41051861c935145cdff46be71ff4d2d5cd0a9"`
[INFO] [stdout] acb3563e268457e85d6224d3d8e41051861c935145cdff46be71ff4d2d5cd0a9