[INFO] updating cached repository KeisukeYamashita/vasp-utils [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KeisukeYamashita/vasp-utils [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KeisukeYamashita/vasp-utils" "work/ex/clippy-test-run/sources/stable/gh/KeisukeYamashita/vasp-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KeisukeYamashita/vasp-utils'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KeisukeYamashita/vasp-utils" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KeisukeYamashita/vasp-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KeisukeYamashita/vasp-utils'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c5a060866d17eee044181896b14f30ea3ba9ab7b [INFO] sha for GitHub repo KeisukeYamashita/vasp-utils: c5a060866d17eee044181896b14f30ea3ba9ab7b [INFO] validating manifest of KeisukeYamashita/vasp-utils on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KeisukeYamashita/vasp-utils on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KeisukeYamashita/vasp-utils [INFO] finished frobbing KeisukeYamashita/vasp-utils [INFO] frobbed toml for KeisukeYamashita/vasp-utils written to work/ex/clippy-test-run/sources/stable/gh/KeisukeYamashita/vasp-utils/Cargo.toml [INFO] started frobbing KeisukeYamashita/vasp-utils [INFO] finished frobbing KeisukeYamashita/vasp-utils [INFO] frobbed toml for KeisukeYamashita/vasp-utils written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KeisukeYamashita/vasp-utils/Cargo.toml [INFO] crate KeisukeYamashita/vasp-utils has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting KeisukeYamashita/vasp-utils against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/KeisukeYamashita/vasp-utils:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63305bc217d9779971c3a818c2c04c31512c3c68a9d790fb472dc9846449fb48 [INFO] running `"docker" "start" "-a" "63305bc217d9779971c3a818c2c04c31512c3c68a9d790fb472dc9846449fb48"` [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.14 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking vasputils v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | output_type: output_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | output_type: output_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / return match self.output_type { [INFO] [stderr] 73 | | "plainText" => self.process_plain_text(line), [INFO] [stderr] 74 | | "csv" => self.process_csv(line), [INFO] [stderr] 75 | | _ => panic!("not match"), [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | match self.output_type { [INFO] [stderr] 73 | "plainText" => self.process_plain_text(line), [INFO] [stderr] 74 | "csv" => self.process_csv(line), [INFO] [stderr] 75 | _ => panic!("not match"), [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return line_with_new_line; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `line_with_new_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/format.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / if *element != " " { [INFO] [stderr] 92 | | if *element == elements[4] { [INFO] [stderr] 93 | | result = result + *element + "\n"; [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | if *element != " " && *element == elements[4] { [INFO] [stderr] 92 | result = result + *element + "\n"; [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / return match feature_type { [INFO] [stderr] 110 | | Feature::FreeEnergy => "free", [INFO] [stderr] 111 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 109 | match feature_type { [INFO] [stderr] 110 | Feature::FreeEnergy => "free", [INFO] [stderr] 111 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / return match File::open(self.input) { [INFO] [stderr] 118 | | Err(_) => false, [INFO] [stderr] 119 | | Ok(_) => true, [INFO] [stderr] 120 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 117 | match File::open(self.input) { [INFO] [stderr] 118 | Err(_) => false, [INFO] [stderr] 119 | Ok(_) => true, [INFO] [stderr] 120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (input_path, output_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(input_path, output_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / return match self.output_type { [INFO] [stderr] 73 | | "plainText" => self.process_plain_text(line), [INFO] [stderr] 74 | | "csv" => self.process_csv(line), [INFO] [stderr] 75 | | _ => panic!("not match"), [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | match self.output_type { [INFO] [stderr] 73 | "plainText" => self.process_plain_text(line), [INFO] [stderr] 74 | "csv" => self.process_csv(line), [INFO] [stderr] 75 | _ => panic!("not match"), [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return line_with_new_line; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `line_with_new_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/format.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / if *element != " " { [INFO] [stderr] 92 | | if *element == elements[4] { [INFO] [stderr] 93 | | result = result + *element + "\n"; [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | if *element != " " && *element == elements[4] { [INFO] [stderr] 92 | result = result + *element + "\n"; [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / return match feature_type { [INFO] [stderr] 110 | | Feature::FreeEnergy => "free", [INFO] [stderr] 111 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 109 | match feature_type { [INFO] [stderr] 110 | Feature::FreeEnergy => "free", [INFO] [stderr] 111 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / return match File::open(self.input) { [INFO] [stderr] 118 | | Err(_) => false, [INFO] [stderr] 119 | | Ok(_) => true, [INFO] [stderr] 120 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 117 | match File::open(self.input) { [INFO] [stderr] 118 | Err(_) => false, [INFO] [stderr] 119 | Ok(_) => true, [INFO] [stderr] 120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (input_path, output_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(input_path, output_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/source.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | writer.write(token.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/source.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let ref mut token = String::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^----------------- help: try: `let token = &mut String::new();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | output_file.write(line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/format.rs:117:16 [INFO] [stderr] | [INFO] [stderr] 117 | return match File::open(self.input) { [INFO] [stderr] | ________________^ [INFO] [stderr] 118 | | Err(_) => false, [INFO] [stderr] 119 | | Ok(_) => true, [INFO] [stderr] 120 | | }; [INFO] [stderr] | |_________^ help: try this: `File::open(self.input).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `vasputils`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/source.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | writer.write(token.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/source.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let ref mut token = String::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^----------------- help: try: `let token = &mut String::new();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | output_file.write(line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/format.rs:117:16 [INFO] [stderr] | [INFO] [stderr] 117 | return match File::open(self.input) { [INFO] [stderr] | ________________^ [INFO] [stderr] 118 | | Err(_) => false, [INFO] [stderr] 119 | | Ok(_) => true, [INFO] [stderr] 120 | | }; [INFO] [stderr] | |_________^ help: try this: `File::open(self.input).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `vasputils`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "63305bc217d9779971c3a818c2c04c31512c3c68a9d790fb472dc9846449fb48"` [INFO] running `"docker" "rm" "-f" "63305bc217d9779971c3a818c2c04c31512c3c68a9d790fb472dc9846449fb48"` [INFO] [stdout] 63305bc217d9779971c3a818c2c04c31512c3c68a9d790fb472dc9846449fb48