[INFO] updating cached repository Kayren/wardice
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Kayren/wardice
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Kayren/wardice" "work/ex/clippy-test-run/sources/stable/gh/Kayren/wardice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kayren/wardice'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Kayren/wardice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kayren/wardice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kayren/wardice'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] dd508fded023a13006b6710c278566b01819a2a8
[INFO] sha for GitHub repo Kayren/wardice: dd508fded023a13006b6710c278566b01819a2a8
[INFO] validating manifest of Kayren/wardice on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Kayren/wardice on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Kayren/wardice
[INFO] finished frobbing Kayren/wardice
[INFO] frobbed toml for Kayren/wardice written to work/ex/clippy-test-run/sources/stable/gh/Kayren/wardice/Cargo.toml
[INFO] started frobbing Kayren/wardice
[INFO] finished frobbing Kayren/wardice
[INFO] frobbed toml for Kayren/wardice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kayren/wardice/Cargo.toml
[INFO] crate Kayren/wardice has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] linting Kayren/wardice against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kayren/wardice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8784ff61ea43f4560184c3cc38f23fa47eb3d7eba5068ed2fda72d5451ef5b2f
[INFO] running `"docker" "start" "-a" "8784ff61ea43f4560184c3cc38f23fa47eb3d7eba5068ed2fda72d5451ef5b2f"`
[INFO] [stderr]    Compiling serde v1.0.72
[INFO] [stderr]    Compiling serde_derive v1.0.72
[INFO] [stderr]     Checking serde_json v1.0.26
[INFO] [stderr]     Checking wardice v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:188:5
[INFO] [stderr]     |
[INFO] [stderr] 188 | /     return match rng.choose(dice) {
[INFO] [stderr] 189 | |         Some(face) => face,
[INFO] [stderr] 190 | |         None => {
[INFO] [stderr] 191 | |             println!("roll_dice: some found return blank");
[INFO] [stderr] 192 | |             return &Face::Blank;
[INFO] [stderr] 193 | |         }
[INFO] [stderr] 194 | |     };
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 188 |     match rng.choose(dice) {
[INFO] [stderr] 189 |         Some(face) => face,
[INFO] [stderr] 190 |         None => {
[INFO] [stderr] 191 |             println!("roll_dice: some found return blank");
[INFO] [stderr] 192 |             return &Face::Blank;
[INFO] [stderr] 193 |         }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:188:5
[INFO] [stderr]     |
[INFO] [stderr] 188 | /     return match rng.choose(dice) {
[INFO] [stderr] 189 | |         Some(face) => face,
[INFO] [stderr] 190 | |         None => {
[INFO] [stderr] 191 | |             println!("roll_dice: some found return blank");
[INFO] [stderr] 192 | |             return &Face::Blank;
[INFO] [stderr] 193 | |         }
[INFO] [stderr] 194 | |     };
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 188 |     match rng.choose(dice) {
[INFO] [stderr] 189 |         Some(face) => face,
[INFO] [stderr] 190 |         None => {
[INFO] [stderr] 191 |             println!("roll_dice: some found return blank");
[INFO] [stderr] 192 |             return &Face::Blank;
[INFO] [stderr] 193 |         }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:210:5
[INFO] [stderr]     |
[INFO] [stderr] 210 | /     match roll.1 {
[INFO] [stderr] 211 | |         Face::HammerP => {
[INFO] [stderr] 212 | |             let r = roll_dice(roll.0);
[INFO] [stderr] 213 | |             l.push(r);
[INFO] [stderr] ...   |
[INFO] [stderr] 216 | |         _ => (),
[INFO] [stderr] 217 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 210 |     if let Face::HammerP = roll.1 {
[INFO] [stderr] 211 |     let r = roll_dice(roll.0);
[INFO] [stderr] 212 |     l.push(r);
[INFO] [stderr] 213 |     reroll_dice(l, r);
[INFO] [stderr] 214 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used
[INFO] [stderr]    --> src/lib.rs:233:5
[INFO] [stderr]     |
[INFO] [stderr] 233 |     rolls.clone().into_iter().map(|r| reroll_dice(&mut rerolls, r)).collect::<()>();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead
[INFO] [stderr] 
[INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator
[INFO] [stderr]    --> src/lib.rs:233:5
[INFO] [stderr]     |
[INFO] [stderr] 233 |     rolls.clone().into_iter().map(|r| reroll_dice(&mut rerolls, r)).collect::<()>();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:210:5
[INFO] [stderr]     |
[INFO] [stderr] 210 | /     match roll.1 {
[INFO] [stderr] 211 | |         Face::HammerP => {
[INFO] [stderr] 212 | |             let r = roll_dice(roll.0);
[INFO] [stderr] 213 | |             l.push(r);
[INFO] [stderr] ...   |
[INFO] [stderr] 216 | |         _ => (),
[INFO] [stderr] 217 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 210 |     if let Face::HammerP = roll.1 {
[INFO] [stderr] 211 |     let r = roll_dice(roll.0);
[INFO] [stderr] 212 |     l.push(r);
[INFO] [stderr] 213 |     reroll_dice(l, r);
[INFO] [stderr] 214 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used
[INFO] [stderr]    --> src/lib.rs:233:5
[INFO] [stderr]     |
[INFO] [stderr] 233 |     rolls.clone().into_iter().map(|r| reroll_dice(&mut rerolls, r)).collect::<()>();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead
[INFO] [stderr] 
[INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator
[INFO] [stderr]    --> src/lib.rs:233:5
[INFO] [stderr]     |
[INFO] [stderr] 233 |     rolls.clone().into_iter().map(|r| reroll_dice(&mut rerolls, r)).collect::<()>();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 26.75s
[INFO] running `"docker" "inspect" "8784ff61ea43f4560184c3cc38f23fa47eb3d7eba5068ed2fda72d5451ef5b2f"`
[INFO] running `"docker" "rm" "-f" "8784ff61ea43f4560184c3cc38f23fa47eb3d7eba5068ed2fda72d5451ef5b2f"`
[INFO] [stdout] 8784ff61ea43f4560184c3cc38f23fa47eb3d7eba5068ed2fda72d5451ef5b2f