[INFO] updating cached repository Kaduo/neural_net [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Kaduo/neural_net [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Kaduo/neural_net" "work/ex/clippy-test-run/sources/stable/gh/Kaduo/neural_net"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Kaduo/neural_net'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Kaduo/neural_net" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kaduo/neural_net"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kaduo/neural_net'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f747397c0825c0c000e57a66574b9c6e53eb3fa [INFO] sha for GitHub repo Kaduo/neural_net: 9f747397c0825c0c000e57a66574b9c6e53eb3fa [INFO] validating manifest of Kaduo/neural_net on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Kaduo/neural_net on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Kaduo/neural_net [INFO] finished frobbing Kaduo/neural_net [INFO] frobbed toml for Kaduo/neural_net written to work/ex/clippy-test-run/sources/stable/gh/Kaduo/neural_net/Cargo.toml [INFO] started frobbing Kaduo/neural_net [INFO] finished frobbing Kaduo/neural_net [INFO] frobbed toml for Kaduo/neural_net written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Kaduo/neural_net/Cargo.toml [INFO] crate Kaduo/neural_net has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Kaduo/neural_net against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Kaduo/neural_net:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f2d99a9de1767592c555b6be1ecf437dcb26a8b7a14540cffc3b44abc7c4116 [INFO] running `"docker" "start" "-a" "9f2d99a9de1767592c555b6be1ecf437dcb26a8b7a14540cffc3b44abc7c4116"` [INFO] [stderr] Checking num-complex v0.1.41 [INFO] [stderr] Checking serde_json v1.0.9 [INFO] [stderr] Checking alga v0.5.2 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking neural_net v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:72:19 [INFO] [stderr] | [INFO] [stderr] 72 | return Network {sizes: sizes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `sizes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:7 [INFO] [stderr] | [INFO] [stderr] 74 | biases: biases, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `biases` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:7 [INFO] [stderr] | [INFO] [stderr] 75 | nb_layers: nb_layers} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nb_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:72:19 [INFO] [stderr] | [INFO] [stderr] 72 | return Network {sizes: sizes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `sizes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:7 [INFO] [stderr] | [INFO] [stderr] 74 | biases: biases, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `biases` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:7 [INFO] [stderr] | [INFO] [stderr] 75 | nb_layers: nb_layers} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nb_layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/load_mnist.rs:52:2 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok((train, test)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((train, test))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:24:2 [INFO] [stderr] | [INFO] [stderr] 24 | return 1.0/(1.0 + (-z).exp()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `1.0/(1.0 + (-z).exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:28:2 [INFO] [stderr] | [INFO] [stderr] 28 | return sigmoid(z)*(1.0 - sigmoid(z)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sigmoid(z)*(1.0 - sigmoid(z))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:34:2 [INFO] [stderr] | [INFO] [stderr] 34 | return output_activations - expected_output [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output_activations - expected_output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | return Network {sizes: sizes, [INFO] [stderr] | _________^ [INFO] [stderr] 73 | | weights: weights, [INFO] [stderr] 74 | | biases: biases, [INFO] [stderr] 75 | | nb_layers: nb_layers} [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | Network {sizes: sizes, [INFO] [stderr] 73 | weights: weights, [INFO] [stderr] 74 | biases: biases, [INFO] [stderr] 75 | nb_layers: nb_layers} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:83:3 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | return serde_json::from_reader(file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::from_reader(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:101:3 [INFO] [stderr] | [INFO] [stderr] 101 | return output [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:185:3 [INFO] [stderr] | [INFO] [stderr] 185 | return (nabla_biases_final, nabla_weights_final) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(nabla_biases_final, nabla_weights_final)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/load_mnist.rs:52:2 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok((train, test)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((train, test))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:24:2 [INFO] [stderr] | [INFO] [stderr] 24 | return 1.0/(1.0 + (-z).exp()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `1.0/(1.0 + (-z).exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:28:2 [INFO] [stderr] | [INFO] [stderr] 28 | return sigmoid(z)*(1.0 - sigmoid(z)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sigmoid(z)*(1.0 - sigmoid(z))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:34:2 [INFO] [stderr] | [INFO] [stderr] 34 | return output_activations - expected_output [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output_activations - expected_output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | return Network {sizes: sizes, [INFO] [stderr] | _________^ [INFO] [stderr] 73 | | weights: weights, [INFO] [stderr] 74 | | biases: biases, [INFO] [stderr] 75 | | nb_layers: nb_layers} [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | Network {sizes: sizes, [INFO] [stderr] 73 | weights: weights, [INFO] [stderr] 74 | biases: biases, [INFO] [stderr] 75 | nb_layers: nb_layers} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:83:3 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | return serde_json::from_reader(file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::from_reader(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:101:3 [INFO] [stderr] | [INFO] [stderr] 101 | return output [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:185:3 [INFO] [stderr] | [INFO] [stderr] 185 | return (nabla_biases_final, nabla_weights_final) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(nabla_biases_final, nabla_weights_final)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/load_mnist.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn load_data() -> Result<(Vec<(DVector, DVector)>,Vec<(DVector, DVector)>), [INFO] [stderr] | _______________________^ [INFO] [stderr] 18 | | io::Error> { [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:26:2 [INFO] [stderr] | [INFO] [stderr] 26 | train_images.read(&mut [0; SKIP_BYTES_TRAINING_IMAGES])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | train_labels.read(&mut [0; SKIP_BYTES_TRAINING_LABELS])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | train_images.read(&mut image)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | train_labels.read(&mut label)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/load_mnist.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | &image.iter().map(|x| (*x as f64)/255.0).collect::>()[..]), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | train_images.read(&mut image)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | train_labels.read(&mut label)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/load_mnist.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | &image.iter().map(|x| (*x as f64)/255.0).collect::>()[..]), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:104:36 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn evaluate(&self, test_data: &Vec<(DVector, DVector)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(DVector, DVector)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | if expected_output[imax] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(expected_output[imax] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | if expected_output[imax] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:157:12 [INFO] [stderr] | [INFO] [stderr] 157 | for l in 2..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `2..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `neural_net`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/load_mnist.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn load_data() -> Result<(Vec<(DVector, DVector)>,Vec<(DVector, DVector)>), [INFO] [stderr] | _______________________^ [INFO] [stderr] 18 | | io::Error> { [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:26:2 [INFO] [stderr] | [INFO] [stderr] 26 | train_images.read(&mut [0; SKIP_BYTES_TRAINING_IMAGES])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | train_labels.read(&mut [0; SKIP_BYTES_TRAINING_LABELS])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | train_images.read(&mut image)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | train_labels.read(&mut label)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/load_mnist.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | &image.iter().map(|x| (*x as f64)/255.0).collect::>()[..]), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | train_images.read(&mut image)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/load_mnist.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | train_labels.read(&mut label)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/load_mnist.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | &image.iter().map(|x| (*x as f64)/255.0).collect::>()[..]), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:104:36 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn evaluate(&self, test_data: &Vec<(DVector, DVector)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(DVector, DVector)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | if expected_output[imax] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(expected_output[imax] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | if expected_output[imax] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:157:12 [INFO] [stderr] | [INFO] [stderr] 157 | for l in 2..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `2..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `neural_net`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9f2d99a9de1767592c555b6be1ecf437dcb26a8b7a14540cffc3b44abc7c4116"` [INFO] running `"docker" "rm" "-f" "9f2d99a9de1767592c555b6be1ecf437dcb26a8b7a14540cffc3b44abc7c4116"` [INFO] [stdout] 9f2d99a9de1767592c555b6be1ecf437dcb26a8b7a14540cffc3b44abc7c4116