[INFO] updating cached repository KaHLK/copy_watcher [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KaHLK/copy_watcher [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KaHLK/copy_watcher" "work/ex/clippy-test-run/sources/stable/gh/KaHLK/copy_watcher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KaHLK/copy_watcher'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KaHLK/copy_watcher" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KaHLK/copy_watcher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KaHLK/copy_watcher'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 51f15024d2c5203c8b97acf97a1e905fbbee17a4 [INFO] sha for GitHub repo KaHLK/copy_watcher: 51f15024d2c5203c8b97acf97a1e905fbbee17a4 [INFO] validating manifest of KaHLK/copy_watcher on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KaHLK/copy_watcher on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KaHLK/copy_watcher [INFO] finished frobbing KaHLK/copy_watcher [INFO] frobbed toml for KaHLK/copy_watcher written to work/ex/clippy-test-run/sources/stable/gh/KaHLK/copy_watcher/Cargo.toml [INFO] started frobbing KaHLK/copy_watcher [INFO] finished frobbing KaHLK/copy_watcher [INFO] frobbed toml for KaHLK/copy_watcher written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KaHLK/copy_watcher/Cargo.toml [INFO] crate KaHLK/copy_watcher has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting KaHLK/copy_watcher against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/KaHLK/copy_watcher:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e93db6a106fdbb5fbac4fcb76649f7e13f77ac1590c5b8db96fe2bdb3443f22b [INFO] running `"docker" "start" "-a" "e93db6a106fdbb5fbac4fcb76649f7e13f77ac1590c5b8db96fe2bdb3443f22b"` [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v4.0.3 [INFO] [stderr] Checking copy_watcher v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if let Err(_) = fs::create_dir_all(to) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 63 | | exit(1); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____- help: try this: `if fs::create_dir_all(to).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | while let Some(el) = to_iter.next(){ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `for el in to_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | while let Some(el) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for el in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if let Err(_) = fs::create_dir_all(to) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 63 | | exit(1); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____- help: try this: `if fs::create_dir_all(to).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | while let Some(el) = to_iter.next(){ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `for el in to_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | while let Some(el) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for el in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.85s [INFO] running `"docker" "inspect" "e93db6a106fdbb5fbac4fcb76649f7e13f77ac1590c5b8db96fe2bdb3443f22b"` [INFO] running `"docker" "rm" "-f" "e93db6a106fdbb5fbac4fcb76649f7e13f77ac1590c5b8db96fe2bdb3443f22b"` [INFO] [stdout] e93db6a106fdbb5fbac4fcb76649f7e13f77ac1590c5b8db96fe2bdb3443f22b