[INFO] updating cached repository Jvanrhijn/rustyrenderer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Jvanrhijn/rustyrenderer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Jvanrhijn/rustyrenderer" "work/ex/clippy-test-run/sources/stable/gh/Jvanrhijn/rustyrenderer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jvanrhijn/rustyrenderer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Jvanrhijn/rustyrenderer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jvanrhijn/rustyrenderer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jvanrhijn/rustyrenderer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 22db30a4ecbb48001e984cc3dddc77fcf343eb07 [INFO] sha for GitHub repo Jvanrhijn/rustyrenderer: 22db30a4ecbb48001e984cc3dddc77fcf343eb07 [INFO] validating manifest of Jvanrhijn/rustyrenderer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Jvanrhijn/rustyrenderer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Jvanrhijn/rustyrenderer [INFO] finished frobbing Jvanrhijn/rustyrenderer [INFO] frobbed toml for Jvanrhijn/rustyrenderer written to work/ex/clippy-test-run/sources/stable/gh/Jvanrhijn/rustyrenderer/Cargo.toml [INFO] started frobbing Jvanrhijn/rustyrenderer [INFO] finished frobbing Jvanrhijn/rustyrenderer [INFO] frobbed toml for Jvanrhijn/rustyrenderer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jvanrhijn/rustyrenderer/Cargo.toml [INFO] crate Jvanrhijn/rustyrenderer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Jvanrhijn/rustyrenderer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Jvanrhijn/rustyrenderer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3e9e47e6d7406ad5c3d46f9c0181a912ca0d56a297a9a5da09ddfcca70b9291a [INFO] running `"docker" "start" "-a" "3e9e47e6d7406ad5c3d46f9c0181a912ca0d56a297a9a5da09ddfcca70b9291a"` [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking rustyrenderer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::vec` [INFO] [stderr] --> src/geo.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::vec; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `geo::Vector` [INFO] [stderr] --> src/model.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use geo::Vector; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/model.rs:56:34 [INFO] [stderr] | [INFO] [stderr] 56 | let geo::Vec3i{x, y, z: _} = pixel; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Vec3i { x, y, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/model.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | let dx = (x1 as i32 - x0 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/model.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | let dy = (y1 as i32 - y0 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `geo::Vector` [INFO] [stderr] --> src/obj.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use geo::Vector; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::vec` [INFO] [stderr] --> src/geo.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::vec; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `geo::Vector` [INFO] [stderr] --> src/model.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use geo::Vector; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/model.rs:56:34 [INFO] [stderr] | [INFO] [stderr] 56 | let geo::Vec3i{x, y, z: _} = pixel; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Vec3i { x, y, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/model.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | let dx = (x1 as i32 - x0 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/model.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | let dy = (y1 as i32 - y0 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `geo::Vector` [INFO] [stderr] --> src/obj.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use geo::Vector; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj.rs:98:50 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(obj.vert(0), geo::Vec3f::new(-0.000581696, -0.734665, -0.623267)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_581_696` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj.rs:98:64 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(obj.vert(0), geo::Vec3f::new(-0.000581696, -0.734665, -0.623267)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.734_665` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj.rs:98:75 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(obj.vert(0), geo::Vec3f::new(-0.000581696, -0.734665, -0.623267)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.623_267` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/model.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | _ => unreachable!() [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `zbuf` [INFO] [stderr] --> src/model.rs:61:71 [INFO] [stderr] | [INFO] [stderr] 61 | fn draw_filled(&self, img: &mut image::RgbImage, color: &[u8; 3], zbuf: &mut Vec) { [INFO] [stderr] | ^^^^ help: consider using `_zbuf` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Vec2f` [INFO] [stderr] --> src/geo.rs:240:1 [INFO] [stderr] | [INFO] [stderr] 240 | pub type Vec2f = Vec2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Vec2i` [INFO] [stderr] --> src/geo.rs:241:1 [INFO] [stderr] | [INFO] [stderr] 241 | pub type Vec2i = Vec2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rasterize` [INFO] [stderr] --> src/model.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn rasterize(&self, xdim: u32, ydim: u32) -> Line { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `vertices` [INFO] [stderr] --> src/model.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | fn vertices(&self) -> [&geo::Vec3; 2] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `face` [INFO] [stderr] --> src/obj.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn face(&self, i: usize) -> geo::Vec3i { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `vert` [INFO] [stderr] --> src/obj.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn vert(&self, i: usize) -> geo::Vec3f { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | Vec2::::new(vec[0].clone(), vec[1].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:109:40 [INFO] [stderr] | [INFO] [stderr] 109 | Vec2::::new(vec[0].clone(), vec[1].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:225:23 [INFO] [stderr] | [INFO] [stderr] 225 | Vec3::::new(vec[0].clone(), vec[1].clone(), vec[2].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:225:39 [INFO] [stderr] | [INFO] [stderr] 225 | Vec3::::new(vec[0].clone(), vec[1].clone(), vec[2].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:225:55 [INFO] [stderr] | [INFO] [stderr] 225 | Vec3::::new(vec[0].clone(), vec[1].clone(), vec[2].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:12:54 [INFO] [stderr] | [INFO] [stderr] 12 | fn draw(&self, img: &mut image::RgbImage, color: &[u8; 3]); [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:14:61 [INFO] [stderr] | [INFO] [stderr] 14 | fn draw_filled(&self, img: &mut image::RgbImage, color: &[u8; 3], zbuf: &mut Vec); [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:36:63 [INFO] [stderr] | [INFO] [stderr] 36 | let start = geo::Vec3::::new(((start.x + 1.)*0.5*(xdim as f64)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(xdim)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:37:63 [INFO] [stderr] | [INFO] [stderr] 37 | ((start.y + 1.)*0.5*(ydim as f64)) as u32, 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(ydim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:38:59 [INFO] [stderr] | [INFO] [stderr] 38 | let end = geo::Vec3::::new(((end.x + 1.)*0.5*(xdim as f64)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(xdim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:39:59 [INFO] [stderr] | [INFO] [stderr] 39 | ((end.y + 1.)*0.5*(ydim as f64)) as u32, 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(ydim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/model.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | let (x, y) = match self.steep { [INFO] [stderr] | ______________________^ [INFO] [stderr] 134 | | false => (self.x, self.y), [INFO] [stderr] 135 | | true => (self.y, self.x) [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.steep { (self.y, self.x) } else { (self.x, self.y) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:168:28 [INFO] [stderr] | [INFO] [stderr] 168 | let ab = Line::new(a.clone(), b.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:168:39 [INFO] [stderr] | [INFO] [stderr] 168 | let ab = Line::new(a.clone(), b.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:169:28 [INFO] [stderr] | [INFO] [stderr] 169 | let bc = Line::new(b.clone(), c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:169:39 [INFO] [stderr] | [INFO] [stderr] 169 | let bc = Line::new(b.clone(), c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:170:28 [INFO] [stderr] | [INFO] [stderr] 170 | let ac = Line::new(a.clone(), c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:170:39 [INFO] [stderr] | [INFO] [stderr] 170 | let ac = Line::new(a.clone(), c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:190:68 [INFO] [stderr] | [INFO] [stderr] 190 | vertices.push(geo::Vec3::::new(((vert.x + 1.)*0.5*(dimx as f64)) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(dimx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:191:68 [INFO] [stderr] | [INFO] [stderr] 191 | ((vert.y + 1.)*0.5*(dimy as f64)) as i32, 0)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(dimy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:231:27 [INFO] [stderr] | [INFO] [stderr] 231 | point.x = x as f64; point.y = y as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:231:47 [INFO] [stderr] | [INFO] [stderr] 231 | point.x = x as f64; point.y = y as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/model.rs:237:52 [INFO] [stderr] | [INFO] [stderr] 237 | for (i, vertex) in self.vertices().into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:240:44 [INFO] [stderr] | [INFO] [stderr] 240 | if zbuf[(point.x + point.y*(imgx as f64)) as usize] < point.z { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(imgx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:241:45 [INFO] [stderr] | [INFO] [stderr] 241 | zbuf[(point.x + point.y*(imgx as f64)) as usize] = point.z; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(imgx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/model.rs:258:39 [INFO] [stderr] | [INFO] [stderr] 258 | for vertex in rast.vertices().into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.faces[i].clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.faces[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | self.vertices[i].clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.vertices[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:65:10 [INFO] [stderr] | [INFO] [stderr] 65 | [v[0].clone(), v[1].clone(), v[2].clone()] [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `v[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:65:24 [INFO] [stderr] | [INFO] [stderr] 65 | [v[0].clone(), v[1].clone(), v[2].clone()] [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `v[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:65:38 [INFO] [stderr] | [INFO] [stderr] 65 | [v[0].clone(), v[1].clone(), v[2].clone()] [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `v[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `terms`. [INFO] [stderr] --> src/obj.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for in terms.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/obj.rs:72:42 [INFO] [stderr] | [INFO] [stderr] 72 | let indices = terms[i].split("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/render.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | for obj in (&self.objects).into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustyrenderer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/model.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | _ => unreachable!() [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `triangle` [INFO] [stderr] --> src/model.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | let triangle = Triangle::new(a, b, c); [INFO] [stderr] | ^^^^^^^^ help: consider using `_triangle` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `triangle` [INFO] [stderr] --> src/model.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | let triangle = Triangle::new(a, b, c); [INFO] [stderr] | ^^^^^^^^ help: consider using `_triangle` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `image` [INFO] [stderr] --> src/model.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | let image = image::RgbImage::new(10, 20); [INFO] [stderr] | ^^^^^ help: consider using `_image` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `line_iter` [INFO] [stderr] --> src/model.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | let line_iter = LineIterator::new(&line); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_line_iter` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/model.rs:317:17 [INFO] [stderr] | [INFO] [stderr] 317 | let mut x = 0; [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/model.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | let mut y = 0; [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `zbuf` [INFO] [stderr] --> src/model.rs:61:71 [INFO] [stderr] | [INFO] [stderr] 61 | fn draw_filled(&self, img: &mut image::RgbImage, color: &[u8; 3], zbuf: &mut Vec) { [INFO] [stderr] | ^^^^ help: consider using `_zbuf` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/model.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | let mut x = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/model.rs:318:13 [INFO] [stderr] | [INFO] [stderr] 318 | let mut y = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Vec2i` [INFO] [stderr] --> src/geo.rs:241:1 [INFO] [stderr] | [INFO] [stderr] 241 | pub type Vec2i = Vec2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rasterize` [INFO] [stderr] --> src/model.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn rasterize(&self, xdim: u32, ydim: u32) -> Line { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | Vec2::::new(vec[0].clone(), vec[1].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:109:40 [INFO] [stderr] | [INFO] [stderr] 109 | Vec2::::new(vec[0].clone(), vec[1].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:225:23 [INFO] [stderr] | [INFO] [stderr] 225 | Vec3::::new(vec[0].clone(), vec[1].clone(), vec[2].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:225:39 [INFO] [stderr] | [INFO] [stderr] 225 | Vec3::::new(vec[0].clone(), vec[1].clone(), vec[2].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geo.rs:225:55 [INFO] [stderr] | [INFO] [stderr] 225 | Vec3::::new(vec[0].clone(), vec[1].clone(), vec[2].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `vec[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geo.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | assert_eq!(Vec3f::new(1., 1., 1.).norm(), (3. as f64).sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geo.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | assert_eq!(Vec3f::new(1., 1., 1.).norm(), (3. as f64).sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:281:63 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(Vec3f::new(1., 1., 1.).normalize().norm(), 1 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geo.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(Vec3f::new(1., 1., 1.).normalize().norm(), 1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geo.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(Vec3f::new(1., 1., 1.).normalize().norm(), 1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:288:36 [INFO] [stderr] | [INFO] [stderr] 288 | assert_eq!(&first*&second, 0 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geo.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | assert_eq!(&first*&second, 0 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geo.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | assert_eq!(&first*&second, 0 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:289:40 [INFO] [stderr] | [INFO] [stderr] 289 | assert_eq!(first.dot(&second), 0 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geo.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | assert_eq!(first.dot(&second), 0 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geo.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | assert_eq!(first.dot(&second), 0 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:296:54 [INFO] [stderr] | [INFO] [stderr] 296 | assert_eq!(first.cross(&second).dot(&first), 0 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geo.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | assert_eq!(first.cross(&second).dot(&first), 0 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geo.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | assert_eq!(first.cross(&second).dot(&first), 0 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:297:55 [INFO] [stderr] | [INFO] [stderr] 297 | assert_eq!(first.cross(&second).dot(&second), 0 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geo.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | assert_eq!(first.cross(&second).dot(&second), 0 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geo.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | assert_eq!(first.cross(&second).dot(&second), 0 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/geo.rs:298:66 [INFO] [stderr] | [INFO] [stderr] 298 | assert_eq!(second.cross(&first), (&first.cross(&second))*(-1 as f64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:12:54 [INFO] [stderr] | [INFO] [stderr] 12 | fn draw(&self, img: &mut image::RgbImage, color: &[u8; 3]); [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/model.rs:14:61 [INFO] [stderr] | [INFO] [stderr] 14 | fn draw_filled(&self, img: &mut image::RgbImage, color: &[u8; 3], zbuf: &mut Vec); [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:36:63 [INFO] [stderr] | [INFO] [stderr] 36 | let start = geo::Vec3::::new(((start.x + 1.)*0.5*(xdim as f64)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(xdim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:37:63 [INFO] [stderr] | [INFO] [stderr] 37 | ((start.y + 1.)*0.5*(ydim as f64)) as u32, 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(ydim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:38:59 [INFO] [stderr] | [INFO] [stderr] 38 | let end = geo::Vec3::::new(((end.x + 1.)*0.5*(xdim as f64)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(xdim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:39:59 [INFO] [stderr] | [INFO] [stderr] 39 | ((end.y + 1.)*0.5*(ydim as f64)) as u32, 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(ydim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/model.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | let (x, y) = match self.steep { [INFO] [stderr] | ______________________^ [INFO] [stderr] 134 | | false => (self.x, self.y), [INFO] [stderr] 135 | | true => (self.y, self.x) [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.steep { (self.y, self.x) } else { (self.x, self.y) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:168:28 [INFO] [stderr] | [INFO] [stderr] 168 | let ab = Line::new(a.clone(), b.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:168:39 [INFO] [stderr] | [INFO] [stderr] 168 | let ab = Line::new(a.clone(), b.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:169:28 [INFO] [stderr] | [INFO] [stderr] 169 | let bc = Line::new(b.clone(), c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:169:39 [INFO] [stderr] | [INFO] [stderr] 169 | let bc = Line::new(b.clone(), c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:170:28 [INFO] [stderr] | [INFO] [stderr] 170 | let ac = Line::new(a.clone(), c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:170:39 [INFO] [stderr] | [INFO] [stderr] 170 | let ac = Line::new(a.clone(), c.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:190:68 [INFO] [stderr] | [INFO] [stderr] 190 | vertices.push(geo::Vec3::::new(((vert.x + 1.)*0.5*(dimx as f64)) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(dimx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:191:68 [INFO] [stderr] | [INFO] [stderr] 191 | ((vert.y + 1.)*0.5*(dimy as f64)) as i32, 0)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(dimy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:231:27 [INFO] [stderr] | [INFO] [stderr] 231 | point.x = x as f64; point.y = y as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:231:47 [INFO] [stderr] | [INFO] [stderr] 231 | point.x = x as f64; point.y = y as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/model.rs:237:52 [INFO] [stderr] | [INFO] [stderr] 237 | for (i, vertex) in self.vertices().into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:240:44 [INFO] [stderr] | [INFO] [stderr] 240 | if zbuf[(point.x + point.y*(imgx as f64)) as usize] < point.z { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(imgx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model.rs:241:45 [INFO] [stderr] | [INFO] [stderr] 241 | zbuf[(point.x + point.y*(imgx as f64)) as usize] = point.z; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(imgx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/model.rs:258:39 [INFO] [stderr] | [INFO] [stderr] 258 | for vertex in rast.vertices().into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.faces[i].clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.faces[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | self.vertices[i].clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.vertices[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:65:10 [INFO] [stderr] | [INFO] [stderr] 65 | [v[0].clone(), v[1].clone(), v[2].clone()] [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `v[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:65:24 [INFO] [stderr] | [INFO] [stderr] 65 | [v[0].clone(), v[1].clone(), v[2].clone()] [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `v[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/obj.rs:65:38 [INFO] [stderr] | [INFO] [stderr] 65 | [v[0].clone(), v[1].clone(), v[2].clone()] [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `v[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `terms`. [INFO] [stderr] --> src/obj.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for in terms.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/obj.rs:72:42 [INFO] [stderr] | [INFO] [stderr] 72 | let indices = terms[i].split("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/render.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | for obj in (&self.objects).into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustyrenderer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3e9e47e6d7406ad5c3d46f9c0181a912ca0d56a297a9a5da09ddfcca70b9291a"` [INFO] running `"docker" "rm" "-f" "3e9e47e6d7406ad5c3d46f9c0181a912ca0d56a297a9a5da09ddfcca70b9291a"` [INFO] [stdout] 3e9e47e6d7406ad5c3d46f9c0181a912ca0d56a297a9a5da09ddfcca70b9291a