[INFO] updating cached repository JustBeYou/AsyncHTTP
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/JustBeYou/AsyncHTTP
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/JustBeYou/AsyncHTTP" "work/ex/clippy-test-run/sources/stable/gh/JustBeYou/AsyncHTTP"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JustBeYou/AsyncHTTP'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/JustBeYou/AsyncHTTP" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JustBeYou/AsyncHTTP"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JustBeYou/AsyncHTTP'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3bb899316a883b69fd8dab6ae01db843da5d1eb3
[INFO] sha for GitHub repo JustBeYou/AsyncHTTP: 3bb899316a883b69fd8dab6ae01db843da5d1eb3
[INFO] validating manifest of JustBeYou/AsyncHTTP on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of JustBeYou/AsyncHTTP on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing JustBeYou/AsyncHTTP
[INFO] finished frobbing JustBeYou/AsyncHTTP
[INFO] frobbed toml for JustBeYou/AsyncHTTP written to work/ex/clippy-test-run/sources/stable/gh/JustBeYou/AsyncHTTP/Cargo.toml
[INFO] started frobbing JustBeYou/AsyncHTTP
[INFO] finished frobbing JustBeYou/AsyncHTTP
[INFO] frobbed toml for JustBeYou/AsyncHTTP written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JustBeYou/AsyncHTTP/Cargo.toml
[INFO] crate JustBeYou/AsyncHTTP has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting JustBeYou/AsyncHTTP against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JustBeYou/AsyncHTTP:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b890dc97af5fc441b8f27cefe4f93ca1bd98cbdad77f062f209127dc844631ed
[INFO] running `"docker" "start" "-a" "b890dc97af5fc441b8f27cefe4f93ca1bd98cbdad77f062f209127dc844631ed"`
[INFO] [stderr]     Checking async_http v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             address: address,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             port: port,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `port`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             tcp_listener: tcp_listener,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcp_listener`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             conn_limit: conn_limit,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `conn_limit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:65:13
[INFO] [stderr]    |
[INFO] [stderr] 65 |             poll: poll,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `poll`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             events: events,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `events`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server/listener.rs:138:45
[INFO] [stderr]     |
[INFO] [stderr] 138 |                                             token: token
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `token`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server/listener.rs:155:45
[INFO] [stderr]     |
[INFO] [stderr] 155 |                                             token: token
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `token`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/events.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             event_type: event_type,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_type`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/events.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             event_data: event_data
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/client.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             socket: socket,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             address: address,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             port: port,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `port`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             tcp_listener: tcp_listener,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcp_listener`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             conn_limit: conn_limit,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `conn_limit`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:65:13
[INFO] [stderr]    |
[INFO] [stderr] 65 |             poll: poll,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `poll`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/listener.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |             events: events,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `events`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server/listener.rs:138:45
[INFO] [stderr]     |
[INFO] [stderr] 138 |                                             token: token
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `token`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server/listener.rs:155:45
[INFO] [stderr]     |
[INFO] [stderr] 155 |                                             token: token
[INFO] [stderr]     |                                             ^^^^^^^^^^^^ help: replace it with: `token`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/events.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             event_type: event_type,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_type`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/events.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             event_data: event_data
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/client.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             socket: socket,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/config/mod.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     ret
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/config/mod.rs:31:15
[INFO] [stderr]    |
[INFO] [stderr] 31 |       let ret = Configuration {
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 32 | |         conn_limit: match parsed["server"]["conn_limit"].as_u64() {
[INFO] [stderr] 33 | |             Some(i) => i,
[INFO] [stderr] 34 | |             None => 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/server/listener.rs:13:37
[INFO] [stderr]    |
[INFO] [stderr] 13 | const LISTENER_TOKEN: Token = Token(0xdeadbeef);
[INFO] [stderr]    |                                     ^^^^^^^^^^ help: consider: `0xdead_beef`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/server/listener.rs:67:32
[INFO] [stderr]    |
[INFO] [stderr] 67 |             error_token: Token(987654321),
[INFO] [stderr]    |                                ^^^^^^^^^ help: consider: `987_654_321`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/server/listener.rs:71:62
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn register(&self, socket: &TcpStream, index: Token) -> () {
[INFO] [stderr]    |                                                              ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/server/listener.rs:78:44
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn push_error(&mut self, token: Token) -> () {
[INFO] [stderr]    |                                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `IncomingData`, `OutgoingData`
[INFO] [stderr]   --> src/server/mod.rs:9:22
[INFO] [stderr]    |
[INFO] [stderr] 9  |                      IncomingData,
[INFO] [stderr]    |                      ^^^^^^^^^^^^
[INFO] [stderr] 10 |                      OutgoingData};
[INFO] [stderr]    |                      ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Unimplemented`
[INFO] [stderr]   --> src/server/listener.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     Unimplemented,
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `address`
[INFO] [stderr]   --> src/server/listener.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     address: SocketAddr,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `port`
[INFO] [stderr]   --> src/server/listener.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     port: u16,
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `conn_limit`
[INFO] [stderr]   --> src/server/listener.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     conn_limit: u64,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `online_clients`
[INFO] [stderr]   --> src/server/listener.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     online_clients: u64,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `push_error`
[INFO] [stderr]   --> src/server/listener.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn push_error(&mut self, token: Token) -> () {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_port`
[INFO] [stderr]    --> src/server/listener.rs:165:5
[INFO] [stderr]     |
[INFO] [stderr] 165 |     pub fn get_port(&self) -> &u16 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:22:25
[INFO] [stderr]    |
[INFO] [stderr] 22 | fn load_json(file_name: &String) -> Configuration {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:59:24
[INFO] [stderr]    |
[INFO] [stderr] 59 | fn get_handler(format: &String) -> fn(file_name: &String) -> Configuration {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:67:29
[INFO] [stderr]    |
[INFO] [stderr] 67 | pub fn load_file(file_name: &String, format: &String) -> Configuration {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:67:46
[INFO] [stderr]    |
[INFO] [stderr] 67 | pub fn load_file(file_name: &String, format: &String) -> Configuration {
[INFO] [stderr]    |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/config/mod.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     ret
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/config/mod.rs:31:15
[INFO] [stderr]    |
[INFO] [stderr] 31 |       let ret = Configuration {
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 32 | |         conn_limit: match parsed["server"]["conn_limit"].as_u64() {
[INFO] [stderr] 33 | |             Some(i) => i,
[INFO] [stderr] 34 | |             None => 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/server/listener.rs:13:37
[INFO] [stderr]    |
[INFO] [stderr] 13 | const LISTENER_TOKEN: Token = Token(0xdeadbeef);
[INFO] [stderr]    |                                     ^^^^^^^^^^ help: consider: `0xdead_beef`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/server/listener.rs:67:32
[INFO] [stderr]    |
[INFO] [stderr] 67 |             error_token: Token(987654321),
[INFO] [stderr]    |                                ^^^^^^^^^ help: consider: `987_654_321`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/server/listener.rs:71:62
[INFO] [stderr]    |
[INFO] [stderr] 71 |     pub fn register(&self, socket: &TcpStream, index: Token) -> () {
[INFO] [stderr]    |                                                              ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/server/listener.rs:78:44
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn push_error(&mut self, token: Token) -> () {
[INFO] [stderr]    |                                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `IncomingData`, `OutgoingData`
[INFO] [stderr]   --> src/server/mod.rs:9:22
[INFO] [stderr]    |
[INFO] [stderr] 9  |                      IncomingData,
[INFO] [stderr]    |                      ^^^^^^^^^^^^
[INFO] [stderr] 10 |                      OutgoingData};
[INFO] [stderr]    |                      ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Unimplemented`
[INFO] [stderr]   --> src/server/listener.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     Unimplemented,
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `address`
[INFO] [stderr]   --> src/server/listener.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     address: SocketAddr,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `port`
[INFO] [stderr]   --> src/server/listener.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     port: u16,
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `conn_limit`
[INFO] [stderr]   --> src/server/listener.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     conn_limit: u64,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `online_clients`
[INFO] [stderr]   --> src/server/listener.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     online_clients: u64,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `push_error`
[INFO] [stderr]   --> src/server/listener.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn push_error(&mut self, token: Token) -> () {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_port`
[INFO] [stderr]    --> src/server/listener.rs:165:5
[INFO] [stderr]     |
[INFO] [stderr] 165 |     pub fn get_port(&self) -> &u16 {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:22:25
[INFO] [stderr]    |
[INFO] [stderr] 22 | fn load_json(file_name: &String) -> Configuration {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:59:24
[INFO] [stderr]    |
[INFO] [stderr] 59 | fn get_handler(format: &String) -> fn(file_name: &String) -> Configuration {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:67:29
[INFO] [stderr]    |
[INFO] [stderr] 67 | pub fn load_file(file_name: &String, format: &String) -> Configuration {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:67:46
[INFO] [stderr]    |
[INFO] [stderr] 67 | pub fn load_file(file_name: &String, format: &String) -> Configuration {
[INFO] [stderr]    |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.36s
[INFO] running `"docker" "inspect" "b890dc97af5fc441b8f27cefe4f93ca1bd98cbdad77f062f209127dc844631ed"`
[INFO] running `"docker" "rm" "-f" "b890dc97af5fc441b8f27cefe4f93ca1bd98cbdad77f062f209127dc844631ed"`
[INFO] [stdout] b890dc97af5fc441b8f27cefe4f93ca1bd98cbdad77f062f209127dc844631ed