[INFO] updating cached repository JoshRagem/pg_crunch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JoshRagem/pg_crunch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JoshRagem/pg_crunch" "work/ex/clippy-test-run/sources/stable/gh/JoshRagem/pg_crunch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JoshRagem/pg_crunch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JoshRagem/pg_crunch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshRagem/pg_crunch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshRagem/pg_crunch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b0c032715e18ff5bd453430993f8a4423d36e2d5 [INFO] sha for GitHub repo JoshRagem/pg_crunch: b0c032715e18ff5bd453430993f8a4423d36e2d5 [INFO] validating manifest of JoshRagem/pg_crunch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JoshRagem/pg_crunch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JoshRagem/pg_crunch [INFO] finished frobbing JoshRagem/pg_crunch [INFO] frobbed toml for JoshRagem/pg_crunch written to work/ex/clippy-test-run/sources/stable/gh/JoshRagem/pg_crunch/Cargo.toml [INFO] started frobbing JoshRagem/pg_crunch [INFO] finished frobbing JoshRagem/pg_crunch [INFO] frobbed toml for JoshRagem/pg_crunch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshRagem/pg_crunch/Cargo.toml [INFO] crate JoshRagem/pg_crunch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JoshRagem/pg_crunch against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JoshRagem/pg_crunch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf25f89b8a321b54e450b7a9a7377eb88a61fe427a58041fe2be0d4e46ec0661 [INFO] running `"docker" "start" "-a" "bf25f89b8a321b54e450b7a9a7377eb88a61fe427a58041fe2be0d4e46ec0661"` [INFO] [stderr] Checking csv v0.14.7 [INFO] [stderr] Checking pg_crunch v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scanner::CrunchState` [INFO] [stderr] --> src/scanner.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> CrunchState { [INFO] [stderr] 22 | | let csv_writer = Writer::from_writer(stdout()); [INFO] [stderr] 23 | | CrunchState::Scanning(HashMap::new(), csv_writer) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for scanner::CrunchState { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scanner.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | / match pid_to_query.remove(&pid) { [INFO] [stderr] 40 | | Some(full_query) => { [INFO] [stderr] 41 | | let qhash = hash_query(&full_query); [INFO] [stderr] 42 | | let result = csv_writer.encode((pid, duration, qhash, &full_query)); [INFO] [stderr] ... | [INFO] [stderr] 47 | | }, [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | if let Some(full_query) = pid_to_query.remove(&pid) { [INFO] [stderr] 40 | let qhash = hash_query(&full_query); [INFO] [stderr] 41 | let result = csv_writer.encode((pid, duration, qhash, &full_query)); [INFO] [stderr] 42 | assert!(result.is_ok()) [INFO] [stderr] 43 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scanner::CrunchState` [INFO] [stderr] --> src/scanner.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> CrunchState { [INFO] [stderr] 22 | | let csv_writer = Writer::from_writer(stdout()); [INFO] [stderr] 23 | | CrunchState::Scanning(HashMap::new(), csv_writer) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for scanner::CrunchState { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scanner.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | / match pid_to_query.remove(&pid) { [INFO] [stderr] 40 | | Some(full_query) => { [INFO] [stderr] 41 | | let qhash = hash_query(&full_query); [INFO] [stderr] 42 | | let result = csv_writer.encode((pid, duration, qhash, &full_query)); [INFO] [stderr] ... | [INFO] [stderr] 47 | | }, [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | if let Some(full_query) = pid_to_query.remove(&pid) { [INFO] [stderr] 40 | let qhash = hash_query(&full_query); [INFO] [stderr] 41 | let result = csv_writer.encode((pid, duration, qhash, &full_query)); [INFO] [stderr] 42 | assert!(result.is_ok()) [INFO] [stderr] 43 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.80s [INFO] running `"docker" "inspect" "bf25f89b8a321b54e450b7a9a7377eb88a61fe427a58041fe2be0d4e46ec0661"` [INFO] running `"docker" "rm" "-f" "bf25f89b8a321b54e450b7a9a7377eb88a61fe427a58041fe2be0d4e46ec0661"` [INFO] [stdout] bf25f89b8a321b54e450b7a9a7377eb88a61fe427a58041fe2be0d4e46ec0661