[INFO] updating cached repository JoshRagem/ddouble-agent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JoshRagem/ddouble-agent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JoshRagem/ddouble-agent" "work/ex/clippy-test-run/sources/stable/gh/JoshRagem/ddouble-agent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JoshRagem/ddouble-agent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JoshRagem/ddouble-agent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshRagem/ddouble-agent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshRagem/ddouble-agent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f94cfe228ea3bbcca166d6a0adeae16d9e5fa0a3 [INFO] sha for GitHub repo JoshRagem/ddouble-agent: f94cfe228ea3bbcca166d6a0adeae16d9e5fa0a3 [INFO] validating manifest of JoshRagem/ddouble-agent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JoshRagem/ddouble-agent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JoshRagem/ddouble-agent [INFO] finished frobbing JoshRagem/ddouble-agent [INFO] frobbed toml for JoshRagem/ddouble-agent written to work/ex/clippy-test-run/sources/stable/gh/JoshRagem/ddouble-agent/Cargo.toml [INFO] started frobbing JoshRagem/ddouble-agent [INFO] finished frobbing JoshRagem/ddouble-agent [INFO] frobbed toml for JoshRagem/ddouble-agent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshRagem/ddouble-agent/Cargo.toml [INFO] crate JoshRagem/ddouble-agent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JoshRagem/ddouble-agent against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JoshRagem/ddouble-agent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b70bda01f45d6345f2c5b223f28a80f7e572d3103ea2923d45750c38514a490 [INFO] running `"docker" "start" "-a" "6b70bda01f45d6345f2c5b223f28a80f7e572d3103ea2923d45750c38514a490"` [INFO] [stderr] Checking futures v0.1.11 [INFO] [stderr] Checking tokio-io v0.1.1 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking tokio-core v0.1.6 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking ddouble v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dogstats_codec.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return match str::from_utf8(&buf.as_ref()) { [INFO] [stderr] 14 | | Ok(s) => Ok((*addr, s.to_string())), [INFO] [stderr] 15 | | Err(_) => Err(io::Error::new(io::ErrorKind::Other, "invalid string")), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | match str::from_utf8(&buf.as_ref()) { [INFO] [stderr] 14 | Ok(s) => Ok((*addr, s.to_string())), [INFO] [stderr] 15 | Err(_) => Err(io::Error::new(io::ErrorKind::Other, "invalid string")), [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/dogstats_codec.rs:13:38 [INFO] [stderr] | [INFO] [stderr] 13 | return match str::from_utf8(&buf.as_ref()) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dogstats_codec.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return match str::from_utf8(&buf.as_ref()) { [INFO] [stderr] 14 | | Ok(s) => Ok((*addr, s.to_string())), [INFO] [stderr] 15 | | Err(_) => Err(io::Error::new(io::ErrorKind::Other, "invalid string")), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | match str::from_utf8(&buf.as_ref()) { [INFO] [stderr] 14 | Ok(s) => Ok((*addr, s.to_string())), [INFO] [stderr] 15 | Err(_) => Err(io::Error::new(io::ErrorKind::Other, "invalid string")), [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/dogstats_codec.rs:13:38 [INFO] [stderr] | [INFO] [stderr] 13 | return match str::from_utf8(&buf.as_ref()) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.67s [INFO] running `"docker" "inspect" "6b70bda01f45d6345f2c5b223f28a80f7e572d3103ea2923d45750c38514a490"` [INFO] running `"docker" "rm" "-f" "6b70bda01f45d6345f2c5b223f28a80f7e572d3103ea2923d45750c38514a490"` [INFO] [stdout] 6b70bda01f45d6345f2c5b223f28a80f7e572d3103ea2923d45750c38514a490