[INFO] updating cached repository JoshMarron/8080-disassembler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JoshMarron/8080-disassembler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JoshMarron/8080-disassembler" "work/ex/clippy-test-run/sources/stable/gh/JoshMarron/8080-disassembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JoshMarron/8080-disassembler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JoshMarron/8080-disassembler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshMarron/8080-disassembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshMarron/8080-disassembler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3eb30ccb86182dbf91b7e3e819a7c02f1d8cdd32 [INFO] sha for GitHub repo JoshMarron/8080-disassembler: 3eb30ccb86182dbf91b7e3e819a7c02f1d8cdd32 [INFO] validating manifest of JoshMarron/8080-disassembler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JoshMarron/8080-disassembler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JoshMarron/8080-disassembler [INFO] finished frobbing JoshMarron/8080-disassembler [INFO] frobbed toml for JoshMarron/8080-disassembler written to work/ex/clippy-test-run/sources/stable/gh/JoshMarron/8080-disassembler/Cargo.toml [INFO] started frobbing JoshMarron/8080-disassembler [INFO] finished frobbing JoshMarron/8080-disassembler [INFO] frobbed toml for JoshMarron/8080-disassembler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshMarron/8080-disassembler/Cargo.toml [INFO] crate JoshMarron/8080-disassembler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JoshMarron/8080-disassembler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JoshMarron/8080-disassembler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 04f6ec293ba4cbe713fe3204ba3596672d5bcc972a5bc51c865418083f8b2901 [INFO] running `"docker" "start" "-a" "04f6ec293ba4cbe713fe3204ba3596672d5bcc972a5bc51c865418083f8b2901"` [INFO] [stderr] Checking disassembler-8080 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:387:23 [INFO] [stderr] | [INFO] [stderr] 387 | let r1_mask = 0b00111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:388:23 [INFO] [stderr] | [INFO] [stderr] 388 | let r2_mask = 0b00000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:398:29 [INFO] [stderr] | [INFO] [stderr] 398 | let r1_mask = 0b00111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:406:23 [INFO] [stderr] | [INFO] [stderr] 406 | let r1_mask = 0b00000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:413:23 [INFO] [stderr] | [INFO] [stderr] 413 | let r1_mask = 0b00111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:414:23 [INFO] [stderr] | [INFO] [stderr] 414 | let r2_mask = 0b00000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:426:23 [INFO] [stderr] | [INFO] [stderr] 426 | let rp_mask = 0b00110000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:433:25 [INFO] [stderr] | [INFO] [stderr] 433 | let cond_mask = 0b00111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:387:23 [INFO] [stderr] | [INFO] [stderr] 387 | let r1_mask = 0b00111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:388:23 [INFO] [stderr] | [INFO] [stderr] 388 | let r2_mask = 0b00000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:398:29 [INFO] [stderr] | [INFO] [stderr] 398 | let r1_mask = 0b00111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:406:23 [INFO] [stderr] | [INFO] [stderr] 406 | let r1_mask = 0b00000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:413:23 [INFO] [stderr] | [INFO] [stderr] 413 | let r1_mask = 0b00111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:414:23 [INFO] [stderr] | [INFO] [stderr] 414 | let r2_mask = 0b00000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:426:23 [INFO] [stderr] | [INFO] [stderr] 426 | let rp_mask = 0b00110000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/disassembler.rs:433:25 [INFO] [stderr] | [INFO] [stderr] 433 | let cond_mask = 0b00111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/disassembler.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | 0x80...0x87 => { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/disassembler.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | 0x86 => { [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:25:62 [INFO] [stderr] | [INFO] [stderr] 25 | let rp_name = disassembler.get_register_pair(byte.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:29:57 [INFO] [stderr] | [INFO] [stderr] 29 | 0x40...0x7f if disassembler.is_mov_register(byte.clone()) => { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:33:66 [INFO] [stderr] | [INFO] [stderr] 33 | 0x46...0x7e if disassembler.has_destination_register(byte.clone()) => { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:37:61 [INFO] [stderr] | [INFO] [stderr] 37 | 0x70...0x77 if disassembler.has_source_register(byte.clone()) => { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:41:66 [INFO] [stderr] | [INFO] [stderr] 41 | 0x06...0x3e if disassembler.has_destination_register(byte.clone()) => { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:61:33 [INFO] [stderr] | [INFO] [stderr] 61 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:239:33 [INFO] [stderr] | [INFO] [stderr] 239 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:240:31 [INFO] [stderr] | [INFO] [stderr] 240 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:247:33 [INFO] [stderr] | [INFO] [stderr] 247 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:248:31 [INFO] [stderr] | [INFO] [stderr] 248 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:255:33 [INFO] [stderr] | [INFO] [stderr] 255 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:256:31 [INFO] [stderr] | [INFO] [stderr] 256 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:263:33 [INFO] [stderr] | [INFO] [stderr] 263 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:264:31 [INFO] [stderr] | [INFO] [stderr] 264 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:271:33 [INFO] [stderr] | [INFO] [stderr] 271 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:272:31 [INFO] [stderr] | [INFO] [stderr] 272 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:279:33 [INFO] [stderr] | [INFO] [stderr] 279 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:280:31 [INFO] [stderr] | [INFO] [stderr] 280 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/disassembler.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | 0x80...0x87 => { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/disassembler.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | 0x86 => { [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:25:62 [INFO] [stderr] | [INFO] [stderr] 25 | let rp_name = disassembler.get_register_pair(byte.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:29:57 [INFO] [stderr] | [INFO] [stderr] 29 | 0x40...0x7f if disassembler.is_mov_register(byte.clone()) => { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:33:66 [INFO] [stderr] | [INFO] [stderr] 33 | 0x46...0x7e if disassembler.has_destination_register(byte.clone()) => { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:37:61 [INFO] [stderr] | [INFO] [stderr] 37 | 0x70...0x77 if disassembler.has_source_register(byte.clone()) => { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/disassembler.rs:41:66 [INFO] [stderr] | [INFO] [stderr] 41 | 0x06...0x3e if disassembler.has_destination_register(byte.clone()) => { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:61:33 [INFO] [stderr] | [INFO] [stderr] 61 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:239:33 [INFO] [stderr] | [INFO] [stderr] 239 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:240:31 [INFO] [stderr] | [INFO] [stderr] 240 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:247:33 [INFO] [stderr] | [INFO] [stderr] 247 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:248:31 [INFO] [stderr] | [INFO] [stderr] 248 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:255:33 [INFO] [stderr] | [INFO] [stderr] 255 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:256:31 [INFO] [stderr] | [INFO] [stderr] 256 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:263:33 [INFO] [stderr] | [INFO] [stderr] 263 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:264:31 [INFO] [stderr] | [INFO] [stderr] 264 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:271:33 [INFO] [stderr] | [INFO] [stderr] 271 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:272:31 [INFO] [stderr] | [INFO] [stderr] 272 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:279:33 [INFO] [stderr] | [INFO] [stderr] 279 | let high_addr = (iter.next().unwrap() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(iter.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/disassembler.rs:280:31 [INFO] [stderr] | [INFO] [stderr] 280 | let address = low_addr as u16 + high_addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(low_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.63s [INFO] running `"docker" "inspect" "04f6ec293ba4cbe713fe3204ba3596672d5bcc972a5bc51c865418083f8b2901"` [INFO] running `"docker" "rm" "-f" "04f6ec293ba4cbe713fe3204ba3596672d5bcc972a5bc51c865418083f8b2901"` [INFO] [stdout] 04f6ec293ba4cbe713fe3204ba3596672d5bcc972a5bc51c865418083f8b2901