[INFO] updating cached repository JoshCheek/escape [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JoshCheek/escape [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JoshCheek/escape" "work/ex/clippy-test-run/sources/stable/gh/JoshCheek/escape"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JoshCheek/escape'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JoshCheek/escape" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshCheek/escape"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshCheek/escape'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 33c6af2e760b059a39ad3faaf1ee9367f2b7d8e3 [INFO] sha for GitHub repo JoshCheek/escape: 33c6af2e760b059a39ad3faaf1ee9367f2b7d8e3 [INFO] validating manifest of JoshCheek/escape on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JoshCheek/escape on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JoshCheek/escape [INFO] finished frobbing JoshCheek/escape [INFO] frobbed toml for JoshCheek/escape written to work/ex/clippy-test-run/sources/stable/gh/JoshCheek/escape/Cargo.toml [INFO] started frobbing JoshCheek/escape [INFO] finished frobbing JoshCheek/escape [INFO] frobbed toml for JoshCheek/escape written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshCheek/escape/Cargo.toml [INFO] crate JoshCheek/escape has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JoshCheek/escape against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JoshCheek/escape:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a44cef019fb9f0fb9d713f4e2d2a0a7f1b250ca874be4bcc6bfc0ed3ed3f3377 [INFO] running `"docker" "start" "-a" "a44cef019fb9f0fb9d713f4e2d2a0a7f1b250ca874be4bcc6bfc0ed3ed3f3377"` [INFO] [stderr] Checking escape v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | let writeres = write!(outstream, "\"{}\"\n", escape_string(input.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | let writeres = write!(outstream, "\"{}\"\n", escape_string(input.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / loop { [INFO] [stderr] 36 | | input.clear(); [INFO] [stderr] 37 | | let readres = instream.read_line(input); [INFO] [stderr] 38 | | (readres.is_err() || readres.ok() == Some(0)) && break; [INFO] [stderr] ... | [INFO] [stderr] 41 | | writeres.is_err() && break; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/lib.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | (readres.is_err() || readres.ok() == Some(0)) && break; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/lib.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | (readres.is_err() || readres.ok() == Some(0)) && break; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if (readres.is_err() || readres.ok() == Some(0)) { break; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::short_circuit_statement)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/lib.rs:38:58 [INFO] [stderr] | [INFO] [stderr] 38 | (readres.is_err() || readres.ok() == Some(0)) && break; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/lib.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | writeres.is_err() && break; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/lib.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | writeres.is_err() && break; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if writeres.is_err() { break; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/lib.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | writeres.is_err() && break; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `escape`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / loop { [INFO] [stderr] 36 | | input.clear(); [INFO] [stderr] 37 | | let readres = instream.read_line(input); [INFO] [stderr] 38 | | (readres.is_err() || readres.ok() == Some(0)) && break; [INFO] [stderr] ... | [INFO] [stderr] 41 | | writeres.is_err() && break; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/lib.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | (readres.is_err() || readres.ok() == Some(0)) && break; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/lib.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | (readres.is_err() || readres.ok() == Some(0)) && break; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if (readres.is_err() || readres.ok() == Some(0)) { break; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::short_circuit_statement)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/lib.rs:38:58 [INFO] [stderr] | [INFO] [stderr] 38 | (readres.is_err() || readres.ok() == Some(0)) && break; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/lib.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | writeres.is_err() && break; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/lib.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | writeres.is_err() && break; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `if writeres.is_err() { break; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/lib.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | writeres.is_err() && break; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `escape`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a44cef019fb9f0fb9d713f4e2d2a0a7f1b250ca874be4bcc6bfc0ed3ed3f3377"` [INFO] running `"docker" "rm" "-f" "a44cef019fb9f0fb9d713f4e2d2a0a7f1b250ca874be4bcc6bfc0ed3ed3f3377"` [INFO] [stdout] a44cef019fb9f0fb9d713f4e2d2a0a7f1b250ca874be4bcc6bfc0ed3ed3f3377