[INFO] updating cached repository JosephTLyons/serial_number_generator
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/JosephTLyons/serial_number_generator
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/JosephTLyons/serial_number_generator" "work/ex/clippy-test-run/sources/stable/gh/JosephTLyons/serial_number_generator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JosephTLyons/serial_number_generator'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/JosephTLyons/serial_number_generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JosephTLyons/serial_number_generator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JosephTLyons/serial_number_generator'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ad719a12ef9f6caa2ac68f6573c5fc37d1d34208
[INFO] sha for GitHub repo JosephTLyons/serial_number_generator: ad719a12ef9f6caa2ac68f6573c5fc37d1d34208
[INFO] validating manifest of JosephTLyons/serial_number_generator on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of JosephTLyons/serial_number_generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing JosephTLyons/serial_number_generator
[INFO] finished frobbing JosephTLyons/serial_number_generator
[INFO] frobbed toml for JosephTLyons/serial_number_generator written to work/ex/clippy-test-run/sources/stable/gh/JosephTLyons/serial_number_generator/Cargo.toml
[INFO] started frobbing JosephTLyons/serial_number_generator
[INFO] finished frobbing JosephTLyons/serial_number_generator
[INFO] frobbed toml for JosephTLyons/serial_number_generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JosephTLyons/serial_number_generator/Cargo.toml
[INFO] crate JosephTLyons/serial_number_generator has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting JosephTLyons/serial_number_generator against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JosephTLyons/serial_number_generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d7263ea4bb874fa96060d55fb9872542ca66e7ea2e0894f03caf8b6f35fb2b8a
[INFO] running `"docker" "start" "-a" "d7263ea4bb874fa96060d55fb9872542ca66e7ea2e0894f03caf8b6f35fb2b8a"`
[INFO] [stderr]     Checking serial_number_generator v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     return total;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `total`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for x in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'0' as u8..='9' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for x in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'0'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:26:29
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for x in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                             ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'9'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for x in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'A' as u8..='Z' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for x in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:32:29
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for x in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                             ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:38:18
[INFO] [stderr]    |
[INFO] [stderr] 38 |         for x in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'a' as u8..='z' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:38:18
[INFO] [stderr]    |
[INFO] [stderr] 38 |         for x in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:38:29
[INFO] [stderr]    |
[INFO] [stderr] 38 |         for x in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                             ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |             serial_file.write (single_serial_number_string.as_bytes()).expect ("Coult not write to file");
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `vec`.
[INFO] [stderr]   --> src/main.rs:80:22
[INFO] [stderr]    |
[INFO] [stderr] 80 |             for x in 0..vec.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 80 |             for <item> in &vec {
[INFO] [stderr]    |                 ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `serial_number_generator`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     return total;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `total`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for x in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'0' as u8..='9' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for x in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'0'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:26:29
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for x in '0' as u8..'9' as u8 + 1 {
[INFO] [stderr]    |                             ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'9'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for x in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'A' as u8..='Z' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for x in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:32:29
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for x in 'A' as u8..'Z' as u8 + 1 {
[INFO] [stderr]    |                             ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:38:18
[INFO] [stderr]    |
[INFO] [stderr] 38 |         for x in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `'a' as u8..='z' as u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:38:18
[INFO] [stderr]    |
[INFO] [stderr] 38 |         for x in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/main.rs:38:29
[INFO] [stderr]    |
[INFO] [stderr] 38 |         for x in 'a' as u8..'z' as u8 + 1 {
[INFO] [stderr]    |                             ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |             serial_file.write (single_serial_number_string.as_bytes()).expect ("Coult not write to file");
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is only used to index `vec`.
[INFO] [stderr]   --> src/main.rs:80:22
[INFO] [stderr]    |
[INFO] [stderr] 80 |             for x in 0..vec.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 80 |             for <item> in &vec {
[INFO] [stderr]    |                 ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `serial_number_generator`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "d7263ea4bb874fa96060d55fb9872542ca66e7ea2e0894f03caf8b6f35fb2b8a"`
[INFO] running `"docker" "rm" "-f" "d7263ea4bb874fa96060d55fb9872542ca66e7ea2e0894f03caf8b6f35fb2b8a"`
[INFO] [stdout] d7263ea4bb874fa96060d55fb9872542ca66e7ea2e0894f03caf8b6f35fb2b8a