[INFO] updating cached repository JosephTLyons/ascii_clock [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JosephTLyons/ascii_clock [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JosephTLyons/ascii_clock" "work/ex/clippy-test-run/sources/stable/gh/JosephTLyons/ascii_clock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JosephTLyons/ascii_clock'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JosephTLyons/ascii_clock" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JosephTLyons/ascii_clock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JosephTLyons/ascii_clock'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eecfc9e38cde55d42108bab2a0b145e9aff5c0ba [INFO] sha for GitHub repo JosephTLyons/ascii_clock: eecfc9e38cde55d42108bab2a0b145e9aff5c0ba [INFO] validating manifest of JosephTLyons/ascii_clock on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JosephTLyons/ascii_clock on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JosephTLyons/ascii_clock [INFO] finished frobbing JosephTLyons/ascii_clock [INFO] frobbed toml for JosephTLyons/ascii_clock written to work/ex/clippy-test-run/sources/stable/gh/JosephTLyons/ascii_clock/Cargo.toml [INFO] started frobbing JosephTLyons/ascii_clock [INFO] finished frobbing JosephTLyons/ascii_clock [INFO] frobbed toml for JosephTLyons/ascii_clock written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JosephTLyons/ascii_clock/Cargo.toml [INFO] crate JosephTLyons/ascii_clock has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JosephTLyons/ascii_clock against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JosephTLyons/ascii_clock:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8dae1f1e6e7910f58f1d130da90236c59b6b2937fe7b25c4387a56e452624a0a [INFO] running `"docker" "start" "-a" "8dae1f1e6e7910f58f1d130da90236c59b6b2937fe7b25c4387a56e452624a0a"` [INFO] [stderr] Checking ascii_clock v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | return "Saturday".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Saturday".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | return "December".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"December".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `number_colon` [INFO] [stderr] --> src/main.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | for row in 0..number_zero.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for (row, ) in number_colon.iter().enumerate().take(number_zero.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | return "Saturday".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Saturday".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | return "December".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"December".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `number_colon` [INFO] [stderr] --> src/main.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | for row in 0..number_zero.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for (row, ) in number_colon.iter().enumerate().take(number_zero.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "8dae1f1e6e7910f58f1d130da90236c59b6b2937fe7b25c4387a56e452624a0a"` [INFO] running `"docker" "rm" "-f" "8dae1f1e6e7910f58f1d130da90236c59b6b2937fe7b25c4387a56e452624a0a"` [INFO] [stdout] 8dae1f1e6e7910f58f1d130da90236c59b6b2937fe7b25c4387a56e452624a0a