[INFO] updating cached repository JonathanVusich/monty_hall_simulator_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JonathanVusich/monty_hall_simulator_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JonathanVusich/monty_hall_simulator_rust" "work/ex/clippy-test-run/sources/stable/gh/JonathanVusich/monty_hall_simulator_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JonathanVusich/monty_hall_simulator_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JonathanVusich/monty_hall_simulator_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonathanVusich/monty_hall_simulator_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonathanVusich/monty_hall_simulator_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc809d857a28b733469afa7745d7927d06d057f7 [INFO] sha for GitHub repo JonathanVusich/monty_hall_simulator_rust: cc809d857a28b733469afa7745d7927d06d057f7 [INFO] validating manifest of JonathanVusich/monty_hall_simulator_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JonathanVusich/monty_hall_simulator_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JonathanVusich/monty_hall_simulator_rust [INFO] finished frobbing JonathanVusich/monty_hall_simulator_rust [INFO] frobbed toml for JonathanVusich/monty_hall_simulator_rust written to work/ex/clippy-test-run/sources/stable/gh/JonathanVusich/monty_hall_simulator_rust/Cargo.toml [INFO] started frobbing JonathanVusich/monty_hall_simulator_rust [INFO] finished frobbing JonathanVusich/monty_hall_simulator_rust [INFO] frobbed toml for JonathanVusich/monty_hall_simulator_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonathanVusich/monty_hall_simulator_rust/Cargo.toml [INFO] crate JonathanVusich/monty_hall_simulator_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JonathanVusich/monty_hall_simulator_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JonathanVusich/monty_hall_simulator_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f1e58e3a314254499cc101981ab68b752d0577fac59dd73dece54f64e0f9060 [INFO] running `"docker" "start" "-a" "9f1e58e3a314254499cc101981ab68b752d0577fac59dd73dece54f64e0f9060"` [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] Checking monty_hall_simulator_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:10:48 [INFO] [stderr] | [INFO] [stderr] 10 | println!("{:?}", generate_successes(false, 100000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return successes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `successes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 25 | | if static_door_set[door_set[x]][door_choice[x]] == 0 { [INFO] [stderr] 26 | | successes+=1; [INFO] [stderr] 27 | | }; [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | } else if static_door_set[door_set[x]][door_choice[x]] == 0 { [INFO] [stderr] 25 | successes+=1; [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return random_vec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `random_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:10:48 [INFO] [stderr] | [INFO] [stderr] 10 | println!("{:?}", generate_successes(false, 100000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return successes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `successes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 25 | | if static_door_set[door_set[x]][door_choice[x]] == 0 { [INFO] [stderr] 26 | | successes+=1; [INFO] [stderr] 27 | | }; [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | } else if static_door_set[door_set[x]][door_choice[x]] == 0 { [INFO] [stderr] 25 | successes+=1; [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return random_vec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `random_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.74s [INFO] running `"docker" "inspect" "9f1e58e3a314254499cc101981ab68b752d0577fac59dd73dece54f64e0f9060"` [INFO] running `"docker" "rm" "-f" "9f1e58e3a314254499cc101981ab68b752d0577fac59dd73dece54f64e0f9060"` [INFO] [stdout] 9f1e58e3a314254499cc101981ab68b752d0577fac59dd73dece54f64e0f9060