[INFO] updating cached repository JonathanUsername/wavtojson [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JonathanUsername/wavtojson [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JonathanUsername/wavtojson" "work/ex/clippy-test-run/sources/stable/gh/JonathanUsername/wavtojson"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JonathanUsername/wavtojson'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JonathanUsername/wavtojson" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonathanUsername/wavtojson"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonathanUsername/wavtojson'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 97197e2c2aae93e0e345b221780bfb69b1025079 [INFO] sha for GitHub repo JonathanUsername/wavtojson: 97197e2c2aae93e0e345b221780bfb69b1025079 [INFO] validating manifest of JonathanUsername/wavtojson on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JonathanUsername/wavtojson on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JonathanUsername/wavtojson [INFO] finished frobbing JonathanUsername/wavtojson [INFO] frobbed toml for JonathanUsername/wavtojson written to work/ex/clippy-test-run/sources/stable/gh/JonathanUsername/wavtojson/Cargo.toml [INFO] started frobbing JonathanUsername/wavtojson [INFO] finished frobbing JonathanUsername/wavtojson [INFO] frobbed toml for JonathanUsername/wavtojson written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonathanUsername/wavtojson/Cargo.toml [INFO] crate JonathanUsername/wavtojson has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JonathanUsername/wavtojson against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JonathanUsername/wavtojson:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 833f5ceba6d8d7a157f6c8748851b533a2c516fd1c9a28f8d2ae81b4388f8e30 [INFO] running `"docker" "start" "-a" "833f5ceba6d8d7a157f6c8748851b533a2c516fd1c9a28f8d2ae81b4388f8e30"` [INFO] [stderr] Checking hound v3.3.0 [INFO] [stderr] Checking wavtojson v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:3 [INFO] [stderr] | [INFO] [stderr] 87 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | resolution: resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:87:3 [INFO] [stderr] | [INFO] [stderr] 87 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | resolution: resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | match samples.next() { [INFO] [stderr] | _____________^ [INFO] [stderr] 66 | | Some(Ok(sample)) => { [INFO] [stderr] 67 | | let diff: i32 = sample - prev; [INFO] [stderr] 68 | | sum += diff.abs() as u32; [INFO] [stderr] ... | [INFO] [stderr] 71 | | _ => () // Skip if null [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(Ok(sample)) = samples.next() { [INFO] [stderr] 66 | let diff: i32 = sample - prev; [INFO] [stderr] 67 | sum += diff.abs() as u32; [INFO] [stderr] 68 | prev = sample; [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | match samples.next() { [INFO] [stderr] | _____________^ [INFO] [stderr] 66 | | Some(Ok(sample)) => { [INFO] [stderr] 67 | | let diff: i32 = sample - prev; [INFO] [stderr] 68 | | sum += diff.abs() as u32; [INFO] [stderr] ... | [INFO] [stderr] 71 | | _ => () // Skip if null [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(Ok(sample)) = samples.next() { [INFO] [stderr] 66 | let diff: i32 = sample - prev; [INFO] [stderr] 67 | sum += diff.abs() as u32; [INFO] [stderr] 68 | prev = sample; [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.58s [INFO] running `"docker" "inspect" "833f5ceba6d8d7a157f6c8748851b533a2c516fd1c9a28f8d2ae81b4388f8e30"` [INFO] running `"docker" "rm" "-f" "833f5ceba6d8d7a157f6c8748851b533a2c516fd1c9a28f8d2ae81b4388f8e30"` [INFO] [stdout] 833f5ceba6d8d7a157f6c8748851b533a2c516fd1c9a28f8d2ae81b4388f8e30