[INFO] updating cached repository JonW27/inji [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JonW27/inji [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JonW27/inji" "work/ex/clippy-test-run/sources/stable/gh/JonW27/inji"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JonW27/inji'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JonW27/inji" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonW27/inji"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonW27/inji'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32e65c3464f63afd175c3a208921679905fb3959 [INFO] sha for GitHub repo JonW27/inji: 32e65c3464f63afd175c3a208921679905fb3959 [INFO] validating manifest of JonW27/inji on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JonW27/inji on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JonW27/inji [INFO] finished frobbing JonW27/inji [INFO] frobbed toml for JonW27/inji written to work/ex/clippy-test-run/sources/stable/gh/JonW27/inji/Cargo.toml [INFO] started frobbing JonW27/inji [INFO] finished frobbing JonW27/inji [INFO] frobbed toml for JonW27/inji written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JonW27/inji/Cargo.toml [INFO] crate JonW27/inji has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JonW27/inji against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JonW27/inji:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4103d1699cd26c91778c22698050da7f9da0bfc45588a2efddef4cac6961dc65 [INFO] running `"docker" "start" "-a" "4103d1699cd26c91778c22698050da7f9da0bfc45588a2efddef4cac6961dc65"` [INFO] [stderr] Checking inji v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | let (l, mut k) = (p.lastcol - 2, 0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | let i = k as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | let n : [f64; 3] = get_surface_normal(p, i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/matrix.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | let (l, mut k) = (p.lastcol - 2, 0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | let i = k as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | let n : [f64; 3] = get_surface_normal(p, i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/matrix.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return zbuf; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `zbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return screen; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `screen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return zbuf; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `zbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return screen; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `screen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/draw.rs:105:87 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn draw_polygons(p : &mut Matrix, s : &mut Vec>, zb : &mut zbuffer, c : [i64; 3], to_backface_cull : bool){ [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/draw.rs:105:87 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn draw_polygons(p : &mut Matrix, s : &mut Vec>, zb : &mut zbuffer, c : [i64; 3], to_backface_cull : bool){ [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/display.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | &zbuf[tmp].push(0.); // equiv to what calloc does [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zbuf[tmp].push(0.);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/display.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | &screen[tmp].push(DEFAULT_COLOR); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen[tmp].push(DEFAULT_COLOR);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/display.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | pic.write(ppm.as_bytes()).expect("Could not write to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/display.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | &zbuf[tmp].push(0.); // equiv to what calloc does [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zbuf[tmp].push(0.);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/display.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | &screen[tmp].push(DEFAULT_COLOR); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen[tmp].push(DEFAULT_COLOR);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/draw.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn add_polygon(polygons : &mut Matrix, x0 : f64, y0 : f64, z0 : f64, x1 : f64, y1 : f64, z1 : f64, x2 : f64, y2 : f64, z2 : f64){ [INFO] [stderr] 100 | | add_point(polygons, x0, y0, z0); [INFO] [stderr] 101 | | add_point(polygons, x1, y1, z1); [INFO] [stderr] 102 | | add_point(polygons, x2, y2, z2); [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/display.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | pic.write(ppm.as_bytes()).expect("Could not write to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/draw.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn add_polygon(polygons : &mut Matrix, x0 : f64, y0 : f64, z0 : f64, x1 : f64, y1 : f64, z1 : f64, x2 : f64, y2 : f64, z2 : f64){ [INFO] [stderr] 100 | | add_point(polygons, x0, y0, z0); [INFO] [stderr] 101 | | add_point(polygons, x1, y1, z1); [INFO] [stderr] 102 | | add_point(polygons, x2, y2, z2); [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/draw.rs:201:18 [INFO] [stderr] | [INFO] [stderr] 201 | for j in 0..step+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/draw.rs:237:18 [INFO] [stderr] | [INFO] [stderr] 237 | for j in 0..step+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/draw.rs:264:1 [INFO] [stderr] | [INFO] [stderr] 264 | / pub fn add_curve( points : &mut Matrix, mut x0 : f64, mut y0 : f64, x1 : f64, y1 : f64, x2 : f64, y2 : f64, x3 : f64, y3 : f64, step : f64, curve_type : i64){ [INFO] [stderr] 265 | | let x_coefs = generate_curve_coefs(x0, x1, x2, x3, curve_type); [INFO] [stderr] 266 | | let y_coefs = generate_curve_coefs(y0, y1, y2, y3, curve_type); [INFO] [stderr] 267 | | let step = step as i64 * 100; [INFO] [stderr] ... | [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/draw.rs:201:18 [INFO] [stderr] | [INFO] [stderr] 201 | for j in 0..step+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:309:24 [INFO] [stderr] | [INFO] [stderr] 309 | past_point_x = m[0][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[0][i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:310:24 [INFO] [stderr] | [INFO] [stderr] 310 | past_point_y = m[1][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[1][i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:311:24 [INFO] [stderr] | [INFO] [stderr] 311 | past_point_z = m[2][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[2][i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/draw.rs:315:1 [INFO] [stderr] | [INFO] [stderr] 315 | / pub fn draw_line( mut x0 : i64, mut y0 : i64, mut z0 : f64, x1 : i64, y1 : i64, mut z1 : f64, s : &mut Vec>, zb : &mut zbuffer, c : [i64; 3] ){ [INFO] [stderr] 316 | | if x0 > x1 { return draw_line(x1, y1, z1, x0, y0, z0, s, zb, c); } [INFO] [stderr] 317 | | let (mut d, mut A, mut B, mut dy_east, mut dy_northeast, mut dx_east, mut dx_northeast, mut d_east, mut d_northeast, mut loop_start, mut loop_end) : (i64, i64, i64, i64, i64, i64, i64, i64, i64, i64, i64); [INFO] [stderr] 318 | | let (mut wide, mut tall) = (false, false); [INFO] [stderr] ... | [INFO] [stderr] 381 | | display::plot( s, zb, c, x1, y1, z1 ); [INFO] [stderr] 382 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/draw.rs:359:22 [INFO] [stderr] | [INFO] [stderr] 359 | d_east = -1 * B; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/draw.rs:237:18 [INFO] [stderr] | [INFO] [stderr] 237 | for j in 0..step+1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/draw.rs:264:1 [INFO] [stderr] | [INFO] [stderr] 264 | / pub fn add_curve( points : &mut Matrix, mut x0 : f64, mut y0 : f64, x1 : f64, y1 : f64, x2 : f64, y2 : f64, x3 : f64, y3 : f64, step : f64, curve_type : i64){ [INFO] [stderr] 265 | | let x_coefs = generate_curve_coefs(x0, x1, x2, x3, curve_type); [INFO] [stderr] 266 | | let y_coefs = generate_curve_coefs(y0, y1, y2, y3, curve_type); [INFO] [stderr] 267 | | let step = step as i64 * 100; [INFO] [stderr] ... | [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:309:24 [INFO] [stderr] | [INFO] [stderr] 309 | past_point_x = m[0][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[0][i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:310:24 [INFO] [stderr] | [INFO] [stderr] 310 | past_point_y = m[1][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[1][i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/draw.rs:311:24 [INFO] [stderr] | [INFO] [stderr] 311 | past_point_z = m[2][i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `m[2][i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/draw.rs:315:1 [INFO] [stderr] | [INFO] [stderr] 315 | / pub fn draw_line( mut x0 : i64, mut y0 : i64, mut z0 : f64, x1 : i64, y1 : i64, mut z1 : f64, s : &mut Vec>, zb : &mut zbuffer, c : [i64; 3] ){ [INFO] [stderr] 316 | | if x0 > x1 { return draw_line(x1, y1, z1, x0, y0, z0, s, zb, c); } [INFO] [stderr] 317 | | let (mut d, mut A, mut B, mut dy_east, mut dy_northeast, mut dx_east, mut dx_northeast, mut d_east, mut d_northeast, mut loop_start, mut loop_end) : (i64, i64, i64, i64, i64, i64, i64, i64, i64, i64, i64); [INFO] [stderr] 318 | | let (mut wide, mut tall) = (false, false); [INFO] [stderr] ... | [INFO] [stderr] 381 | | display::plot( s, zb, c, x1, y1, z1 ); [INFO] [stderr] 382 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/draw.rs:359:22 [INFO] [stderr] | [INFO] [stderr] 359 | d_east = -1 * B; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/matrix.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | &tmp[tmp_a].push(0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tmp[tmp_a].push(0.);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/matrix.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | &tmp[tmp_a].push(0.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tmp[tmp_a].push(0.);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: The function/method `print_matrix` doesn't need a mutable reference [INFO] [stderr] --> src/parser.rs:47:66 [INFO] [stderr] | [INFO] [stderr] 47 | Some(x) => { stack.push(x.clone()); print_matrix(&mut x.clone())}, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:59:43 [INFO] [stderr] | [INFO] [stderr] 59 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:75:43 [INFO] [stderr] | [INFO] [stderr] 75 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:82:43 [INFO] [stderr] | [INFO] [stderr] 82 | let args = lines[cnt+1].split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:106:43 [INFO] [stderr] | [INFO] [stderr] 106 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:114:43 [INFO] [stderr] | [INFO] [stderr] 114 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: The function/method `print_matrix` doesn't need a mutable reference [INFO] [stderr] --> src/parser.rs:47:66 [INFO] [stderr] | [INFO] [stderr] 47 | Some(x) => { stack.push(x.clone()); print_matrix(&mut x.clone())}, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:59:43 [INFO] [stderr] | [INFO] [stderr] 59 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:122:43 [INFO] [stderr] | [INFO] [stderr] 122 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:130:43 [INFO] [stderr] | [INFO] [stderr] 130 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:75:43 [INFO] [stderr] | [INFO] [stderr] 75 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:82:43 [INFO] [stderr] | [INFO] [stderr] 82 | let args = lines[cnt+1].split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:138:43 [INFO] [stderr] | [INFO] [stderr] 138 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:146:43 [INFO] [stderr] | [INFO] [stderr] 146 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:106:43 [INFO] [stderr] | [INFO] [stderr] 106 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:114:43 [INFO] [stderr] | [INFO] [stderr] 114 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:122:43 [INFO] [stderr] | [INFO] [stderr] 122 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:130:43 [INFO] [stderr] | [INFO] [stderr] 130 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:138:43 [INFO] [stderr] | [INFO] [stderr] 138 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:146:43 [INFO] [stderr] | [INFO] [stderr] 146 | let args = lines[cnt+1].split(" ").map(|l| l.parse::().unwrap()).collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: Could not compile `inji`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `inji`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4103d1699cd26c91778c22698050da7f9da0bfc45588a2efddef4cac6961dc65"` [INFO] running `"docker" "rm" "-f" "4103d1699cd26c91778c22698050da7f9da0bfc45588a2efddef4cac6961dc65"` [INFO] [stdout] 4103d1699cd26c91778c22698050da7f9da0bfc45588a2efddef4cac6961dc65