[INFO] updating cached repository Jokler/AdventOfCode [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Jokler/AdventOfCode [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Jokler/AdventOfCode" "work/ex/clippy-test-run/sources/stable/gh/Jokler/AdventOfCode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jokler/AdventOfCode'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Jokler/AdventOfCode" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jokler/AdventOfCode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jokler/AdventOfCode'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e2359ef9ba145dc9f3d411a3c824b3b5e70f51f5 [INFO] sha for GitHub repo Jokler/AdventOfCode: e2359ef9ba145dc9f3d411a3c824b3b5e70f51f5 [INFO] validating manifest of Jokler/AdventOfCode on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Jokler/AdventOfCode on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Jokler/AdventOfCode [INFO] finished frobbing Jokler/AdventOfCode [INFO] frobbed toml for Jokler/AdventOfCode written to work/ex/clippy-test-run/sources/stable/gh/Jokler/AdventOfCode/Cargo.toml [INFO] started frobbing Jokler/AdventOfCode [INFO] finished frobbing Jokler/AdventOfCode [INFO] frobbed toml for Jokler/AdventOfCode written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jokler/AdventOfCode/Cargo.toml [INFO] crate Jokler/AdventOfCode has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Jokler/AdventOfCode against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Jokler/AdventOfCode:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30a71deef1f2867e0fae90a3428f37661f6e4d4c9c4fe616b60ed833a5f93666 [INFO] running `"docker" "start" "-a" "30a71deef1f2867e0fae90a3428f37661f6e4d4c9c4fe616b60ed833a5f93666"` [INFO] [stderr] Checking itertools v0.7.4 [INFO] [stderr] Checking adventofcode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/three.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | let field = Field { x: x, y: y, i: i }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/three.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | let field = Field { x: x, y: y, i: i }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/three.rs:100:41 [INFO] [stderr] | [INFO] [stderr] 100 | let field = Field { x: x, y: y, i: i }; [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/seven.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/seven.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/three.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | let field = Field { x: x, y: y, i: i }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/three.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | let field = Field { x: x, y: y, i: i }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/three.rs:100:41 [INFO] [stderr] | [INFO] [stderr] 100 | let field = Field { x: x, y: y, i: i }; [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/seven.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seventeen/seven.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/seventeen/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub mod seventeen; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/seventeen/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub mod seventeen; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/seventeen/one.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | result += u8::from_str(&c.to_string()).unwrap() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::from_str(&c.to_string()).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/seventeen/one.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | result += u8::from_str(&c.to_string()).unwrap() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::from_str(&c.to_string()).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/two.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | let rows = input.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/two.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | let rows = input.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/three.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | fn next_val(v: &Vec, x: i32, y: i32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/three.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | fn print_spiral(spiral: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/seventeen/three.rs:125:14 [INFO] [stderr] | [INFO] [stderr] 125 | for i in -min..(min + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `-min..=min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/four.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/four.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/five.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/five.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/seventeen/six.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | let (mut curr, max) = nums.iter() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 27 | | .map(|n| *n) [INFO] [stderr] | |________________________^ help: Consider calling the dedicated `cloned` method: `nums.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/seventeen/six.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | let (mut curr, max) = nums.iter() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 73 | | .map(|n| *n) [INFO] [stderr] | |________________________^ help: Consider calling the dedicated `cloned` method: `nums.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/seven.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | fn get_root(nodes: &Vec) -> &Node { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/seven.rs:66:29 [INFO] [stderr] | [INFO] [stderr] 66 | for line in input.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/seven.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | fn find_child<'a>(nodes: &'a Vec, name: &str) -> &'a Node { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/seventeen/seven.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | nodes.iter().find(|n| &n.name == name).expect("Missing child") [INFO] [stderr] | -------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `n.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/seven.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | fn find_error_dist(nodes: &Vec, root: Node, debug: bool) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/seven.rs:123:29 [INFO] [stderr] | [INFO] [stderr] 123 | for line in input.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/eight.rs:70:29 [INFO] [stderr] | [INFO] [stderr] 70 | for line in input.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/eight.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | for line in input.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/seventeen/seventeen.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 1..(2017 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=2017` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/seventeen/seventeen.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 1..(50_000_000 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=50_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | _ => String::from(format!("There is no code for day {}.", opt.day)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("There is no code for day {}.", opt.day)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | _ => String::from(format!("There is no code for day {}.", opt.day)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("There is no code for day {}.", opt.day)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | _ => String::from(format!("There is no code for year {}.", opt.year)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("There is no code for year {}.", opt.year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/seventeen/one.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | result += u8::from_str(&c.to_string()).unwrap() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::from_str(&c.to_string()).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/seventeen/one.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | result += u8::from_str(&c.to_string()).unwrap() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::from_str(&c.to_string()).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/two.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | let rows = input.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/two.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | let rows = input.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/three.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | fn next_val(v: &Vec, x: i32, y: i32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/three.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | fn print_spiral(spiral: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/seventeen/three.rs:125:14 [INFO] [stderr] | [INFO] [stderr] 125 | for i in -min..(min + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `-min..=min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/four.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/four.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/five.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/five.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/seventeen/six.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | let (mut curr, max) = nums.iter() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 27 | | .map(|n| *n) [INFO] [stderr] | |________________________^ help: Consider calling the dedicated `cloned` method: `nums.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/seventeen/six.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | let (mut curr, max) = nums.iter() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 73 | | .map(|n| *n) [INFO] [stderr] | |________________________^ help: Consider calling the dedicated `cloned` method: `nums.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/seven.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | fn get_root(nodes: &Vec) -> &Node { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/seven.rs:66:29 [INFO] [stderr] | [INFO] [stderr] 66 | for line in input.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/seven.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | fn find_child<'a>(nodes: &'a Vec, name: &str) -> &'a Node { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/seventeen/seven.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | nodes.iter().find(|n| &n.name == name).expect("Missing child") [INFO] [stderr] | -------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `n.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/seventeen/seven.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | fn find_error_dist(nodes: &Vec, root: Node, debug: bool) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/seven.rs:123:29 [INFO] [stderr] | [INFO] [stderr] 123 | for line in input.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/eight.rs:70:29 [INFO] [stderr] | [INFO] [stderr] 70 | for line in input.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/seventeen/eight.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | for line in input.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/seventeen/seventeen.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 1..(2017 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=2017` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/seventeen/seventeen.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 1..(50_000_000 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=50_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | _ => String::from(format!("There is no code for day {}.", opt.day)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("There is no code for day {}.", opt.day)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | _ => String::from(format!("There is no code for day {}.", opt.day)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("There is no code for day {}.", opt.day)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | _ => String::from(format!("There is no code for year {}.", opt.year)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("There is no code for year {}.", opt.year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.46s [INFO] running `"docker" "inspect" "30a71deef1f2867e0fae90a3428f37661f6e4d4c9c4fe616b60ed833a5f93666"` [INFO] running `"docker" "rm" "-f" "30a71deef1f2867e0fae90a3428f37661f6e4d4c9c4fe616b60ed833a5f93666"` [INFO] [stdout] 30a71deef1f2867e0fae90a3428f37661f6e4d4c9c4fe616b60ed833a5f93666