[INFO] updating cached repository JohnHMoses/ray-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/JohnHMoses/ray-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/JohnHMoses/ray-rs" "work/ex/clippy-test-run/sources/stable/gh/JohnHMoses/ray-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JohnHMoses/ray-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/JohnHMoses/ray-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JohnHMoses/ray-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JohnHMoses/ray-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fd167048f27527f97148dbba26ae8d78e92c4bbc
[INFO] sha for GitHub repo JohnHMoses/ray-rs: fd167048f27527f97148dbba26ae8d78e92c4bbc
[INFO] validating manifest of JohnHMoses/ray-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of JohnHMoses/ray-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing JohnHMoses/ray-rs
[INFO] finished frobbing JohnHMoses/ray-rs
[INFO] frobbed toml for JohnHMoses/ray-rs written to work/ex/clippy-test-run/sources/stable/gh/JohnHMoses/ray-rs/Cargo.toml
[INFO] started frobbing JohnHMoses/ray-rs
[INFO] finished frobbing JohnHMoses/ray-rs
[INFO] frobbed toml for JohnHMoses/ray-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JohnHMoses/ray-rs/Cargo.toml
[INFO] crate JohnHMoses/ray-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting JohnHMoses/ray-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JohnHMoses/ray-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d7537c0f60a3bb447712207c9e32047d2fa225b01864e55914ae2b099281426d
[INFO] running `"docker" "start" "-a" "d7537c0f60a3bb447712207c9e32047d2fa225b01864e55914ae2b099281426d"`
[INFO] [stderr]     Checking image v0.15.0
[INFO] [stderr]     Checking ray_rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:158:9
[INFO] [stderr]     |
[INFO] [stderr] 158 |         return None
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:217:17
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 return true;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:219:17
[INFO] [stderr]     |
[INFO] [stderr] 219 |                 return false;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `RayTokenizer`
[INFO] [stderr]   --> src/parser/ray_scene_builder/mod.rs:14:28
[INFO] [stderr]    |
[INFO] [stderr] 14 | use super::ray_tokenizer::{RayTokenizer, Readable, Token};
[INFO] [stderr]    |                            ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser/error.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return self.message.as_ref();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.message.as_ref()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::rc::Weak`
[INFO] [stderr]  --> src/scene/mod.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::rc::Weak;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:158:9
[INFO] [stderr]     |
[INFO] [stderr] 158 |         return None
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:217:17
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 return true;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:219:17
[INFO] [stderr]     |
[INFO] [stderr] 219 |                 return false;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `RayTokenizer`
[INFO] [stderr]   --> src/parser/ray_scene_builder/mod.rs:14:28
[INFO] [stderr]    |
[INFO] [stderr] 14 | use super::ray_tokenizer::{RayTokenizer, Readable, Token};
[INFO] [stderr]    |                            ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser/error.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return self.message.as_ref();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.message.as_ref()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::rc::Weak`
[INFO] [stderr]  --> src/scene/mod.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::rc::Weak;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:407:29
[INFO] [stderr]     |
[INFO] [stderr] 407 | fn parse_boolean_expression(tokenizer: &mut Tokenizer) -> Result<bool> {
[INFO] [stderr]     |                             ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:411:28
[INFO] [stderr]     |
[INFO] [stderr] 411 | fn parse_scalar_expression(tokenizer: &mut Tokenizer) -> Result<f64> {
[INFO] [stderr]     |                            ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:415:29
[INFO] [stderr]     |
[INFO] [stderr] 415 | fn parse_vector4_expression(tokenizer: &mut Tokenizer) -> Result<Vector4<f64>> {
[INFO] [stderr]     |                             ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:419:18
[INFO] [stderr]     |
[INFO] [stderr] 419 | fn parse_boolean(tokenizer: &mut Tokenizer) -> Result<bool> {
[INFO] [stderr]     |                  ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:423:17
[INFO] [stderr]     |
[INFO] [stderr] 423 | fn parse_scalar(tokenizer: &mut Tokenizer) -> Result<f64> {
[INFO] [stderr]     |                 ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:427:18
[INFO] [stderr]     |
[INFO] [stderr] 427 | fn parse_vector4(tokenizer: &mut Tokenizer) -> Result<Vector4<f64>> {
[INFO] [stderr]     |                  ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:407:29
[INFO] [stderr]     |
[INFO] [stderr] 407 | fn parse_boolean_expression(tokenizer: &mut Tokenizer) -> Result<bool> {
[INFO] [stderr]     |                             ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:411:28
[INFO] [stderr]     |
[INFO] [stderr] 411 | fn parse_scalar_expression(tokenizer: &mut Tokenizer) -> Result<f64> {
[INFO] [stderr]     |                            ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:415:29
[INFO] [stderr]     |
[INFO] [stderr] 415 | fn parse_vector4_expression(tokenizer: &mut Tokenizer) -> Result<Vector4<f64>> {
[INFO] [stderr]     |                             ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:419:18
[INFO] [stderr]     |
[INFO] [stderr] 419 | fn parse_boolean(tokenizer: &mut Tokenizer) -> Result<bool> {
[INFO] [stderr]     |                  ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:423:17
[INFO] [stderr]     |
[INFO] [stderr] 423 | fn parse_scalar(tokenizer: &mut Tokenizer) -> Result<f64> {
[INFO] [stderr]     |                 ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tokenizer`
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:427:18
[INFO] [stderr]     |
[INFO] [stderr] 427 | fn parse_vector4(tokenizer: &mut Tokenizer) -> Result<Vector4<f64>> {
[INFO] [stderr]     |                  ^^^^^^^^^ help: consider using `_tokenizer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:179:30
[INFO] [stderr]     |
[INFO] [stderr] 179 |         if let Some(token) = self.peek().map(|t| *t) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:216:13
[INFO] [stderr]     |
[INFO] [stderr] 216 | /             if lhs == rhs {
[INFO] [stderr] 217 | |                 return true;
[INFO] [stderr] 218 | |             } else {
[INFO] [stderr] 219 | |                 return false;
[INFO] [stderr] 220 | |             }
[INFO] [stderr]     | |_____________^ help: you can reduce it to: `return lhs == rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/parser/ray_scene_builder/mod.rs:54:28
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:106:28
[INFO] [stderr]     |
[INFO] [stderr] 106 |         let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:168:28
[INFO] [stderr]     |
[INFO] [stderr] 168 |         let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:204:32
[INFO] [stderr]     |
[INFO] [stderr] 204 |             let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:239:32
[INFO] [stderr]     |
[INFO] [stderr] 239 |             let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:318:44
[INFO] [stderr]     |
[INFO] [stderr] 318 |         if let Some( &Token::Scalar(_) ) = tokenizer.peek().map(|t| *t) {
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:376:32
[INFO] [stderr]     |
[INFO] [stderr] 376 |             let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `scene::Camera`
[INFO] [stderr]   --> src/scene/mod.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 | /     pub fn new() -> Camera {
[INFO] [stderr] 74 | |         Camera {
[INFO] [stderr] 75 | |             m: Matrix3::identity(),
[INFO] [stderr] 76 | |             eye: Vector3::zero(), // TODO: double check out glm does default vector init
[INFO] [stderr] ...  |
[INFO] [stderr] 82 | |         }
[INFO] [stderr] 83 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 72 | impl Default for scene::Camera {
[INFO] [stderr] 73 |     fn default() -> Self {
[INFO] [stderr] 74 |         Self::new()
[INFO] [stderr] 75 |     }
[INFO] [stderr] 76 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]    --> src/parser/ray_tokenizer/tests.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |     let foo = peekable.read( token::Token::Ident("_") ).unwrap();
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/parser/ray_tokenizer/tests.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 |     let bar = peekable.read( token::Token::StrLit("_") ).unwrap();
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `baz`
[INFO] [stderr]    --> src/parser/ray_tokenizer/tests.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 |     let baz = peekable.read( token::Token::Scalar(0f64) ).unwrap();
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:179:30
[INFO] [stderr]     |
[INFO] [stderr] 179 |         if let Some(token) = self.peek().map(|t| *t) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/parser/ray_tokenizer/mod.rs:216:13
[INFO] [stderr]     |
[INFO] [stderr] 216 | /             if lhs == rhs {
[INFO] [stderr] 217 | |                 return true;
[INFO] [stderr] 218 | |             } else {
[INFO] [stderr] 219 | |                 return false;
[INFO] [stderr] 220 | |             }
[INFO] [stderr]     | |_____________^ help: you can reduce it to: `return lhs == rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/parser/ray_scene_builder/mod.rs:54:28
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:106:28
[INFO] [stderr]     |
[INFO] [stderr] 106 |         let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:168:28
[INFO] [stderr]     |
[INFO] [stderr] 168 |         let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:204:32
[INFO] [stderr]     |
[INFO] [stderr] 204 |             let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:239:32
[INFO] [stderr]     |
[INFO] [stderr] 239 |             let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:318:44
[INFO] [stderr]     |
[INFO] [stderr] 318 |         if let Some( &Token::Scalar(_) ) = tokenizer.peek().map(|t| *t) {
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/parser/ray_scene_builder/mod.rs:376:32
[INFO] [stderr]     |
[INFO] [stderr] 376 |             let token_option = tokenizer.peek().map(|t| *t);
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tokenizer.peek().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `scene::Camera`
[INFO] [stderr]   --> src/scene/mod.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 | /     pub fn new() -> Camera {
[INFO] [stderr] 74 | |         Camera {
[INFO] [stderr] 75 | |             m: Matrix3::identity(),
[INFO] [stderr] 76 | |             eye: Vector3::zero(), // TODO: double check out glm does default vector init
[INFO] [stderr] ...  |
[INFO] [stderr] 82 | |         }
[INFO] [stderr] 83 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 72 | impl Default for scene::Camera {
[INFO] [stderr] 73 |     fn default() -> Self {
[INFO] [stderr] 74 |         Self::new()
[INFO] [stderr] 75 |     }
[INFO] [stderr] 76 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.43s
[INFO] running `"docker" "inspect" "d7537c0f60a3bb447712207c9e32047d2fa225b01864e55914ae2b099281426d"`
[INFO] running `"docker" "rm" "-f" "d7537c0f60a3bb447712207c9e32047d2fa225b01864e55914ae2b099281426d"`
[INFO] [stdout] d7537c0f60a3bb447712207c9e32047d2fa225b01864e55914ae2b099281426d