[INFO] updating cached repository JohnHMoses/rBoy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JohnHMoses/rBoy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JohnHMoses/rBoy" "work/ex/clippy-test-run/sources/stable/gh/JohnHMoses/rBoy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JohnHMoses/rBoy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JohnHMoses/rBoy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JohnHMoses/rBoy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JohnHMoses/rBoy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 930180c1b77773234c5caf153c9757860758263f [INFO] sha for GitHub repo JohnHMoses/rBoy: 930180c1b77773234c5caf153c9757860758263f [INFO] validating manifest of JohnHMoses/rBoy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JohnHMoses/rBoy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JohnHMoses/rBoy [INFO] finished frobbing JohnHMoses/rBoy [INFO] frobbed toml for JohnHMoses/rBoy written to work/ex/clippy-test-run/sources/stable/gh/JohnHMoses/rBoy/Cargo.toml [INFO] started frobbing JohnHMoses/rBoy [INFO] finished frobbing JohnHMoses/rBoy [INFO] frobbed toml for JohnHMoses/rBoy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JohnHMoses/rBoy/Cargo.toml [INFO] crate JohnHMoses/rBoy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JohnHMoses/rBoy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JohnHMoses/rBoy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] baa4011ce59ab99b35c13203d2b69c5cade5a94dc850f4640e3ad43dc961ab60 [INFO] running `"docker" "start" "-a" "baa4011ce59ab99b35c13203d2b69c5cade5a94dc850f4640e3ad43dc961ab60"` [INFO] [stderr] Checking rboy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `super::ByteAddressable` [INFO] [stderr] --> src/memory/tests.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::ByteAddressable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::ByteReference` [INFO] [stderr] --> src/memory/tests.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use super::ByteReference; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::Memory` [INFO] [stderr] --> src/memory/tests.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::WordAddressable` [INFO] [stderr] --> src/memory/tests.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use super::WordAddressable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::WordReference` [INFO] [stderr] --> src/memory/tests.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use super::WordReference; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return *self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return (*self.lower).read8(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*self.lower).read8()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return low_byte | high_byte; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low_byte | high_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return WordReference::new(low_ref, high_ref); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WordReference::new(low_ref, high_ref)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return (Box::new(ByteReference::new(lower)), Box::new(ByteReference::new(upper))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Box::new(ByteReference::new(lower)), Box::new(ByteReference::new(upper)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ByteReference` [INFO] [stderr] --> src/memory/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | struct ByteReference<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/memory/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | fn new(value: &'a mut u8) -> ByteReference<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `WordReference` [INFO] [stderr] --> src/memory/mod.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | struct WordReference<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/memory/mod.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn new(lower: Box, upper: Box) -> WordReference<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Memory` [INFO] [stderr] --> src/memory/mod.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | struct Memory { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/memory/mod.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn new() -> Memory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_ref` [INFO] [stderr] --> src/memory/mod.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn get_ref(&'a mut self, address: u16) -> WordReference { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_byte_refs` [INFO] [stderr] --> src/memory/mod.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | fn get_byte_refs(&'a mut self, address: usize) -> (Box, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory/mod.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let low_byte = (*self.lower).read8() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((*self.lower).read8())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory/mod.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | let high_byte = ((*self.upper).read8() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((*self.upper).read8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return *self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return (*self.lower).read8(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*self.lower).read8()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return low_byte | high_byte; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low_byte | high_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return WordReference::new(low_ref, high_ref); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WordReference::new(low_ref, high_ref)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return (Box::new(ByteReference::new(lower)), Box::new(ByteReference::new(upper))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Box::new(ByteReference::new(lower)), Box::new(ByteReference::new(upper)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory/mod.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let low_byte = (*self.lower).read8() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((*self.lower).read8())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory/mod.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | let high_byte = ((*self.upper).read8() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((*self.upper).read8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::ByteAddressable` [INFO] [stderr] --> src/memory/tests.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::ByteAddressable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::ByteReference` [INFO] [stderr] --> src/memory/tests.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use super::ByteReference; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::Memory` [INFO] [stderr] --> src/memory/tests.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::Memory; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::WordAddressable` [INFO] [stderr] --> src/memory/tests.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use super::WordAddressable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::WordReference` [INFO] [stderr] --> src/memory/tests.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use super::WordReference; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return *self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return (*self.lower).read8(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*self.lower).read8()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return low_byte | high_byte; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low_byte | high_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return WordReference::new(low_ref, high_ref); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WordReference::new(low_ref, high_ref)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return (Box::new(ByteReference::new(lower)), Box::new(ByteReference::new(upper))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Box::new(ByteReference::new(lower)), Box::new(ByteReference::new(upper)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ByteReference` [INFO] [stderr] --> src/memory/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | struct ByteReference<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/memory/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | fn new(value: &'a mut u8) -> ByteReference<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `WordReference` [INFO] [stderr] --> src/memory/mod.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | struct WordReference<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/memory/mod.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn new(lower: Box, upper: Box) -> WordReference<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Memory` [INFO] [stderr] --> src/memory/mod.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | struct Memory { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/memory/mod.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn new() -> Memory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_ref` [INFO] [stderr] --> src/memory/mod.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn get_ref(&'a mut self, address: u16) -> WordReference { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_byte_refs` [INFO] [stderr] --> src/memory/mod.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | fn get_byte_refs(&'a mut self, address: usize) -> (Box, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory/mod.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let low_byte = (*self.lower).read8() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((*self.lower).read8())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory/mod.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | let high_byte = ((*self.upper).read8() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((*self.upper).read8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return *self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return (*self.lower).read8(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*self.lower).read8()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return low_byte | high_byte; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low_byte | high_byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return WordReference::new(low_ref, high_ref); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WordReference::new(low_ref, high_ref)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return (Box::new(ByteReference::new(lower)), Box::new(ByteReference::new(upper))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Box::new(ByteReference::new(lower)), Box::new(ByteReference::new(upper)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory/mod.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let low_byte = (*self.lower).read8() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((*self.lower).read8())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory/mod.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | let high_byte = ((*self.upper).read8() as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((*self.upper).read8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "baa4011ce59ab99b35c13203d2b69c5cade5a94dc850f4640e3ad43dc961ab60"` [INFO] running `"docker" "rm" "-f" "baa4011ce59ab99b35c13203d2b69c5cade5a94dc850f4640e3ad43dc961ab60"` [INFO] [stdout] baa4011ce59ab99b35c13203d2b69c5cade5a94dc850f4640e3ad43dc961ab60