[INFO] updating cached repository JoTiger/rustray
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/JoTiger/rustray
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/JoTiger/rustray" "work/ex/clippy-test-run/sources/stable/gh/JoTiger/rustray"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JoTiger/rustray'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/JoTiger/rustray" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoTiger/rustray"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoTiger/rustray'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3b0d80758a3c76720a88a09c8addab6dc6f9e6ca
[INFO] sha for GitHub repo JoTiger/rustray: 3b0d80758a3c76720a88a09c8addab6dc6f9e6ca
[INFO] validating manifest of JoTiger/rustray on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of JoTiger/rustray on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing JoTiger/rustray
[INFO] finished frobbing JoTiger/rustray
[INFO] frobbed toml for JoTiger/rustray written to work/ex/clippy-test-run/sources/stable/gh/JoTiger/rustray/Cargo.toml
[INFO] started frobbing JoTiger/rustray
[INFO] finished frobbing JoTiger/rustray
[INFO] frobbed toml for JoTiger/rustray written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoTiger/rustray/Cargo.toml
[INFO] crate JoTiger/rustray has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting JoTiger/rustray against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JoTiger/rustray:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7bad83f1664fc797fc5557d91abbcf06e9d2326304e3ac0e46fd4757cd013fd0
[INFO] running `"docker" "start" "-a" "7bad83f1664fc797fc5557d91abbcf06e9d2326304e3ac0e46fd4757cd013fd0"`
[INFO] [stderr]     Checking ray v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |             u: u,
[INFO] [stderr]    |             ^^^^ help: replace it with: `u`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |             v: v,
[INFO] [stderr]    |             ^^^^ help: replace it with: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             w: w,
[INFO] [stderr]    |             ^^^^ help: replace it with: `w`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:191:13
[INFO] [stderr]     |
[INFO] [stderr] 191 |             print!("{} {} {}\n", ir, ig, ib);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |             u: u,
[INFO] [stderr]    |             ^^^^ help: replace it with: `u`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |             v: v,
[INFO] [stderr]    |             ^^^^ help: replace it with: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             w: w,
[INFO] [stderr]    |             ^^^^ help: replace it with: `w`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:191:13
[INFO] [stderr]     |
[INFO] [stderr] 191 |             print!("{} {} {}\n", ir, ig, ib);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         return self.e[0];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return self.e[1];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         return self.e[2];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return self.e[0];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         return self.e[1];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return self.e[2];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `vec3::dot`
[INFO] [stderr]  --> src/main.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use vec3::dot;
[INFO] [stderr]   |     ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hit.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         return hit_anything;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hit_anything`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sphere.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         return self.mat;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.mat`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `sphere::Sphere`
[INFO] [stderr]  --> src/sample.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use sphere::Sphere;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `sample::random_in_unit_sphere`
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | use sample::random_in_unit_sphere;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/material.rs:122:9
[INFO] [stderr]     |
[INFO] [stderr] 122 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             return attenuation * color(&scattered, world, depth + 1);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `attenuation * color(&scattered, world, depth + 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:62:9
[INFO] [stderr]    |
[INFO] [stderr] 62 |         return (1.0 - t) * Vec3f::new(1.0, 1.0, 1.0) + t * Vec3f::new(0.5, 0.7, 1.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(1.0 - t) * Vec3f::new(1.0, 1.0, 1.0) + t * Vec3f::new(0.5, 0.7, 1.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]   --> src/main.rs:94:14
[INFO] [stderr]    |
[INFO] [stderr] 94 |     for m in (0..500) {
[INFO] [stderr]    |              ^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/main.rs:121:14
[INFO] [stderr]     |
[INFO] [stderr] 121 |     for a in (-11..11) {
[INFO] [stderr]     |              ^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/main.rs:122:18
[INFO] [stderr]     |
[INFO] [stderr] 122 |         for b in (-11..11) {
[INFO] [stderr]     |                  ^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/main.rs:175:18
[INFO] [stderr]     |
[INFO] [stderr] 175 |         for i in (0..nx) {
[INFO] [stderr]     |                  ^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/main.rs:177:22
[INFO] [stderr]     |
[INFO] [stderr] 177 |             for s in (0..ns) {
[INFO] [stderr]     |                      ^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         return self.e[0];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         return self.e[1];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         return self.e[2];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return self.e[0];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         return self.e[1];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vec3.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return self.e[2];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.e[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `vec3::dot`
[INFO] [stderr]  --> src/main.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use vec3::dot;
[INFO] [stderr]   |     ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hit.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         return hit_anything;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hit_anything`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sphere.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         return self.mat;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.mat`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `sphere::Sphere`
[INFO] [stderr]  --> src/sample.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use sphere::Sphere;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `sample::random_in_unit_sphere`
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | use sample::random_in_unit_sphere;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/material.rs:122:9
[INFO] [stderr]     |
[INFO] [stderr] 122 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             return attenuation * color(&scattered, world, depth + 1);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `attenuation * color(&scattered, world, depth + 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:62:9
[INFO] [stderr]    |
[INFO] [stderr] 62 |         return (1.0 - t) * Vec3f::new(1.0, 1.0, 1.0) + t * Vec3f::new(0.5, 0.7, 1.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(1.0 - t) * Vec3f::new(1.0, 1.0, 1.0) + t * Vec3f::new(0.5, 0.7, 1.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]   --> src/main.rs:94:14
[INFO] [stderr]    |
[INFO] [stderr] 94 |     for m in (0..500) {
[INFO] [stderr]    |              ^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/main.rs:121:14
[INFO] [stderr]     |
[INFO] [stderr] 121 |     for a in (-11..11) {
[INFO] [stderr]     |              ^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/main.rs:122:18
[INFO] [stderr]     |
[INFO] [stderr] 122 |         for b in (-11..11) {
[INFO] [stderr]     |                  ^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/main.rs:175:18
[INFO] [stderr]     |
[INFO] [stderr] 175 |         for i in (0..nx) {
[INFO] [stderr]     |                  ^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/main.rs:177:22
[INFO] [stderr]     |
[INFO] [stderr] 177 |             for s in (0..ns) {
[INFO] [stderr]     |                      ^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `m`
[INFO] [stderr]   --> src/main.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 |     for m in (0..500) {
[INFO] [stderr]    |         ^ help: consider using `_m` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `R`
[INFO] [stderr]    --> src/main.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 |     let R = (std::f32::consts::PI / 4.0).cos();
[INFO] [stderr]     |         ^ help: consider using `_R` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `s`
[INFO] [stderr]    --> src/main.rs:177:17
[INFO] [stderr]     |
[INFO] [stderr] 177 |             for s in (0..ns) {
[INFO] [stderr]     |                 ^ help: consider using `_s` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `p`
[INFO] [stderr]    --> src/main.rs:183:21
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 let p = r.point_at_parameter(2.0);
[INFO] [stderr]     |                     ^ help: consider using `_p` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `r_in`
[INFO] [stderr]   --> src/material.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         r_in: &Ray,
[INFO] [stderr]    |         ^^^^ help: consider using `_r_in` instead
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `w`
[INFO] [stderr]   --> src/camera.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     w: Vec3f,
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/vec3.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 |         &self + &other
[INFO] [stderr]    |         ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 83 |         self + other
[INFO] [stderr]    |         ^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/vec3.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         &self - &other
[INFO] [stderr]     |         ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 105 |         self - other
[INFO] [stderr]     |         ^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]    --> src/vec3.rs:186:14
[INFO] [stderr]     |
[INFO] [stderr] 186 |         self * rcp
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ray.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn origin<'a>(&'a self) -> &'a Vec3f {
[INFO] [stderr] 11 | |         &self.a
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ray.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     pub fn direction<'a>(&'a self) -> &'a Vec3f {
[INFO] [stderr] 15 | |         &self.b
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ray.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn point_at_parameter<'a>(&'a self, t: f32) -> Vec3f {
[INFO] [stderr] 19 | |         self.a + t * self.b
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/sphere.rs:27:18
[INFO] [stderr]    |
[INFO] [stderr] 27 |         let oc = ray.origin() - &self.center;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^------------
[INFO] [stderr]    |                                 |
[INFO] [stderr]    |                                 help: use the right value directly: `self.center`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/material.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 | /         let cosine: f32;
[INFO] [stderr] 88 | |         if dot(r_in.direction(), &rec.normal) > 0.0 {
[INFO] [stderr] 89 | |             outward_normal = -rec.normal;
[INFO] [stderr] 90 | |             ni_over_nt = self.ref_idx;
[INFO] [stderr] ...  |
[INFO] [stderr] 95 | |             cosine = -dot(r_in.direction(), &rec.normal) / r_in.direction().length();
[INFO] [stderr] 96 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let cosine = if dot(r_in.direction(), &rec.normal) > 0.0 { ..; self.ref_idx * dot(r_in.direction(), &rec.normal) / r_in.direction().length() } else { ..; -dot(r_in.direction(), &rec.normal) / r_in.direction().length() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: variable `R` should have a snake case name such as `r`
[INFO] [stderr]    --> src/main.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 |     let R = (std::f32::consts::PI / 4.0).cos();
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `ray`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused variable: `m`
[INFO] [stderr]   --> src/main.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 |     for m in (0..500) {
[INFO] [stderr]    |         ^ help: consider using `_m` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `R`
[INFO] [stderr]    --> src/main.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 |     let R = (std::f32::consts::PI / 4.0).cos();
[INFO] [stderr]     |         ^ help: consider using `_R` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `s`
[INFO] [stderr]    --> src/main.rs:177:17
[INFO] [stderr]     |
[INFO] [stderr] 177 |             for s in (0..ns) {
[INFO] [stderr]     |                 ^ help: consider using `_s` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `p`
[INFO] [stderr]    --> src/main.rs:183:21
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 let p = r.point_at_parameter(2.0);
[INFO] [stderr]     |                     ^ help: consider using `_p` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `r_in`
[INFO] [stderr]   --> src/material.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         r_in: &Ray,
[INFO] [stderr]    |         ^^^^ help: consider using `_r_in` instead
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `w`
[INFO] [stderr]   --> src/camera.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     w: Vec3f,
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/vec3.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 |         &self + &other
[INFO] [stderr]    |         ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 83 |         self + other
[INFO] [stderr]    |         ^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/vec3.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 |         &self - &other
[INFO] [stderr]     |         ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 105 |         self - other
[INFO] [stderr]     |         ^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]    --> src/vec3.rs:186:14
[INFO] [stderr]     |
[INFO] [stderr] 186 |         self * rcp
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/vec3.rs:205:5
[INFO] [stderr]     |
[INFO] [stderr] 205 |     assert_eq!(v3.x(), 1.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/vec3.rs:205:5
[INFO] [stderr]     |
[INFO] [stderr] 205 |     assert_eq!(v3.x(), 1.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/vec3.rs:206:5
[INFO] [stderr]     |
[INFO] [stderr] 206 |     assert_eq!(v3.y(), 3.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/vec3.rs:206:5
[INFO] [stderr]     |
[INFO] [stderr] 206 |     assert_eq!(v3.y(), 3.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/vec3.rs:207:5
[INFO] [stderr]     |
[INFO] [stderr] 207 |     assert_eq!(v3.z(), 5.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/vec3.rs:207:5
[INFO] [stderr]     |
[INFO] [stderr] 207 |     assert_eq!(v3.z(), 5.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/vec3.rs:209:14
[INFO] [stderr]     |
[INFO] [stderr] 209 |     let v4 = &v1 + &v2;
[INFO] [stderr]     |              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 209 |     let v4 = v1 + v2;
[INFO] [stderr]     |              ^^   ^^
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/vec3.rs:210:5
[INFO] [stderr]     |
[INFO] [stderr] 210 |     assert_eq!(v4.x(), 1.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/vec3.rs:210:5
[INFO] [stderr]     |
[INFO] [stderr] 210 |     assert_eq!(v4.x(), 1.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/vec3.rs:211:5
[INFO] [stderr]     |
[INFO] [stderr] 211 |     assert_eq!(v4.y(), 3.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/vec3.rs:211:5
[INFO] [stderr]     |
[INFO] [stderr] 211 |     assert_eq!(v4.y(), 3.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/vec3.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 |     assert_eq!(v4.z(), 5.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/vec3.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 |     assert_eq!(v4.z(), 5.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/vec3.rs:220:5
[INFO] [stderr]     |
[INFO] [stderr] 220 |     assert_eq!(v.length(), 13.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/vec3.rs:220:5
[INFO] [stderr]     |
[INFO] [stderr] 220 |     assert_eq!(v.length(), 13.0);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ray.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn origin<'a>(&'a self) -> &'a Vec3f {
[INFO] [stderr] 11 | |         &self.a
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ray.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     pub fn direction<'a>(&'a self) -> &'a Vec3f {
[INFO] [stderr] 15 | |         &self.b
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ray.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn point_at_parameter<'a>(&'a self, t: f32) -> Vec3f {
[INFO] [stderr] 19 | |         self.a + t * self.b
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/ray.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     assert_eq!(p.x(), 2.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/ray.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     assert_eq!(p.x(), 2.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/ray.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     assert_eq!(p.y(), 5.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/ray.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     assert_eq!(p.y(), 5.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/ray.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     assert_eq!(p.z(), 8.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/ray.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     assert_eq!(p.z(), 8.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/sphere.rs:27:18
[INFO] [stderr]    |
[INFO] [stderr] 27 |         let oc = ray.origin() - &self.center;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^------------
[INFO] [stderr]    |                                 |
[INFO] [stderr]    |                                 help: use the right value directly: `self.center`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/material.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 | /         let cosine: f32;
[INFO] [stderr] 88 | |         if dot(r_in.direction(), &rec.normal) > 0.0 {
[INFO] [stderr] 89 | |             outward_normal = -rec.normal;
[INFO] [stderr] 90 | |             ni_over_nt = self.ref_idx;
[INFO] [stderr] ...  |
[INFO] [stderr] 95 | |             cosine = -dot(r_in.direction(), &rec.normal) / r_in.direction().length();
[INFO] [stderr] 96 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let cosine = if dot(r_in.direction(), &rec.normal) > 0.0 { ..; self.ref_idx * dot(r_in.direction(), &rec.normal) / r_in.direction().length() } else { ..; -dot(r_in.direction(), &rec.normal) / r_in.direction().length() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: variable `R` should have a snake case name such as `r`
[INFO] [stderr]    --> src/main.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 |     let R = (std::f32::consts::PI / 4.0).cos();
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 11 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `ray`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "7bad83f1664fc797fc5557d91abbcf06e9d2326304e3ac0e46fd4757cd013fd0"`
[INFO] running `"docker" "rm" "-f" "7bad83f1664fc797fc5557d91abbcf06e9d2326304e3ac0e46fd4757cd013fd0"`
[INFO] [stdout] 7bad83f1664fc797fc5557d91abbcf06e9d2326304e3ac0e46fd4757cd013fd0