[INFO] updating cached repository JoNil/plotter-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JoNil/plotter-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JoNil/plotter-rs" "work/ex/clippy-test-run/sources/stable/gh/JoNil/plotter-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JoNil/plotter-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JoNil/plotter-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoNil/plotter-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoNil/plotter-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 56a04f6463b848372f65850b117abde9dc717007 [INFO] sha for GitHub repo JoNil/plotter-rs: 56a04f6463b848372f65850b117abde9dc717007 [INFO] validating manifest of JoNil/plotter-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JoNil/plotter-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JoNil/plotter-rs [INFO] finished frobbing JoNil/plotter-rs [INFO] frobbed toml for JoNil/plotter-rs written to work/ex/clippy-test-run/sources/stable/gh/JoNil/plotter-rs/Cargo.toml [INFO] started frobbing JoNil/plotter-rs [INFO] finished frobbing JoNil/plotter-rs [INFO] frobbed toml for JoNil/plotter-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoNil/plotter-rs/Cargo.toml [INFO] crate JoNil/plotter-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting JoNil/plotter-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/JoNil/plotter-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 65b816a9d200ec5427537a4e7ae86a0a46fafdbed5b8988b316c87553acb5847 [INFO] running `"docker" "start" "-a" "65b816a9d200ec5427537a4e7ae86a0a46fafdbed5b8988b316c87553acb5847"` [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking downcast-rs v1.0.3 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking remove_dir_all v0.5.1 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking clamp v0.1.0 [INFO] [stderr] Compiling imgui-sys v0.0.21 [INFO] [stderr] Compiling log v0.4.5 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Compiling nfd v0.0.4 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking inflate v0.4.3 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Checking libloading v0.5.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking smallvec v0.6.5 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking x11-dl v2.18.3 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Compiling syn v0.15.13 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking tempfile v3.0.4 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking serialport v3.0.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking imgui v0.0.21 [INFO] [stderr] Checking imgui-glium-renderer v0.0.21 [INFO] [stderr] Checking plotter-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:244:28 [INFO] [stderr] | [INFO] [stderr] 244 | baud_rate: 250000, [INFO] [stderr] | ^^^^^^ help: consider: `250_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:314:51 [INFO] [stderr] | [INFO] [stderr] 314 | let high = (value >> 8) & 0b00011111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:315:43 [INFO] [stderr] | [INFO] [stderr] 315 | let low = value & 0b00011111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:338:29 [INFO] [stderr] | [INFO] [stderr] 338 | time [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:333:33 [INFO] [stderr] | [INFO] [stderr] 333 | / ( ((time_packed >> 3) & 0x0fe0_0000) [INFO] [stderr] 334 | | | ((time_packed >> 2) & 0x001f_c000) [INFO] [stderr] 335 | | | ((time_packed >> 1) & 0x0000_3f80) [INFO] [stderr] 336 | | | ((time_packed) & 0x0000_007f)) << 4; [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:524:73 [INFO] [stderr] | [INFO] [stderr] 524 | .add_line((p1.x, -p1.y), (p2.x, -p2.y), 0xdf00dfff) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdf00_dfff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:566:73 [INFO] [stderr] | [INFO] [stderr] 566 | .add_line((p1.x, -p1.y), (p2.x, -p2.y), 0xdf1010ff) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdf10_10ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:579:64 [INFO] [stderr] | [INFO] [stderr] 579 | draw_list.add_line((x1, -y), (x2, -y), 0x602a2aff).build(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x602a_2aff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:581:64 [INFO] [stderr] | [INFO] [stderr] 581 | draw_list.add_line((x1, -y), (x2, -y), 0x2a2a2aff).build(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2a2a_2aff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:583:64 [INFO] [stderr] | [INFO] [stderr] 583 | draw_list.add_line((x1, -y), (x2, -y), 0x2a2a2aff).build(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2a2a_2aff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:594:65 [INFO] [stderr] | [INFO] [stderr] 594 | .add_line((x1, -rise_y), (x2, -rise_y), 0xa0ff2a2a) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa0ff_2a2a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.data0.get((x as i32 % 32) as usize).map(|p| *p) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.data0.get((x as i32 % 32) as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | / match serialport::open_with_settings(&port, &s) { [INFO] [stderr] 259 | | Ok(s) => { [INFO] [stderr] 260 | | println!("Using {}", port); [INFO] [stderr] 261 | | sp = Some(s); [INFO] [stderr] ... | [INFO] [stderr] 264 | | Err(_) => {} [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 258 | if let Ok(s) = serialport::open_with_settings(&port, &s) { [INFO] [stderr] 259 | println!("Using {}", port); [INFO] [stderr] 260 | sp = Some(s); [INFO] [stderr] 261 | break; [INFO] [stderr] 262 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:319:55 [INFO] [stderr] | [INFO] [stderr] 319 | let analog_flipped = 1024.0 - analog as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(analog)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:321:48 [INFO] [stderr] | [INFO] [stderr] 321 | let ch0_smooth_value = *ch0_smooth.lock().unwrap() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*ch0_smooth.lock().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:351:61 [INFO] [stderr] | [INFO] [stderr] 351 | if measuring_cycle && ch0_avg < *rise_value.lock().unwrap() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*rise_value.lock().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:354:48 [INFO] [stderr] | [INFO] [stderr] 354 | println!("{}", latency as f64 / 1000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(latency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:458:25 [INFO] [stderr] | [INFO] [stderr] 458 | state.last_mouse_state.pos.0 as f64 - state.mouse_state.pos.0 as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.last_mouse_state.pos.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:458:63 [INFO] [stderr] | [INFO] [stderr] 458 | state.last_mouse_state.pos.0 as f64 - state.mouse_state.pos.0 as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.mouse_state.pos.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:460:25 [INFO] [stderr] | [INFO] [stderr] 460 | state.last_mouse_state.pos.1 as f64 - state.mouse_state.pos.1 as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.last_mouse_state.pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:460:63 [INFO] [stderr] | [INFO] [stderr] 460 | state.last_mouse_state.pos.1 as f64 - state.mouse_state.pos.1 as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.mouse_state.pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:465:25 [INFO] [stderr] | [INFO] [stderr] 465 | state.mouse_state.pos.0 as f64 - view_size.0 as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.mouse_state.pos.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:465:58 [INFO] [stderr] | [INFO] [stderr] 465 | state.mouse_state.pos.0 as f64 - view_size.0 as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(view_size.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:468:47 [INFO] [stderr] | [INFO] [stderr] 468 | state.scroll_factor - state.mouse_state.wheel as f64 / 10.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.mouse_state.wheel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:501:49 [INFO] [stderr] | [INFO] [stderr] 501 | let x_lookup = scale * (x as f64 + state.pan.0 - view_size.0 as f64 / 2.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:501:74 [INFO] [stderr] | [INFO] [stderr] 501 | let x_lookup = scale * (x as f64 + state.pan.0 - view_size.0 as f64 / 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(view_size.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:506:35 [INFO] [stderr] | [INFO] [stderr] 506 | ((state.ch0_scale as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.ch0_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:507:39 [INFO] [stderr] | [INFO] [stderr] 507 | * state.window_y_scale as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.window_y_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:508:48 [INFO] [stderr] | [INFO] [stderr] 508 | * (value + state.ch0_pan as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.ch0_pan)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:510:39 [INFO] [stderr] | [INFO] [stderr] 510 | - view_size.1 as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(view_size.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:543:49 [INFO] [stderr] | [INFO] [stderr] 543 | let x_lookup = scale * (x as f64 + state.pan.0 - view_size.0 as f64 / 2.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:543:74 [INFO] [stderr] | [INFO] [stderr] 543 | let x_lookup = scale * (x as f64 + state.pan.0 - view_size.0 as f64 / 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(view_size.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:548:35 [INFO] [stderr] | [INFO] [stderr] 548 | ((state.ch1_scale as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.ch1_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:549:39 [INFO] [stderr] | [INFO] [stderr] 549 | * state.window_y_scale as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.window_y_scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:550:48 [INFO] [stderr] | [INFO] [stderr] 550 | * (value + state.ch1_pan as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(state.ch1_pan)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:552:39 [INFO] [stderr] | [INFO] [stderr] 552 | - view_size.1 as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(view_size.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:575:44 [INFO] [stderr] | [INFO] [stderr] 575 | let y = (state.pan.1 - view_size.1 as f64 / 2.0) as f32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(view_size.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:582:28 [INFO] [stderr] | [INFO] [stderr] 582 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 583 | | draw_list.add_line((x1, -y), (x2, -y), 0x2a2a2aff).build(); [INFO] [stderr] 584 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:580:37 [INFO] [stderr] | [INFO] [stderr] 580 | } else if i < 0 { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 581 | | draw_list.add_line((x1, -y), (x2, -y), 0x2a2a2aff).build(); [INFO] [stderr] 582 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:590:49 [INFO] [stderr] | [INFO] [stderr] 590 | let rise_y = (state.pan.1 - view_size.1 as f64 / 2.0) as f32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(view_size.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:733:53 [INFO] [stderr] | [INFO] [stderr] 733 | Event::DeviceEvent { event, .. } => match event { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 734 | | DeviceEvent::MouseMotion { delta: (x, y), .. } => { [INFO] [stderr] 735 | | s.mouse_state.pos.0 += x as i32; [INFO] [stderr] 736 | | s.mouse_state.pos.1 += y as i32; [INFO] [stderr] 737 | | } [INFO] [stderr] 738 | | _ => (), [INFO] [stderr] 739 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 733 | Event::DeviceEvent { event, .. } => if let DeviceEvent::MouseMotion { delta: (x, y), .. } = event { [INFO] [stderr] 734 | s.mouse_state.pos.0 += x as i32; [INFO] [stderr] 735 | s.mouse_state.pos.1 += y as i32; [INFO] [stderr] 736 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `plotter-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "65b816a9d200ec5427537a4e7ae86a0a46fafdbed5b8988b316c87553acb5847"` [INFO] running `"docker" "rm" "-f" "65b816a9d200ec5427537a4e7ae86a0a46fafdbed5b8988b316c87553acb5847"` [INFO] [stdout] 65b816a9d200ec5427537a4e7ae86a0a46fafdbed5b8988b316c87553acb5847