[INFO] updating cached repository Jkillelea/hn-reader-new
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Jkillelea/hn-reader-new
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Jkillelea/hn-reader-new" "work/ex/clippy-test-run/sources/stable/gh/Jkillelea/hn-reader-new"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Jkillelea/hn-reader-new'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Jkillelea/hn-reader-new" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jkillelea/hn-reader-new"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jkillelea/hn-reader-new'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 203f2fa3634aaab7cd18fd91b0e3277ec967df3c
[INFO] sha for GitHub repo Jkillelea/hn-reader-new: 203f2fa3634aaab7cd18fd91b0e3277ec967df3c
[INFO] validating manifest of Jkillelea/hn-reader-new on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Jkillelea/hn-reader-new on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Jkillelea/hn-reader-new
[INFO] finished frobbing Jkillelea/hn-reader-new
[INFO] frobbed toml for Jkillelea/hn-reader-new written to work/ex/clippy-test-run/sources/stable/gh/Jkillelea/hn-reader-new/Cargo.toml
[INFO] started frobbing Jkillelea/hn-reader-new
[INFO] finished frobbing Jkillelea/hn-reader-new
[INFO] frobbed toml for Jkillelea/hn-reader-new written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Jkillelea/hn-reader-new/Cargo.toml
[INFO] crate Jkillelea/hn-reader-new has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Jkillelea/hn-reader-new against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Jkillelea/hn-reader-new:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8e10fb60066c96e1c9218d8b83affe78cac11d3651d014c0e5f279fcffe48509
[INFO] running `"docker" "start" "-a" "8e10fb60066c96e1c9218d8b83affe78cac11d3651d014c0e5f279fcffe48509"`
[INFO] [stderr]     Checking hn-reader-new v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `serde_json`
[INFO] [stderr]  --> src/article.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 | use serde_json;
[INFO] [stderr]   |     ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 9999999
[INFO] [stderr]    |                 ^^^^^^^ help: consider: `9_999_999`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `serde_json`
[INFO] [stderr]  --> src/article.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 | use serde_json;
[INFO] [stderr]   |     ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 9999999
[INFO] [stderr]    |                 ^^^^^^^ help: consider: `9_999_999`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/article.rs:30:38
[INFO] [stderr]    |
[INFO] [stderr] 30 |             thread_running: Arc::new(Mutex::new(true))
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:31:27
[INFO] [stderr]    |
[INFO] [stderr] 31 |     while let Some(art) = article_buffer.next() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^ help: try: `for art in article_buffer { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:46:43
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn char_delimited_string_to_array(string: &String) -> Result<Vec<i32>, Box<error::Error>> {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:47:29
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let vals = string.split(",").map(|x| {
[INFO] [stderr]    |                             ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:49:16
[INFO] [stderr]    |
[INFO] [stderr] 49 |             if x.clone().chars().next().unwrap().is_numeric() { // last char is non-numeric
[INFO] [stderr]    |                ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 49 |             if &(*x).clone().chars().next().unwrap().is_numeric() { // last char is non-numeric
[INFO] [stderr]    |                ^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 49 |             if &str::clone(x).chars().next().unwrap().is_numeric() { // last char is non-numeric
[INFO] [stderr]    |                ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:52:23
[INFO] [stderr]    |
[INFO] [stderr] 52 |             } else if x.clone().chars().last().unwrap().is_numeric() { // first char is non-numeric
[INFO] [stderr]    |                       ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 52 |             } else if &(*x).clone().chars().last().unwrap().is_numeric() { // first char is non-numeric
[INFO] [stderr]    |                       ^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 52 |             } else if &str::clone(x).chars().last().unwrap().is_numeric() { // first char is non-numeric
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `hn-reader-new`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/article.rs:30:38
[INFO] [stderr]    |
[INFO] [stderr] 30 |             thread_running: Arc::new(Mutex::new(true))
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:31:27
[INFO] [stderr]    |
[INFO] [stderr] 31 |     while let Some(art) = article_buffer.next() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^ help: try: `for art in article_buffer { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:46:43
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn char_delimited_string_to_array(string: &String) -> Result<Vec<i32>, Box<error::Error>> {
[INFO] [stderr]    |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:47:29
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let vals = string.split(",").map(|x| {
[INFO] [stderr]    |                             ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:49:16
[INFO] [stderr]    |
[INFO] [stderr] 49 |             if x.clone().chars().next().unwrap().is_numeric() { // last char is non-numeric
[INFO] [stderr]    |                ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 49 |             if &(*x).clone().chars().next().unwrap().is_numeric() { // last char is non-numeric
[INFO] [stderr]    |                ^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 49 |             if &str::clone(x).chars().next().unwrap().is_numeric() { // last char is non-numeric
[INFO] [stderr]    |                ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/main.rs:52:23
[INFO] [stderr]    |
[INFO] [stderr] 52 |             } else if x.clone().chars().last().unwrap().is_numeric() { // first char is non-numeric
[INFO] [stderr]    |                       ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 52 |             } else if &(*x).clone().chars().last().unwrap().is_numeric() { // first char is non-numeric
[INFO] [stderr]    |                       ^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 52 |             } else if &str::clone(x).chars().last().unwrap().is_numeric() { // first char is non-numeric
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `hn-reader-new`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "8e10fb60066c96e1c9218d8b83affe78cac11d3651d014c0e5f279fcffe48509"`
[INFO] running `"docker" "rm" "-f" "8e10fb60066c96e1c9218d8b83affe78cac11d3651d014c0e5f279fcffe48509"`
[INFO] [stdout] 8e10fb60066c96e1c9218d8b83affe78cac11d3651d014c0e5f279fcffe48509